Re: [PATCH 06/21] Staging: rtl8723bs: remove enums in osdep_service.h

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marco Cesati <marcocesati@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 06/21] Staging: rtl8723bs: remove enums in osdep_service.h
Date: Wed, 24 Mar 2021 21:59:19 +0300	[thread overview]
Message-ID: <20210324185919.GO1717@kadam> (raw)
In-Reply-To: <20210324183847.5595-7-marcocesati@gmail.com>

On Wed, Mar 24, 2021 at 07:38:32PM +0100, Marco Cesati wrote:
> Remove the following unnecessary enum definitions in
> include/osdep_service.h:
> 
> 	enum mstat_f
> 	enum mstat_status
> 
> Signed-off-by: Marco Cesati <marcocesati@gmail.com>
> ---
>  .../staging/rtl8723bs/include/osdep_service.h | 23 -------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
> index c4d29d65187f..9405bdb2abf0 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service.h
> @@ -59,33 +59,10 @@
>  extern int RTW_STATUS_CODE(int error_code);
>  
>  /* flags used for rtw_mstat_update() */

This comment doesn't make sense any more.  Also we can delete
rtw_mstat_update().  Feel free to delete this in a follow on patch
instead of resending.

> -enum mstat_f {
> -	/* type: 0x00ff */
> -	MSTAT_TYPE_VIR = 0x00,
> -	MSTAT_TYPE_PHY = 0x01,

regards,
dan carpenter