From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86DCBC433DB for ; Thu, 25 Mar 2021 02:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55BE261A21 for ; Thu, 25 Mar 2021 02:10:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231757AbhCYCKJ (ORCPT ); Wed, 24 Mar 2021 22:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234257AbhCYCJz (ORCPT ); Wed, 24 Mar 2021 22:09:55 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA793C06174A for ; Wed, 24 Mar 2021 19:09:55 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id l1so270508pgb.5 for ; Wed, 24 Mar 2021 19:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GnPkrUWVHgQAkE7X9Q+gS1Rm0hw8IZfxa51KQLQaH2w=; b=APFhGsnvbabBnyPJKGOX/84vrQW9EE5xS06+iv5qV4t5nvQXqDViUjmAOjrVJiQj2J Cwk+AkMAfN0PR8vAIY4ARrwsy01cSc8001Z/eiEnv4CMGx1Sle1hJjyRaI5MwvmcdUV+ jwb7leeD0C8/Dncxzlsp3Qip4Xy8WCg9HhV5axzjsXIFNNB4xxz0AYT4sI6EUrK95bKy FUnkX3OT5sJJBF0Uaz23lAJeBGJ1hD5XM+icNGNHkdOR8RHuOtovNLF3Veas4WXp2QNv HMQTB85iKg+HFOq4gS2TQCnMWMAG9ebH2mUWblX3DMNFJdLP/T/HOxkoReTfwUpKQVH8 /97w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GnPkrUWVHgQAkE7X9Q+gS1Rm0hw8IZfxa51KQLQaH2w=; b=fYNvKVJRWHt+ELazMgz95cmQ9w1qyFAZsfFNRfF41Uqr6TM4PZhLt3MCVdK9anHday +kzaR3l4jJZjWtzZSoLEopRqbA03x2WoEpubH1sCFSovyZyBXe3SvwhuRc0XnrdXLHTg tNPsMuMKNZw3dfhFvW3PvXU2SS0mIjcqAFRLj1XVNMP+m1CIzX+jb9JXdj1aM7cDrNzw r2sCx8PsaAWFpGVfYRIBOgN3GTSvMS+EqDvAidOarX0CFrtI7D6GVnBxU5DufxQBQgqR HXWuVVV6ZEtiyz8kOUsjJEG51cwbQJKTgrqL1zWJrQCyWk4PIQH5mwA3cRiA/GvHYlEq pP9Q== X-Gm-Message-State: AOAM533gw0C/iV4+cPSRZiPnHNQiL347ktpoUGidT4DyH4TGdU3GrUNl jPMrnx0TmFX4mb0DLwF5oRTN7jp+/gTpCw== X-Google-Smtp-Source: ABdhPJxU2KB058XE51CYUcSMipnPvf0Qk5VzTZS8EsUwLZjX4qc3Y6n8xujrzD2lZFufpuw3Huu37w== X-Received: by 2002:a17:902:d4cc:b029:e4:9cd9:f189 with SMTP id o12-20020a170902d4ccb02900e49cd9f189mr6587626plg.53.1616638194758; Wed, 24 Mar 2021 19:09:54 -0700 (PDT) Received: from localhost ([58.127.46.74]) by smtp.gmail.com with ESMTPSA id i8sm3706537pjl.32.2021.03.24.19.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 19:09:54 -0700 (PDT) Date: Thu, 25 Mar 2021 11:09:51 +0900 From: Minwoo Im To: Niklas Cassel Cc: "javier@javigon.com" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" , "linux-block@vger.kernel.org" , "kbusch@kernel.org" , Javier =?utf-8?B?R29uesOhbGV6?= , "hch@lst.de" Subject: Re: [PATCH V6 1/2] nvme: enable char device per namespace Message-ID: <20210325020951.GA2105@localhost> References: <20210301192452.16770-1-javier.gonz@samsung.com> <20210301192452.16770-2-javier.gonz@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 21-03-24 12:29:32, Niklas Cassel wrote: > On Mon, Mar 01, 2021 at 08:24:51PM +0100, javier@javigon.com wrote: > > From: Javier González > > > > Create a char device per NVMe namespace. This char device is always > > initialized, independently of whether the features implemented by the > > device are supported by the kernel. User-space can therefore always > > issue IOCTLs to the NVMe driver using the char device. > > > > The char device is presented as /dev/nvme-generic-XcYnZ. This naming > > scheme follows the convention of the hidden device (nvmeXcYnZ). Support > > for multipath will follow. > > > > Hello all, > > Looking at the discussion that led up to the current design: > https://lore.kernel.org/linux-block/20201102185851.GA21349@lst.de/ > > Keith initially suggested: > > a) Set up the existing controller character device with a generic > disk-less request_queue to the IO queues accepting IO commands to > arbitrary NSIDs. > > However Christoph replied: > > The problem with a) is that it can't be used to give users or groups > access to just one namespaces, so it causes a real access control > nightmare. > > c) Each namespace gets its own character device, period. Thanks for summarizing this up! > However, testing this patch series out: > > crw------- 1 root root 249, 0 Mar 24 11:32 /dev/nvme-generic-0c0n1 > crw------- 1 root root 249, 1 Mar 24 11:32 /dev/nvme-generic-0c0n2 > crw------- 1 root root 250, 0 Mar 24 11:32 /dev/nvme0 > brw-rw---- 1 root disk 259, 1 Mar 24 11:32 /dev/nvme0n2 > > NSID1 has been rejected (because of ZNS ZOC, which kernel does not support). > > However, if I use the new char device for NSID1, but specify NSID2 to nvme-cli: > > sudo nvme write-zeroes -s 0 -c 0 --namespace-id=2 /dev/nvme-generic-0c0n1 > > I was still allowed to write to NSID2: > > sudo nvme zns report-zones -d 1 /dev/nvme0n2 > SLBA: 0x0 WP: 0x1 Cap: 0x3e000 State: IMP_OPENED Type: SEQWRITE_REQ Attrs: 0x0 > > Should this really be allowed? I think this should not be allowed at all. Thanks for the testing! > > I was under the impression that Christoph's argument for implementing per > namespace char devices, was that you should be able to do access control. > Doesn't that mean that for the new char devices, we need to reject ioctls > that specify a nvme_passthru_cmd.nsid != the NSID that the char device > represents? > > > Although, this is not really something new, as we already have the same > behavior when it comes ioctls and the block devices. Perhaps we want to > add the same verification there? I think there should be verifications. > > Regardless if we want to add a verification for block devices or not, > it just seemed to me that the whole argument for introducing new char > devices was to allow access control per namespace, which doesn't seem > to have been taken into account, but perhaps I'm missing something. Any other points that you think it's not been taken account? I think it should map to previous blkdev operations, but with some verfications there. It would be great if you can share any other points supposed to be supported here :) > Kind regards, > Niklas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B34DC433DB for ; Thu, 25 Mar 2021 02:10:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D291619B1 for ; Thu, 25 Mar 2021 02:10:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D291619B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1KSNd+Cb2IHTWcw6OKW5zwcGBZuJofs6XyLIKO+K/6Q=; b=VV75hgZothJeHBZmWd3TdUmLh qOs6xpJYkllvROBU2m6xKC6s+fnGr15PqTWNq3OZT/IbemdVry3DvGiwK6S2Oy8mrPdw9XvSu5FUO QpQHHo/TC5fSR/pIdfsblFeXTPWSVLd1t2V9hpgg3hLf87Lli+LH82UI8tETTw7s2k3gRbyhUgdKB gR6+PxWd6amScMnxd9+ZfbKI88dNrJceB8Acu66VpPpMQpTbZASBs2XDc9pYCLQhYmQEgScV387d9 HSQkVg+RTmUbQq2d5ggVR1Jc2Gw0IKDaA2Qlgh3NKqBJt4aCTMdFSRV3p6Cf4ks2320qWbZhOcOj3 sFWJmqmNQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPFRl-000TqS-62; Thu, 25 Mar 2021 02:10:05 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPFRd-000Tpj-U3 for linux-nvme@lists.infradead.org; Thu, 25 Mar 2021 02:10:00 +0000 Received: by mail-pg1-x531.google.com with SMTP id m7so260034pgj.8 for ; Wed, 24 Mar 2021 19:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GnPkrUWVHgQAkE7X9Q+gS1Rm0hw8IZfxa51KQLQaH2w=; b=APFhGsnvbabBnyPJKGOX/84vrQW9EE5xS06+iv5qV4t5nvQXqDViUjmAOjrVJiQj2J Cwk+AkMAfN0PR8vAIY4ARrwsy01cSc8001Z/eiEnv4CMGx1Sle1hJjyRaI5MwvmcdUV+ jwb7leeD0C8/Dncxzlsp3Qip4Xy8WCg9HhV5axzjsXIFNNB4xxz0AYT4sI6EUrK95bKy FUnkX3OT5sJJBF0Uaz23lAJeBGJ1hD5XM+icNGNHkdOR8RHuOtovNLF3Veas4WXp2QNv HMQTB85iKg+HFOq4gS2TQCnMWMAG9ebH2mUWblX3DMNFJdLP/T/HOxkoReTfwUpKQVH8 /97w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GnPkrUWVHgQAkE7X9Q+gS1Rm0hw8IZfxa51KQLQaH2w=; b=gzgOsTho735okLkPaJ5L/QXttm2BO8GyP29vEFDJ5vAT9kU0kenzXJG8Ws4OmpjrpW jWaY1zK8tAqQwAYs1O0BaCiSGPXkUcYxc7sD5nnBmBOjD6BpjF0otg9kO2z7o5SSpVu6 fwycYf8pl3wpGkPkAtyHjoQ6lnw2guOLf1fsch0du985q12YKCoPQJI8qRN8jJ6UoM66 mZ+WKfSsqTcqZlATO5bDD+QKYKNJr6tLBv9kX7fTZ/mhRzEXd0C8A03k1by+yYQDg2rF HqNjmTIADIL85FGiXbtIBNPFyitI1yYxRrWxZgXaVccm+VD5lpYGHgCu3hXjK1/LFoGt vXPg== X-Gm-Message-State: AOAM533Yf8xThejFA2xzxpcYLc97cI4dIaMCa/A1W2D1DbSSWGR3GdO+ 2bX1US3kZikC8WxtADJT50A= X-Google-Smtp-Source: ABdhPJxU2KB058XE51CYUcSMipnPvf0Qk5VzTZS8EsUwLZjX4qc3Y6n8xujrzD2lZFufpuw3Huu37w== X-Received: by 2002:a17:902:d4cc:b029:e4:9cd9:f189 with SMTP id o12-20020a170902d4ccb02900e49cd9f189mr6587626plg.53.1616638194758; Wed, 24 Mar 2021 19:09:54 -0700 (PDT) Received: from localhost ([58.127.46.74]) by smtp.gmail.com with ESMTPSA id i8sm3706537pjl.32.2021.03.24.19.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 19:09:54 -0700 (PDT) Date: Thu, 25 Mar 2021 11:09:51 +0900 From: Minwoo Im To: Niklas Cassel Cc: "javier@javigon.com" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" , "linux-block@vger.kernel.org" , "kbusch@kernel.org" , Javier =?utf-8?B?R29uesOhbGV6?= , "hch@lst.de" Subject: Re: [PATCH V6 1/2] nvme: enable char device per namespace Message-ID: <20210325020951.GA2105@localhost> References: <20210301192452.16770-1-javier.gonz@samsung.com> <20210301192452.16770-2-javier.gonz@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_020958_076189_F2FB3C87 X-CRM114-Status: GOOD ( 35.64 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org T24gMjEtMDMtMjQgMTI6Mjk6MzIsIE5pa2xhcyBDYXNzZWwgd3JvdGU6Cj4gT24gTW9uLCBNYXIg MDEsIDIwMjEgYXQgMDg6MjQ6NTFQTSArMDEwMCwgamF2aWVyQGphdmlnb24uY29tIHdyb3RlOgo+ ID4gRnJvbTogSmF2aWVyIEdvbnrDoWxleiA8amF2aWVyLmdvbnpAc2Ftc3VuZy5jb20+Cj4gPiAK PiA+IENyZWF0ZSBhIGNoYXIgZGV2aWNlIHBlciBOVk1lIG5hbWVzcGFjZS4gVGhpcyBjaGFyIGRl dmljZSBpcyBhbHdheXMKPiA+IGluaXRpYWxpemVkLCBpbmRlcGVuZGVudGx5IG9mIHdoZXRoZXIg dGhlIGZlYXR1cmVzIGltcGxlbWVudGVkIGJ5IHRoZQo+ID4gZGV2aWNlIGFyZSBzdXBwb3J0ZWQg YnkgdGhlIGtlcm5lbC4gVXNlci1zcGFjZSBjYW4gdGhlcmVmb3JlIGFsd2F5cwo+ID4gaXNzdWUg SU9DVExzIHRvIHRoZSBOVk1lIGRyaXZlciB1c2luZyB0aGUgY2hhciBkZXZpY2UuCj4gPiAKPiA+ IFRoZSBjaGFyIGRldmljZSBpcyBwcmVzZW50ZWQgYXMgL2Rldi9udm1lLWdlbmVyaWMtWGNZblou IFRoaXMgbmFtaW5nCj4gPiBzY2hlbWUgZm9sbG93cyB0aGUgY29udmVudGlvbiBvZiB0aGUgaGlk ZGVuIGRldmljZSAobnZtZVhjWW5aKS4gU3VwcG9ydAo+ID4gZm9yIG11bHRpcGF0aCB3aWxsIGZv bGxvdy4KPiA+IAo+IAo+IEhlbGxvIGFsbCwKPiAKPiBMb29raW5nIGF0IHRoZSBkaXNjdXNzaW9u IHRoYXQgbGVkIHVwIHRvIHRoZSBjdXJyZW50IGRlc2lnbjoKPiBodHRwczovL2xvcmUua2VybmVs Lm9yZy9saW51eC1ibG9jay8yMDIwMTEwMjE4NTg1MS5HQTIxMzQ5QGxzdC5kZS8KPiAKPiBLZWl0 aCBpbml0aWFsbHkgc3VnZ2VzdGVkOgo+IAo+IGEpIFNldCB1cCB0aGUgZXhpc3RpbmcgY29udHJv bGxlciBjaGFyYWN0ZXIgZGV2aWNlIHdpdGggYSBnZW5lcmljCj4gICAgZGlzay1sZXNzIHJlcXVl c3RfcXVldWUgdG8gdGhlIElPIHF1ZXVlcyBhY2NlcHRpbmcgSU8gY29tbWFuZHMgdG8KPiAgICBh cmJpdHJhcnkgTlNJRHMuCj4gCj4gSG93ZXZlciBDaHJpc3RvcGggcmVwbGllZDoKPiAKPiBUaGUg cHJvYmxlbSB3aXRoIGEpIGlzIHRoYXQgaXQgY2FuJ3QgYmUgdXNlZCB0byBnaXZlIHVzZXJzIG9y IGdyb3Vwcwo+IGFjY2VzcyB0byBqdXN0IG9uZSBuYW1lc3BhY2VzLCBzbyBpdCBjYXVzZXMgYSBy ZWFsIGFjY2VzcyBjb250cm9sCj4gbmlnaHRtYXJlLgo+IAo+IGMpIEVhY2ggbmFtZXNwYWNlIGdl dHMgaXRzIG93biBjaGFyYWN0ZXIgZGV2aWNlLCBwZXJpb2QuCgpUaGFua3MgZm9yIHN1bW1hcml6 aW5nIHRoaXMgdXAhCgo+IEhvd2V2ZXIsIHRlc3RpbmcgdGhpcyBwYXRjaCBzZXJpZXMgb3V0Ogo+ IAo+IGNydy0tLS0tLS0gMSByb290IHJvb3QgMjQ5LCAgIDAgTWFyIDI0IDExOjMyIC9kZXYvbnZt ZS1nZW5lcmljLTBjMG4xCj4gY3J3LS0tLS0tLSAxIHJvb3Qgcm9vdCAyNDksICAgMSBNYXIgMjQg MTE6MzIgL2Rldi9udm1lLWdlbmVyaWMtMGMwbjIKPiBjcnctLS0tLS0tIDEgcm9vdCByb290IDI1 MCwgICAwIE1hciAyNCAxMTozMiAvZGV2L252bWUwCj4gYnJ3LXJ3LS0tLSAxIHJvb3QgZGlzayAy NTksICAgMSBNYXIgMjQgMTE6MzIgL2Rldi9udm1lMG4yCj4gCj4gTlNJRDEgaGFzIGJlZW4gcmVq ZWN0ZWQgKGJlY2F1c2Ugb2YgWk5TIFpPQywgd2hpY2gga2VybmVsIGRvZXMgbm90IHN1cHBvcnQp Lgo+IAo+IEhvd2V2ZXIsIGlmIEkgdXNlIHRoZSBuZXcgY2hhciBkZXZpY2UgZm9yIE5TSUQxLCBi dXQgc3BlY2lmeSBOU0lEMiB0byBudm1lLWNsaToKPiAKPiBzdWRvIG52bWUgd3JpdGUtemVyb2Vz IC1zIDAgLWMgMCAtLW5hbWVzcGFjZS1pZD0yIC9kZXYvbnZtZS1nZW5lcmljLTBjMG4xCj4gCj4g SSB3YXMgc3RpbGwgYWxsb3dlZCB0byB3cml0ZSB0byBOU0lEMjoKPiAKPiBzdWRvIG52bWUgem5z IHJlcG9ydC16b25lcyAtZCAxIC9kZXYvbnZtZTBuMgo+IFNMQkE6IDB4MCAgICAgICAgV1A6IDB4 MSAgICAgICAgQ2FwOiAweDNlMDAwICAgIFN0YXRlOiBJTVBfT1BFTkVEICAgVHlwZTogU0VRV1JJ VEVfUkVRICAgQXR0cnM6IDB4MAo+IAo+IFNob3VsZCB0aGlzIHJlYWxseSBiZSBhbGxvd2VkPwoK SSB0aGluayB0aGlzIHNob3VsZCBub3QgYmUgYWxsb3dlZCBhdCBhbGwuICBUaGFua3MgZm9yIHRo ZSB0ZXN0aW5nIQoKPiAKPiBJIHdhcyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IENocmlzdG9w aCdzIGFyZ3VtZW50IGZvciBpbXBsZW1lbnRpbmcgcGVyCj4gbmFtZXNwYWNlIGNoYXIgZGV2aWNl cywgd2FzIHRoYXQgeW91IHNob3VsZCBiZSBhYmxlIHRvIGRvIGFjY2VzcyBjb250cm9sLgo+IERv ZXNuJ3QgdGhhdCBtZWFuIHRoYXQgZm9yIHRoZSBuZXcgY2hhciBkZXZpY2VzLCB3ZSBuZWVkIHRv IHJlamVjdCBpb2N0bHMKPiB0aGF0IHNwZWNpZnkgYSBudm1lX3Bhc3N0aHJ1X2NtZC5uc2lkICE9 IHRoZSBOU0lEIHRoYXQgdGhlIGNoYXIgZGV2aWNlCj4gcmVwcmVzZW50cz8KPiAKPiAKPiBBbHRo b3VnaCwgdGhpcyBpcyBub3QgcmVhbGx5IHNvbWV0aGluZyBuZXcsIGFzIHdlIGFscmVhZHkgaGF2 ZSB0aGUgc2FtZQo+IGJlaGF2aW9yIHdoZW4gaXQgY29tZXMgaW9jdGxzIGFuZCB0aGUgYmxvY2sg ZGV2aWNlcy4gUGVyaGFwcyB3ZSB3YW50IHRvCj4gYWRkIHRoZSBzYW1lIHZlcmlmaWNhdGlvbiB0 aGVyZT8KCkkgdGhpbmsgdGhlcmUgc2hvdWxkIGJlIHZlcmlmaWNhdGlvbnMuCgo+IAo+IFJlZ2Fy ZGxlc3MgaWYgd2Ugd2FudCB0byBhZGQgYSB2ZXJpZmljYXRpb24gZm9yIGJsb2NrIGRldmljZXMg b3Igbm90LAo+IGl0IGp1c3Qgc2VlbWVkIHRvIG1lIHRoYXQgdGhlIHdob2xlIGFyZ3VtZW50IGZv ciBpbnRyb2R1Y2luZyBuZXcgY2hhcgo+IGRldmljZXMgd2FzIHRvIGFsbG93IGFjY2VzcyBjb250 cm9sIHBlciBuYW1lc3BhY2UsIHdoaWNoIGRvZXNuJ3Qgc2VlbQo+IHRvIGhhdmUgYmVlbiB0YWtl biBpbnRvIGFjY291bnQsIGJ1dCBwZXJoYXBzIEknbSBtaXNzaW5nIHNvbWV0aGluZy4KCkFueSBv dGhlciBwb2ludHMgdGhhdCB5b3UgdGhpbmsgaXQncyBub3QgYmVlbiB0YWtlbiBhY2NvdW50PyAg SSB0aGluayBpdApzaG91bGQgbWFwIHRvIHByZXZpb3VzIGJsa2RldiBvcGVyYXRpb25zLCBidXQg d2l0aCBzb21lIHZlcmZpY2F0aW9ucwp0aGVyZS4gIEl0IHdvdWxkIGJlIGdyZWF0IGlmIHlvdSBj YW4gc2hhcmUgYW55IG90aGVyIHBvaW50cyBzdXBwb3NlZCB0bwpiZSBzdXBwb3J0ZWQgaGVyZSA6 KQoKPiBLaW5kIHJlZ2FyZHMsCj4gTmlrbGFzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eC1udm1lIG1haWxpbmcgbGlzdApMaW51eC1udm1lQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1udm1lCg==