From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D789C433DB for ; Fri, 26 Mar 2021 06:05:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC7B461554 for ; Fri, 26 Mar 2021 06:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbhCZGFI (ORCPT ); Fri, 26 Mar 2021 02:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbhCZGE7 (ORCPT ); Fri, 26 Mar 2021 02:04:59 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CABC0613AA for ; Thu, 25 Mar 2021 23:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=blUPq0teoga+gleb2/Og7dc0uamwV2l5HCHxhpsqFgk=; b=P4ldYwXvaHp+jeuq8jW8dkDYt1 ZossG+9shtjDv3vsE/ZeCqzRiFvTsjRChiSYfkOMwRKgVO8I2J1X6F4IhhhIULILTDN9hdbkkAtX9 zk41ahHrLtsTWq0Tz2mtn8UMRKML4DlTTCb9fbiO1RLC8R1SgRDAUTFByylI1ONR6hpzq55btXMx0 5edKBgO+yXyHhpBZRj3C3VFaoggso4k5ZEiI/X8S47oOb8tF1RSXINtpC5LIUsGPTFRcn9SYthV3h FxYknLlnvVhR1KESGtcE4gQynZPxkrrm3dHP+mAqOAYU+6mRz0FzUOIArV8WwdyYlGiyDLG72ZBX1 l9x9lchg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lPfa5-00EMiO-Ab; Fri, 26 Mar 2021 06:04:52 +0000 Date: Fri, 26 Mar 2021 06:04:25 +0000 From: Christoph Hellwig To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 2/6] xfs: remove iter_flags parameter from xfs_inode_walk_* Message-ID: <20210326060425.GC3421955@infradead.org> References: <161671807287.621936.13471099564526590235.stgit@magnolia> <161671808412.621936.9290234722714661435.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161671808412.621936.9290234722714661435.stgit@magnolia> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Mar 25, 2021 at 05:21:24PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > The sole iter_flags is XFS_INODE_WALK_INEW_WAIT, and there are no users. > Remove the flag, and the parameter, and all the code that used it. > Since there are no longer any external callers of xfs_inode_walk, make > it static. > > Signed-off-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig