From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D1FC433E8 for ; Fri, 26 Mar 2021 06:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66D9761A55 for ; Fri, 26 Mar 2021 06:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230141AbhCZGN5 (ORCPT ); Fri, 26 Mar 2021 02:13:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbhCZGNl (ORCPT ); Fri, 26 Mar 2021 02:13:41 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE68CC0613B1; Thu, 25 Mar 2021 23:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=vZFXjwDFBlt15FbbxH8vQOkVklkvteOsEp/Orr07Xyg=; b=2+gf1yHr8gEbFj+N4OJDIkdOzH 1hQ95DPpzv3ZV+HEoKdNqXg1LoZ/CZVyfn4kmwrMnyoF92NltPaIDzQemqvl47ydc38iAx5Xc9duE SvWdyKp6ZrZRqD35Q0w0eC5i6W5jQZqmhSJlzxgBRvt1Rcmu1cPsyAvstO6ROjCwoO8am6QiSFLfu Cvgk+lZwd2qb8ecjiKy88HEl0TgZ2L3ZsqAH1s0jTYknSqwuCsSXU98JpAKH/rJyVYShCPQ0tPBaj 0fr1QXjR0kY18M1p/JiD2YRtpSybZ04Y/KL2rwTFNYKARMEJBrr0cpVgB+98QT2re7IbJ76v2XQEt ZGzOfSzQ==; Received: from [2001:4bb8:191:f692:97ff:1e47:aee2:c7e5] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lPfib-005AmU-19; Fri, 26 Mar 2021 06:13:13 +0000 From: Christoph Hellwig To: Michael Ellerman , Alex Williamson Cc: Benjamin Herrenschmidt , Greg Kroah-Hartman , Jason Gunthorpe , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-api@vger.kernel.org Subject: remove the nvlink2 pci_vfio subdriver v2 Date: Fri, 26 Mar 2021 07:13:09 +0100 Message-Id: <20210326061311.1497642-1-hch@lst.de> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, the nvlink2 vfio subdriver is a weird beast. It supports a hardware feature without any open source component - what would normally be the normal open source userspace that we require for kernel drivers, although in this particular case user space could of course be a kernel driver in a VM. It also happens to be a complete mess that does not properly bind to PCI IDs, is hacked into the vfio_pci driver and also pulles in over 1000 lines of code always build into powerpc kernels that have Power NV support enabled. Because of all these issues and the lack of breaking userspace when it is removed I think the best idea is to simply kill. Changes since v1: - document the removed subtypes as reserved - add the ACK from Greg Diffstat: arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- b/arch/powerpc/include/asm/opal.h | 3 b/arch/powerpc/include/asm/pci-bridge.h | 1 b/arch/powerpc/include/asm/pci.h | 7 b/arch/powerpc/platforms/powernv/Makefile | 2 b/arch/powerpc/platforms/powernv/opal-call.c | 2 b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- b/arch/powerpc/platforms/powernv/pci.c | 11 b/arch/powerpc/platforms/powernv/pci.h | 17 b/arch/powerpc/platforms/pseries/pci.c | 23 b/drivers/vfio/pci/Kconfig | 6 b/drivers/vfio/pci/Makefile | 1 b/drivers/vfio/pci/vfio_pci.c | 18 b/drivers/vfio/pci/vfio_pci_private.h | 14 b/include/uapi/linux/vfio.h | 38 - drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ 16 files changed, 12 insertions(+), 1511 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8318AC433C1 for ; Fri, 26 Mar 2021 06:14:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 030E961A0F for ; Fri, 26 Mar 2021 06:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 030E961A0F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F6BWD2ctBz3c3L for ; Fri, 26 Mar 2021 17:14:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=2+gf1yHr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=batv+31783f3a8021f30233dc+6424+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=2+gf1yHr; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F6BVk083rz30hc for ; Fri, 26 Mar 2021 17:13:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=vZFXjwDFBlt15FbbxH8vQOkVklkvteOsEp/Orr07Xyg=; b=2+gf1yHr8gEbFj+N4OJDIkdOzH 1hQ95DPpzv3ZV+HEoKdNqXg1LoZ/CZVyfn4kmwrMnyoF92NltPaIDzQemqvl47ydc38iAx5Xc9duE SvWdyKp6ZrZRqD35Q0w0eC5i6W5jQZqmhSJlzxgBRvt1Rcmu1cPsyAvstO6ROjCwoO8am6QiSFLfu Cvgk+lZwd2qb8ecjiKy88HEl0TgZ2L3ZsqAH1s0jTYknSqwuCsSXU98JpAKH/rJyVYShCPQ0tPBaj 0fr1QXjR0kY18M1p/JiD2YRtpSybZ04Y/KL2rwTFNYKARMEJBrr0cpVgB+98QT2re7IbJ76v2XQEt ZGzOfSzQ==; Received: from [2001:4bb8:191:f692:97ff:1e47:aee2:c7e5] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lPfib-005AmU-19; Fri, 26 Mar 2021 06:13:13 +0000 From: Christoph Hellwig To: Michael Ellerman , Alex Williamson Subject: remove the nvlink2 pci_vfio subdriver v2 Date: Fri, 26 Mar 2021 07:13:09 +0100 Message-Id: <20210326061311.1497642-1-hch@lst.de> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Gunthorpe , kvm@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Mackerras , Daniel Vetter , Greg Kroah-Hartman , linux-api@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi all, the nvlink2 vfio subdriver is a weird beast. It supports a hardware feature without any open source component - what would normally be the normal open source userspace that we require for kernel drivers, although in this particular case user space could of course be a kernel driver in a VM. It also happens to be a complete mess that does not properly bind to PCI IDs, is hacked into the vfio_pci driver and also pulles in over 1000 lines of code always build into powerpc kernels that have Power NV support enabled. Because of all these issues and the lack of breaking userspace when it is removed I think the best idea is to simply kill. Changes since v1: - document the removed subtypes as reserved - add the ACK from Greg Diffstat: arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- b/arch/powerpc/include/asm/opal.h | 3 b/arch/powerpc/include/asm/pci-bridge.h | 1 b/arch/powerpc/include/asm/pci.h | 7 b/arch/powerpc/platforms/powernv/Makefile | 2 b/arch/powerpc/platforms/powernv/opal-call.c | 2 b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- b/arch/powerpc/platforms/powernv/pci.c | 11 b/arch/powerpc/platforms/powernv/pci.h | 17 b/arch/powerpc/platforms/pseries/pci.c | 23 b/drivers/vfio/pci/Kconfig | 6 b/drivers/vfio/pci/Makefile | 1 b/drivers/vfio/pci/vfio_pci.c | 18 b/drivers/vfio/pci/vfio_pci_private.h | 14 b/include/uapi/linux/vfio.h | 38 - drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------ 16 files changed, 12 insertions(+), 1511 deletions(-)