All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC
@ 2021-03-26 14:24 ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2021-03-26 14:24 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer
  Cc: Rob Herring, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-arm-kernel

There is no binding and driver for the PMIC itself, but making the bus
available allows to access its registers using i2c-tools at least.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 7db4273cc88b..69e5c965930c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -102,6 +102,15 @@ ethphy1: ethernet-phy@1 {
 	};
 };
 
+&i2c1 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	/* PMIC PCA9450C at address 0x25, irq to GPIO1_IO03. */
+};
+
 &i2c3 {
 	clock-frequency = <400000>;
 	pinctrl-names = "default";
@@ -227,6 +236,13 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16	0x19
 		>;
 	};
 
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL		0x400001c3
+			MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA		0x400001c3
+		>;
+	};
+
 	pinctrl_i2c3: i2c3grp {
 		fsl,pins = <
 			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL		0x400001c3
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC
@ 2021-03-26 14:24 ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2021-03-26 14:24 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer
  Cc: Rob Herring, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-arm-kernel

There is no binding and driver for the PMIC itself, but making the bus
available allows to access its registers using i2c-tools at least.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 7db4273cc88b..69e5c965930c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -102,6 +102,15 @@ ethphy1: ethernet-phy@1 {
 	};
 };
 
+&i2c1 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	/* PMIC PCA9450C at address 0x25, irq to GPIO1_IO03. */
+};
+
 &i2c3 {
 	clock-frequency = <400000>;
 	pinctrl-names = "default";
@@ -227,6 +236,13 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16	0x19
 		>;
 	};
 
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL		0x400001c3
+			MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA		0x400001c3
+		>;
+	};
+
 	pinctrl_i2c3: i2c3grp {
 		fsl,pins = <
 			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL		0x400001c3
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC
  2021-03-26 14:24 ` Uwe Kleine-König
@ 2021-03-26 18:26   ` Fabio Estevam
  -1 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2021-03-26 18:26 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Pengutronix Kernel Team,
	NXP Linux Team,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Uwe,

On Fri, Mar 26, 2021 at 11:25 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> There is no binding and driver for the PMIC itself, but making the bus

What about the commit below that landed in kernel 5.9?

commit 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc
Author: Robin Gong <yibin.gong@nxp.com>
Date:   Sat Jul 4 00:19:35 2020 +0800

    regulator: pca9450: add pca9450 pmic driver

    Add NXP pca9450 pmic driver.

    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
    Link: https://lore.kernel.org/r/1593793178-9737-2-git-send-email-yibin.gong@nxp.com
    Signed-off-by: Mark Brown <broonie@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC
@ 2021-03-26 18:26   ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2021-03-26 18:26 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Shawn Guo, Sascha Hauer, Rob Herring, Pengutronix Kernel Team,
	NXP Linux Team,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Uwe,

On Fri, Mar 26, 2021 at 11:25 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> There is no binding and driver for the PMIC itself, but making the bus

What about the commit below that landed in kernel 5.9?

commit 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc
Author: Robin Gong <yibin.gong@nxp.com>
Date:   Sat Jul 4 00:19:35 2020 +0800

    regulator: pca9450: add pca9450 pmic driver

    Add NXP pca9450 pmic driver.

    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
    Link: https://lore.kernel.org/r/1593793178-9737-2-git-send-email-yibin.gong@nxp.com
    Signed-off-by: Mark Brown <broonie@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC
  2021-03-26 18:26   ` Fabio Estevam
@ 2021-03-27 20:45     ` Uwe Kleine-König
  -1 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2021-03-27 20:45 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Sascha Hauer, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]

Hello Fabio,

On Fri, Mar 26, 2021 at 03:26:25PM -0300, Fabio Estevam wrote:
> On Fri, Mar 26, 2021 at 11:25 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > There is no binding and driver for the PMIC itself, but making the bus
> 
> What about the commit below that landed in kernel 5.9?
> 
> commit 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc
> Author: Robin Gong <yibin.gong@nxp.com>
> Date:   Sat Jul 4 00:19:35 2020 +0800
> 
>     regulator: pca9450: add pca9450 pmic driver
> 
>     Add NXP pca9450 pmic driver.
> 
>     Signed-off-by: Robin Gong <yibin.gong@nxp.com>
>     Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>     Link: https://lore.kernel.org/r/1593793178-9737-2-git-send-email-yibin.gong@nxp.com
>     Signed-off-by: Mark Brown <broonie@kernel.org>

Hmm, now that you wrote that my git grep also finds it. How did you do
that? :-)

I will respin the patch and also add the pmic as an i2c device.

Thanks and best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC
@ 2021-03-27 20:45     ` Uwe Kleine-König
  0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2021-03-27 20:45 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Sascha Hauer, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE


[-- Attachment #1.1: Type: text/plain, Size: 1166 bytes --]

Hello Fabio,

On Fri, Mar 26, 2021 at 03:26:25PM -0300, Fabio Estevam wrote:
> On Fri, Mar 26, 2021 at 11:25 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > There is no binding and driver for the PMIC itself, but making the bus
> 
> What about the commit below that landed in kernel 5.9?
> 
> commit 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc
> Author: Robin Gong <yibin.gong@nxp.com>
> Date:   Sat Jul 4 00:19:35 2020 +0800
> 
>     regulator: pca9450: add pca9450 pmic driver
> 
>     Add NXP pca9450 pmic driver.
> 
>     Signed-off-by: Robin Gong <yibin.gong@nxp.com>
>     Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>     Link: https://lore.kernel.org/r/1593793178-9737-2-git-send-email-yibin.gong@nxp.com
>     Signed-off-by: Mark Brown <broonie@kernel.org>

Hmm, now that you wrote that my git grep also finds it. How did you do
that? :-)

I will respin the patch and also add the pmic as an i2c device.

Thanks and best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-27 20:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 14:24 [PATCH] arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC Uwe Kleine-König
2021-03-26 14:24 ` Uwe Kleine-König
2021-03-26 18:26 ` Fabio Estevam
2021-03-26 18:26   ` Fabio Estevam
2021-03-27 20:45   ` Uwe Kleine-König
2021-03-27 20:45     ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.