From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 129B0C433F2 for ; Fri, 26 Mar 2021 15:53:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF45B61A4C for ; Fri, 26 Mar 2021 15:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231249AbhCZPwz (ORCPT ); Fri, 26 Mar 2021 11:52:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbhCZPwL (ORCPT ); Fri, 26 Mar 2021 11:52:11 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3417BC0613B2 for ; Fri, 26 Mar 2021 08:52:11 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id e8so5857109iok.5 for ; Fri, 26 Mar 2021 08:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=li3YfRJpVv71xu0WVsVssRzCMBArHCH1EvW6QYE1yT0=; b=w3MnhLfaad+pxtWTS9BUynvM43dek2hPrehG0A67EVR1rdqR337c8VGQbQJXe+d7d4 NKfb/nmFXDTyDG8qJ9zxBmNRj5Oy6ljtpG4vGJJnOz+tfCvq2C8wfSu4f1cf03k/2O8p smzW5qzuHl+suOCwHaNZxQzeTcAKCdCm4Hawb3gFePk6xAbsaUBZlbItZTw4KPJggPAI VEV6/N/Ma48ONPcmInLpENF6lruYjrBfFA7DKvVK6h8k48Wxsw7+RpwjCZa7/HFnOW/f x/2tD0wjalBfmYQKFSH1dS7eo6goFwrBZw0vw25/J24lTdbB+KkeEufgRuLDwZ1lJ9jD Nk5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=li3YfRJpVv71xu0WVsVssRzCMBArHCH1EvW6QYE1yT0=; b=ssyQjocl7JTbtNyfSHssmIRCXysojeuZrM/dI/ZyymHJxV+NjrHxChiL1jruE8ZR2g 4Du9LZf87S/ZBXL4N8sBWc3KHey+8XgjdnV77c/yFOb7uTxS8NjbQ9Na8NHYCUR+6+1l NrGmrDOMs1ZBXuC32gLK3qeLQrKX3sgbtuWpaT+2b1JmfbuW8SPw/0Dw+bpEiASfcCca 50I9qJ7WCTxQv2Q5USesBpJtfsxIEBemrAFsujXZyVvh60U5Uvyds0uzhU+vJUyXA1HL /LOGWVdVDi5+wNUBQ6du4Ahkv2ylbnC2LIYrgRAG9Mrlz6+k2yCH+933+s0SwBGjb3W2 NkpA== X-Gm-Message-State: AOAM531EXw8FqbHCwT2gM7Q3T8QDdJd7lamC7HXhfPDynCh9aBRgVYw6 xXRyqj0KvlSLF52hW+HHtQqKKQ== X-Google-Smtp-Source: ABdhPJwYVZi/SxQzTjGnoLoBUHwr0ZF6Iczqbe2lmM+C1+pIQlhCD4tQSkhWRReXMCe2Gqf9nxlm1A== X-Received: by 2002:a05:6638:2711:: with SMTP id m17mr12635791jav.115.1616773930510; Fri, 26 Mar 2021 08:52:10 -0700 (PDT) Received: from p1.localdomain ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id a7sm4456337ilj.64.2021.03.26.08.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 08:52:10 -0700 (PDT) From: Jens Axboe To: io-uring@vger.kernel.org Cc: torvalds@linux-foundation.org, ebiederm@xmission.com, metze@samba.org, oleg@redhat.com, linux-kernel@vger.kernel.org, Jens Axboe Subject: [PATCH 6/7] Revert "kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing" Date: Fri, 26 Mar 2021 09:51:22 -0600 Message-Id: <20210326155128.1057078-10-axboe@kernel.dk> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210326155128.1057078-1-axboe@kernel.dk> References: <20210326155128.1057078-1-axboe@kernel.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 15b2219facadec583c24523eed40fa45865f859f. Before IO threads accepted signals, the freezer using take signals to wake up an IO thread would cause them to loop without any way to clear the pending signal. That is no longer the case, so stop special casing PF_IO_WORKER in the freezer. Signed-off-by: Jens Axboe --- kernel/freezer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/freezer.c b/kernel/freezer.c index 1a2d57d1327c..dc520f01f99d 100644 --- a/kernel/freezer.c +++ b/kernel/freezer.c @@ -134,7 +134,7 @@ bool freeze_task(struct task_struct *p) return false; } - if (!(p->flags & (PF_KTHREAD | PF_IO_WORKER))) + if (!(p->flags & PF_KTHREAD)) fake_signal_wake_up(p); else wake_up_state(p, TASK_INTERRUPTIBLE); -- 2.31.0