From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939EFC433E1 for ; Fri, 26 Mar 2021 16:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59ECD619B4 for ; Fri, 26 Mar 2021 16:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbhCZQUW (ORCPT ); Fri, 26 Mar 2021 12:20:22 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:45176 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbhCZQUO (ORCPT ); Fri, 26 Mar 2021 12:20:14 -0400 Date: Fri, 26 Mar 2021 16:20:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1616775613; bh=CcH0rrv6ICKSLNLF1sxiChOceJEI2Qlg0grV7Totep8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=c30bEGTy62ExKen3AwiddvrcXMRkPby5SCVlQBmzNqKMCUKyX2XHVrobyX3fdRzpk 8XrzAlXWPqyinIgRvmJyRi0NzWml17hMFA7SAXV/rmB532ZoUVLTt5L50m3imh/WnX Cs4uV6zPDC+r9uXUKjVtTmvROyM/EKJskPyPcq40= To: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Rob Herring , Sebastian Reichel From: Timon Baetz Cc: Timon Baetz , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Reply-To: Timon Baetz Subject: Re: [PATCH 3/3] power: supply: max8997_charger: Switch to new binding Message-ID: <20210326171956.7d1d9624@focal-fossa> In-Reply-To: <20210130172747.2022977-4-timon.baetz@protonmail.com> References: <20210130172747.2022977-1-timon.baetz@protonmail.com> <20210130172747.2022977-4-timon.baetz@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Jan 2021 17:30:14 +0000, Timon Baetz wrote: > Get regulator from parent device's node and extcon by name. > > Signed-off-by: Timon Baetz > --- > drivers/power/supply/max8997_charger.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/suppl= y/max8997_charger.c > index 321bd6b8ee41..625d8cc4312a 100644 > --- a/drivers/power/supply/max8997_charger.c > +++ b/drivers/power/supply/max8997_charger.c > @@ -168,6 +168,7 @@ static int max8997_battery_probe(struct platform_devi= ce *pdev) > =09int ret =3D 0; > =09struct charger_data *charger; > =09struct max8997_dev *iodev =3D dev_get_drvdata(pdev->dev.parent); > +=09struct device_node *np =3D pdev->dev.of_node; > =09struct i2c_client *i2c =3D iodev->i2c; > =09struct max8997_platform_data *pdata =3D iodev->pdata; > =09struct power_supply_config psy_cfg =3D {}; > @@ -237,20 +238,23 @@ static int max8997_battery_probe(struct platform_de= vice *pdev) > =09=09return PTR_ERR(charger->battery); > =09} > > +=09// grab regulator from parent device's node > +=09pdev->dev.of_node =3D iodev->dev->of_node; > =09charger->reg =3D devm_regulator_get_optional(&pdev->dev, "charger"); > +=09pdev->dev.of_node =3D np; > =09if (IS_ERR(charger->reg)) { > =09=09if (PTR_ERR(charger->reg) =3D=3D -EPROBE_DEFER) > =09=09=09return -EPROBE_DEFER; > =09=09dev_info(&pdev->dev, "couldn't get charger regulator\n"); > =09} > -=09charger->edev =3D extcon_get_edev_by_phandle(&pdev->dev, 0); > -=09if (IS_ERR(charger->edev)) { > -=09=09if (PTR_ERR(charger->edev) =3D=3D -EPROBE_DEFER) > +=09charger->edev =3D extcon_get_extcon_dev("max8997-muic"); > +=09if (IS_ERR_OR_NULL(charger->edev)) { > +=09=09if (!charger->edev) > =09=09=09return -EPROBE_DEFER; > =09=09dev_info(charger->dev, "couldn't get extcon device\n"); > =09} > > -=09if (!IS_ERR(charger->reg) && !IS_ERR(charger->edev)) { > +=09if (!IS_ERR(charger->reg) && !IS_ERR_OR_NULL(charger->edev)) { > =09=09INIT_WORK(&charger->extcon_work, max8997_battery_extcon_evt_worker= ); > =09=09ret =3D devm_add_action(&pdev->dev, max8997_battery_extcon_evt_sto= p_work, charger); > =09=09if (ret) { Hello, I am not sure if I am missing something here. The other 2 patches of the series already made it into linux-next but this is still pending. Do I have to resubmit? The patch still applies without conflicts. Any help would be appreciated. Thanks, Timon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216DDC433DB for ; Fri, 26 Mar 2021 16:21:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0232619CB for ; Fri, 26 Mar 2021 16:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0232619CB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:From:To:Date:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VR8chElNn3CBe3448P27aBvEWn050JgybdIY8erwNvI=; b=HJ2VDHxDCmbWLi+fid11bkvkt gxh2KG7S/kp2E9piflDfpaPdtzLj/htZO55NBC6vEWX0VBZIy8NBRH43DZms0zWmYLWyVruZQ6gSz EC/n937kvB7NHCNv2KIemCpRLX+NuCt/4vcpzAewuhscM7M9mO4XX0/D6Cy0D+Y0Fg/f+DBn7IGwh Z/hvOuEpRJrlciv1zUn2Ehn2tbLRt45BCTYVerTVMetfIfLxwtR51SF9d5VQN8EDOStOQxTqvJfVx IgSM2wAJp/QG7VYl/FHp1uoRR2zPDeC+/PA5/oO9jTxw6s8u92rs1+52uUBzKyFHdCnzty09BcBRP zgb6QuVHA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPpC8-003ycy-7M; Fri, 26 Mar 2021 16:20:20 +0000 Received: from mail-40131.protonmail.ch ([185.70.40.131]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPpC3-003ycG-V5 for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 16:20:17 +0000 Date: Fri, 26 Mar 2021 16:20:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1616775613; bh=CcH0rrv6ICKSLNLF1sxiChOceJEI2Qlg0grV7Totep8=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=c30bEGTy62ExKen3AwiddvrcXMRkPby5SCVlQBmzNqKMCUKyX2XHVrobyX3fdRzpk 8XrzAlXWPqyinIgRvmJyRi0NzWml17hMFA7SAXV/rmB532ZoUVLTt5L50m3imh/WnX Cs4uV6zPDC+r9uXUKjVtTmvROyM/EKJskPyPcq40= To: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Rob Herring , Sebastian Reichel From: Timon Baetz Cc: Timon Baetz , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/3] power: supply: max8997_charger: Switch to new binding Message-ID: <20210326171956.7d1d9624@focal-fossa> In-Reply-To: <20210130172747.2022977-4-timon.baetz@protonmail.com> References: <20210130172747.2022977-1-timon.baetz@protonmail.com> <20210130172747.2022977-4-timon.baetz@protonmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_162016_110756_7C573EA1 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Timon Baetz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 30 Jan 2021 17:30:14 +0000, Timon Baetz wrote: > Get regulator from parent device's node and extcon by name. > > Signed-off-by: Timon Baetz > --- > drivers/power/supply/max8997_charger.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/supply/max8997_charger.c > index 321bd6b8ee41..625d8cc4312a 100644 > --- a/drivers/power/supply/max8997_charger.c > +++ b/drivers/power/supply/max8997_charger.c > @@ -168,6 +168,7 @@ static int max8997_battery_probe(struct platform_device *pdev) > int ret = 0; > struct charger_data *charger; > struct max8997_dev *iodev = dev_get_drvdata(pdev->dev.parent); > + struct device_node *np = pdev->dev.of_node; > struct i2c_client *i2c = iodev->i2c; > struct max8997_platform_data *pdata = iodev->pdata; > struct power_supply_config psy_cfg = {}; > @@ -237,20 +238,23 @@ static int max8997_battery_probe(struct platform_device *pdev) > return PTR_ERR(charger->battery); > } > > + // grab regulator from parent device's node > + pdev->dev.of_node = iodev->dev->of_node; > charger->reg = devm_regulator_get_optional(&pdev->dev, "charger"); > + pdev->dev.of_node = np; > if (IS_ERR(charger->reg)) { > if (PTR_ERR(charger->reg) == -EPROBE_DEFER) > return -EPROBE_DEFER; > dev_info(&pdev->dev, "couldn't get charger regulator\n"); > } > - charger->edev = extcon_get_edev_by_phandle(&pdev->dev, 0); > - if (IS_ERR(charger->edev)) { > - if (PTR_ERR(charger->edev) == -EPROBE_DEFER) > + charger->edev = extcon_get_extcon_dev("max8997-muic"); > + if (IS_ERR_OR_NULL(charger->edev)) { > + if (!charger->edev) > return -EPROBE_DEFER; > dev_info(charger->dev, "couldn't get extcon device\n"); > } > > - if (!IS_ERR(charger->reg) && !IS_ERR(charger->edev)) { > + if (!IS_ERR(charger->reg) && !IS_ERR_OR_NULL(charger->edev)) { > INIT_WORK(&charger->extcon_work, max8997_battery_extcon_evt_worker); > ret = devm_add_action(&pdev->dev, max8997_battery_extcon_evt_stop_work, charger); > if (ret) { Hello, I am not sure if I am missing something here. The other 2 patches of the series already made it into linux-next but this is still pending. Do I have to resubmit? The patch still applies without conflicts. Any help would be appreciated. Thanks, Timon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel