From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0EBC433E0 for ; Fri, 26 Mar 2021 20:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B1B461A36 for ; Fri, 26 Mar 2021 20:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbhCZUSJ (ORCPT ); Fri, 26 Mar 2021 16:18:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:37166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbhCZURw (ORCPT ); Fri, 26 Mar 2021 16:17:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2450561A18; Fri, 26 Mar 2021 20:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616789872; bh=HQiYbloBWeueZbq2L4oIhpCdSmR81v4HPpPi6S55n34=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ANchPUbA7/niZ+2pM4ATJhblFIlE8ITlpAvMJLR+NSAxfJASezVQ9ueEhWhaJElvb 5Fjusoq4cJ0G/sOxwXl0fz5HbIhwNBasdrdYjbUx3UmyCIR9b3qNbDa58OMuixoW2X tAqhmk5N+YeYehwzOTjnh11PdSoJieSF11ZManBgDB4SgRa29rCFAORH3ljc5PkIbB ZKTGa6IrzdubbAH9NINQB1/6Ykjvb9+oSblL3CEV1aTv9MoLtZ90DjyEpoe9aJtQp1 GrFCofGtIWioYjjG8FMi4rBUtVqEWTLQVYfcrq2YwQgiawMoXxMqoMzs6DEKEsmYUh V+3mns8AoL8vQ== Date: Fri, 26 Mar 2021 15:17:50 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v3 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up Message-ID: <20210326201750.GA905944@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326191906.43567-4-jim2101024@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 03:19:01PM -0400, Jim Quinlan wrote: > If any downstream device may wake up during S2/S3 suspend, we do not want > to turn off its power when suspending. > > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 58 +++++++++++++++++++++++---- > 1 file changed, 51 insertions(+), 7 deletions(-) > +enum { > + TURN_OFF, /* Turn egulators off, unless an EP is wakeup-capable */ > + TURN_OFF_ALWAYS, /* Turn Regulators off, no exceptions */ > + TURN_ON, /* Turn regulators on, unless pcie->ep_wakeup_capable */ s/egulators/regulators/ s/Regulators/regulators/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171EFC433DB for ; Fri, 26 Mar 2021 20:19:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B21FA61A02 for ; Fri, 26 Mar 2021 20:19:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B21FA61A02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=fAO48G9O9HC1Ldm27uGCvMw7QALss3lddd3IDHXKXs0=; b=k+6zP8vZX+QbkibmYYpjaaj53 KfUAGhPUe72tqBJA3/22n72NmMTsU6YOn9cMbCqn/6o3MklzzS0d+a+Q91fFsdq0EPYL6G/DoCh50 QXW9F5G/53QRldQOngoVm+JhVrLwW0fFeXdsHhQDcfAFJNYukriReLkyMvkvs28BozmxD3jgwG4mo m0UhUhixAWTinxGTUqxqQnrx/UL2ODuE6/4RSdrODadd4+0zRWYWb67CdU9eGhM5Fi1vgytrTUYob K4yFj7Qsy/DRgG6WrRoWouav4DwZG80iF9hIpspXcgKs1GsE+vaZ/bFdpkvKxRsnP4n1iop/AHzj+ bOxsCxt2A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPsuA-004IcC-9K; Fri, 26 Mar 2021 20:18:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPsu1-004Iai-Ps; Fri, 26 Mar 2021 20:17:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2450561A18; Fri, 26 Mar 2021 20:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616789872; bh=HQiYbloBWeueZbq2L4oIhpCdSmR81v4HPpPi6S55n34=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ANchPUbA7/niZ+2pM4ATJhblFIlE8ITlpAvMJLR+NSAxfJASezVQ9ueEhWhaJElvb 5Fjusoq4cJ0G/sOxwXl0fz5HbIhwNBasdrdYjbUx3UmyCIR9b3qNbDa58OMuixoW2X tAqhmk5N+YeYehwzOTjnh11PdSoJieSF11ZManBgDB4SgRa29rCFAORH3ljc5PkIbB ZKTGa6IrzdubbAH9NINQB1/6Ykjvb9+oSblL3CEV1aTv9MoLtZ90DjyEpoe9aJtQp1 GrFCofGtIWioYjjG8FMi4rBUtVqEWTLQVYfcrq2YwQgiawMoXxMqoMzs6DEKEsmYUh V+3mns8AoL8vQ== Date: Fri, 26 Mar 2021 15:17:50 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v3 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up Message-ID: <20210326201750.GA905944@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210326191906.43567-4-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_201754_111175_4EEBB878 X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 26, 2021 at 03:19:01PM -0400, Jim Quinlan wrote: > If any downstream device may wake up during S2/S3 suspend, we do not want > to turn off its power when suspending. > > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 58 +++++++++++++++++++++++---- > 1 file changed, 51 insertions(+), 7 deletions(-) > +enum { > + TURN_OFF, /* Turn egulators off, unless an EP is wakeup-capable */ > + TURN_OFF_ALWAYS, /* Turn Regulators off, no exceptions */ > + TURN_ON, /* Turn regulators on, unless pcie->ep_wakeup_capable */ s/egulators/regulators/ s/Regulators/regulators/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel