From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2A5C433E0 for ; Fri, 26 Mar 2021 21:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D033361A27 for ; Fri, 26 Mar 2021 21:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230176AbhCZVqR (ORCPT ); Fri, 26 Mar 2021 17:46:17 -0400 Received: from elvis.franken.de ([193.175.24.41]:48974 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbhCZVp6 (ORCPT ); Fri, 26 Mar 2021 17:45:58 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lPuHC-0004rB-00; Fri, 26 Mar 2021 22:45:54 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 6FED3C1CF5; Fri, 26 Mar 2021 22:44:45 +0100 (CET) Date: Fri, 26 Mar 2021 22:44:45 +0100 From: Thomas Bogendoerfer To: Florian Fainelli Cc: linux-mips@vger.kernel.org, Randy Dunlap , Jiaxun Yang , Liangliang Huang , Huacai Chen , Geert Uytterhoeven , Anshuman Khandual , Kees Cook , Jinyang He , Vlastimil Babka , Yousong Zhou , Daniel Jordan , Michel Lespinasse , open list Subject: Re: [PATCH v2] MIPS: Add support for CONFIG_DEBUG_VIRTUAL Message-ID: <20210326214445.GA19129@alpha.franken.de> References: <20210323222103.34225-1-f.fainelli@gmail.com> <20210325095739.GB5775@alpha.franken.de> <439e06b6-d26a-e43d-1e09-c8fd41aea6ed@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <439e06b6-d26a-e43d-1e09-c8fd41aea6ed@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 10:45:39AM -0700, Florian Fainelli wrote: > > > On 3/25/2021 2:57 AM, Thomas Bogendoerfer wrote: > > On Tue, Mar 23, 2021 at 03:20:43PM -0700, Florian Fainelli wrote: > >> Provide hooks to intercept bad usages of virt_to_phys() and > >> __pa_symbol() throughout the kernel. To make this possible, we need to > >> rename the current implement of virt_to_phys() into > >> __virt_to_phys_nodebug() and wrap it around depending on > >> CONFIG_DEBUG_VIRTUAL. > >> > >> A similar thing is needed for __pa_symbol() which is now aliased to > >> __phys_addr_symbol() whose implementation is either the direct return of > >> RELOC_HIDE or goes through the debug version. > >> > >> Signed-off-by: Florian Fainelli > >> --- > >> Changes in v2: > >> - fixed sparse warning in arch/mips/kernel/vdso.c > > > > checkpatch warns about a missing SPDX license in arch/mips/mm/physaddr.c, > > can you please add one ? > > Yes. > > > > > And as checkpatch is also unhappy about the volatiles, do we really > > need them here ? > > This is just following the existing prototypes for virt_to_phys() > declared in arch/mips/include/asm/io.h. This can be changed to unsigned > long if you prefer? I just checked other archs and they also use volatile, so nothing to change here. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]