From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4E3C433E2 for ; Sat, 27 Mar 2021 00:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA11C61A38 for ; Sat, 27 Mar 2021 00:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbhC0AMZ (ORCPT ); Fri, 26 Mar 2021 20:12:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbhC0AMI (ORCPT ); Fri, 26 Mar 2021 20:12:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 644A8C0613AA for ; Fri, 26 Mar 2021 17:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g7CX3ObKEZFPHfE2CrxoZpsvFPZB8ASiYPTz2KR8q0Q=; b=Y18hNRKwse5r4jkAnvBT/wTpGh SL5BfZDIQvlzN3INiqTDT5fT+e9VXnLotEeTX18jJmEMIgw1E1SkUXNkX1KjQ9NJRnrGlKMFoEM71 +/ogPpr5G8E31mIgbPOCynvT5b6wGWOzRzbu8fgjgj2EcPIcRXlwlP+A9iDjueYUjvNMy0DcxjMFB cHz7x0VRVPXYR3zbe8u6iBLAMUZ4NSr0AsMElm3zLnSf3jnlUMq16I1IjHhhYZdnyNUiNNoXgsY31 pPYqFkwGUgZezkhHGJTl6hnRnteggsjPqBwKDt7MVPmEH8ICVGxTnTdr7Ze4Xs/WLPQKV6t2r2D5e rg+k8yMw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lPwWO-00Fez6-CC; Sat, 27 Mar 2021 00:09:47 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 27F9698108D; Sat, 27 Mar 2021 01:09:43 +0100 (CET) Date: Sat, 27 Mar 2021 01:09:43 +0100 From: Peter Zijlstra To: "Joel Fernandes (Google)" Cc: Nishanth Aravamudan , Julien Desfossez , Tim Chen , Vineeth Pillai , Aaron Lu , Aubrey Li , tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, keescook@chromium.org, Phil Auld , Valentin Schneider , Mel Gorman , Pawan Gupta , Paolo Bonzini , vineeth@bitbyteword.org, Chen Yu , Christian Brauner , Agata Gruza , Antonio Gomez Iglesias , graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com, rostedt@goodmis.org, benbjiang@tencent.com, Alexandre Chartre , James.Bottomley@hansenpartnership.com, OWeisse@umich.edu, Dhaval Giani , chris.hyser@oracle.com, Josh Don , Hao Luo , Tom Lendacky , dhiatt@digitalocean.com Subject: Re: [PATCH resend 2/8] sched: core scheduling tagging infrastructure Message-ID: <20210327000943.GQ4746@worktop.programming.kicks-ass.net> References: <20210324214020.34142-1-joel@joelfernandes.org> <20210324214020.34142-3-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324214020.34142-3-joel@joelfernandes.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 05:40:14PM -0400, Joel Fernandes (Google) wrote: > From: Josh Don > > A single unsigned long is insufficient as a cookie value for core > scheduling. We will minimally have cookie values for a per-task and a > per-group interface, which must be combined into an overall cookie. > > This patch adds the infrastructure necessary for setting task and group > cookie. Namely, it reworks the core_cookie into a struct, and provides > interfaces for setting task and group cookie, as well as other > operations (i.e. compare()). Subsequent patches will use these hooks to > provide an API for setting these cookies. > *urgh*... so I specifically wanted the task interface first to avoid / get-rid of all this madness. And then you keep it :-( I've spend the past few hours rewriting patches #2 and #3, and adapting #4. The thing was working before I added SHARE_FROM back and introduced GET, but now I'm seeing a few FAILs from the selftest. I'm too tired to make sense of anything much, or even focus my eyes consistently, so I'll have to prod at it some more next week, but I've pushed out the lot to my queue.git: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/core-sched Also, we really need a better name than coretag.c.