From: Philippe Gerum <rpm@xenomai.org>
To: xenomai@xenomai.org
Subject: [PATCH 5/5] cobalt/intr: dovetail: Don't do anything in xnintr_enable/disable
Date: Sat, 27 Mar 2021 11:35:24 +0100 [thread overview]
Message-ID: <20210327103524.2305814-6-rpm@xenomai.org> (raw)
In-Reply-To: <20210327103524.2305814-1-rpm@xenomai.org>
From: Jan Kiszka <jan.kiszka@siemens.com>
As we are using regular request/free_irq under dovetail, there is no
extra task to be done in the interrupt enable/disable services. In fact,
calling enable_irq will rather trigger "Unbalanced enable for IRQ ..."
errors.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
kernel/cobalt/dovetail/intr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/cobalt/dovetail/intr.c b/kernel/cobalt/dovetail/intr.c
index 068dfe306..d1a1c14a9 100644
--- a/kernel/cobalt/dovetail/intr.c
+++ b/kernel/cobalt/dovetail/intr.c
@@ -109,15 +109,11 @@ EXPORT_SYMBOL_GPL(xnintr_detach);
void xnintr_enable(struct xnintr *intr)
{
- secondary_mode_only();
- enable_irq(intr->irq);
}
EXPORT_SYMBOL_GPL(xnintr_enable);
void xnintr_disable(struct xnintr *intr)
{
- secondary_mode_only();
- disable_irq(intr->irq);
}
EXPORT_SYMBOL_GPL(xnintr_disable);
--
2.29.2
next prev parent reply other threads:[~2021-03-27 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 10:35 [Dovetail PATCH 0/5] More clock and IRQ abstraction Philippe Gerum
2021-03-27 10:35 ` [PATCH 1/5] cobalt/syscall: dovetail: do not expose clock frequency to user Philippe Gerum
2021-03-27 10:35 ` [PATCH 2/5] cobalt/sched: dovetail: disable separate per-IRQ statistics Philippe Gerum
2021-04-07 10:53 ` Jan Kiszka
2021-04-07 11:55 ` Philippe Gerum
2021-04-07 16:16 ` Jan Kiszka
2021-03-27 10:35 ` [PATCH 3/5] cobalt/intr: pipeline: abstract interrupt system inits Philippe Gerum
2021-03-27 10:35 ` [PATCH 4/5] cobalt/intr: dovetail: implement interrupt management, handling Philippe Gerum
2021-03-27 10:35 ` Philippe Gerum [this message]
2021-04-07 10:55 ` [PATCH 5/5] cobalt/intr: dovetail: Don't do anything in xnintr_enable/disable Jan Kiszka
2021-04-07 16:20 ` [Dovetail PATCH 0/5] More clock and IRQ abstraction Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210327103524.2305814-6-rpm@xenomai.org \
--to=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.