All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ray Chi <raychi@google.com>
To: balbi@kernel.org, gregkh@linuxfoundation.org, sre@kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kyletso@google.com, badhri@google.com,
	Ray Chi <raychi@google.com>
Subject: [PATCH 1/2] usb: dwc3: gadget: modify the scale in vbus_draw callback
Date: Sun, 28 Mar 2021 02:28:08 +0800	[thread overview]
Message-ID: <20210327182809.1814480-2-raychi@google.com> (raw)
In-Reply-To: <20210327182809.1814480-1-raychi@google.com>

Currently, vbus_draw callback used wrong scale for power_supply.
The unit of power supply should be uA.
Therefore, this patch will fix this problem.

Fixes: 99288de36020 ("usb: dwc3: add an alternate path in vbus_draw callback")
Reported-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Ray Chi <raychi@google.com>
---
 drivers/usb/dwc3/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index e1442fc763e1..8a361f07e045 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2536,7 +2536,7 @@ static int dwc3_gadget_vbus_draw(struct usb_gadget *g, unsigned int mA)
 	if (!dwc->usb_psy)
 		return -EOPNOTSUPP;
 
-	val.intval = mA;
+	val.intval = 1000 * mA;
 	ret = power_supply_set_property(dwc->usb_psy, POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT, &val);
 
 	return ret;
-- 
2.31.0.291.g576ba9dcdaf-goog


  reply	other threads:[~2021-03-27 18:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 18:28 [PATCH 0/2] modify power_supply usage in dwc3 Ray Chi
2021-03-27 18:28 ` Ray Chi [this message]
2021-03-27 18:28 ` [PATCH 2/2] power: supply: Fix build error when CONFIG_POWER_SUPPLY is not enabled Ray Chi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210327182809.1814480-2-raychi@google.com \
    --to=raychi@google.com \
    --cc=badhri@google.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kyletso@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.