From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC539C433C1 for ; Sat, 27 Mar 2021 20:29:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD7B5619B6 for ; Sat, 27 Mar 2021 20:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbhC0U3Z (ORCPT ); Sat, 27 Mar 2021 16:29:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:57956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230015AbhC0U3I (ORCPT ); Sat, 27 Mar 2021 16:29:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 714E361934; Sat, 27 Mar 2021 20:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616876947; bh=t3YCJEd2YPJjPW/VVlG0IFWi7wn9Hjx67R3VG5hzcl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OVgsxOpRvQIxqPE+tVlAfHUdu4Ht9oWDHCLAsjOE+vmFKOWwLTVll1/pMalxxguzz 2ABiCxzQfFjMsFbKs2dU1YJOawTUQHpaZ4upIfCNQyEdjgxPdF4BJGNrBSRdLmzubC MrIO4ZKx6Zwh+dcpDQPtcptA5fgGib+YCGrJbfpR+O5i7Qivb1uDlQdJ5vV8dqLpbI p6Sc1hHEyjZFotDKbVpYjg+CT5IffrUtBP88CF1gWk6yteub0wDpelOOuv47JyeJo1 O0UK0jSAQSrvNT3blPK/jMLrwouakf5paB4o//qwQmiJrbGHv+QsiV3eRlqictBVn1 j1cI2jkt4CQKQ== Received: by pali.im (Postfix) id F180A95D; Sat, 27 Mar 2021 21:29:04 +0100 (CET) Date: Sat, 27 Mar 2021 21:29:04 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marc Zyngier Cc: Jianjun Wang , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Ryder Lee , Philipp Zabel , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com, chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com, sin_jieyang@mediatek.com, drinkcat@chromium.org, Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com, Krzysztof Wilczyski Subject: Re: [v9,5/7] PCI: mediatek-gen3: Add MSI support Message-ID: <20210327202904.nvn7tfodmc2xw23l@pali> References: <20210324030510.29177-1-jianjun.wang@mediatek.com> <20210324030510.29177-6-jianjun.wang@mediatek.com> <20210327192837.4rr46oeiuokritlc@pali> <87o8f4fkkh.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o8f4fkkh.wl-maz@kernel.org> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 27 March 2021 19:44:30 Marc Zyngier wrote: > On Sat, 27 Mar 2021 19:28:37 +0000, > Pali Rohár wrote: > > > > On Wednesday 24 March 2021 11:05:08 Jianjun Wang wrote: > > > +static void mtk_pcie_msi_handler(struct mtk_pcie_port *port, int set_idx) > > > +{ > > > + struct mtk_msi_set *msi_set = &port->msi_sets[set_idx]; > > > + unsigned long msi_enable, msi_status; > > > + unsigned int virq; > > > + irq_hw_number_t bit, hwirq; > > > + > > > + msi_enable = readl_relaxed(msi_set->base + PCIE_MSI_SET_ENABLE_OFFSET); > > > + > > > + do { > > > + msi_status = readl_relaxed(msi_set->base + > > > + PCIE_MSI_SET_STATUS_OFFSET); > > > + msi_status &= msi_enable; > > > + if (!msi_status) > > > + break; > > > + > > > + for_each_set_bit(bit, &msi_status, PCIE_MSI_IRQS_PER_SET) { > > > + hwirq = bit + set_idx * PCIE_MSI_IRQS_PER_SET; > > > + virq = irq_find_mapping(port->msi_bottom_domain, hwirq); > > > + generic_handle_irq(virq); > > > + } > > > + } while (true); > > > > Hello! > > > > Just a question, cannot this while-loop cause block of processing other > > interrupts? > > This is a level interrupt. You don't have much choice but to handle it > immediately, although an alternative would be to mask it and deal with > it in a thread. And since Linux doesn't deal with interrupt priority, > a screaming interrupt is never a good thing. I see. Something like "interrupt priority" (which does not exist?) would be needed to handle it. > > I have done tests with different HW (aardvark) but with same while(true) > > loop logic. One XHCI PCIe controller was sending MSI interrupts too fast > > and interrupt handler with this while(true) logic was in infinite loop. > > During one IRQ it was calling infinite many times generic_handle_irq() > > as HW was feeding new and new MSI hwirq into status register. > > Define "too fast". Fast - next interrupt comes prior checking if while(true)-loop should stop. > If something in the system is able to program the > XHCI device in such a way that it causes a screaming interrupt, that's > the place to look for problems, and probably not in the interrupt > handling itself, which does what it is supposed to do. > > > But this is different HW, so it can have different behavior and does not > > have to cause above issue. > > > > I have just spotted same code pattern for processing MSI interrupts... > > This is a common pattern that you will find in pretty much any > interrupt handling/demuxing, and is done this way when the cost of > taking the exception is high compared to that of handling it. And would not help if while(true)-loop is replaced by loop with upper limit of iterations? Or just call only one iteration? > Which is pretty much any of the badly designed, level-driving, > DW-inspired, sorry excuse for MSI implementations that are popular on > low-end ARM SoCs. Ok. So thank you for information! > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E14C433DB for ; Sat, 27 Mar 2021 20:29:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C99FE61942 for ; Sat, 27 Mar 2021 20:29:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C99FE61942 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C7JjmUyJgu9CKceOynB8obaSxAVn4IvSfh1FHUIBfAI=; b=efZlnAfdQHhpDJwxEd8mJuukx 4XFlDnEnG81apjR//o6AHiZrP42N30SzzKBUWcEAUZ75Rd39I2dikz6P8vlylo1mR2KS0w4HnH0wq dskp6E7pXfwAAmcQ0rB4/tnw/VebfY732JN9Lgkoe5+L0khUfmk1ig8kL5UpOO0Yuo23TD5Dm03O4 d2u94esLWXdTIN3KSVLnniym6C8b7hFn6QzdrfG/xpY51oUAasFJ2WO9CX7dDgbeubCbeF+vHcyua umYiSb659yzOWhMWXpKqFmSG2YQVpLsmK+FvbJqpg6UtRt9ZtD8dftzDJZ4ryuu0xY2bDFYc/j7PT ufyBtCi4w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQFYk-005VSC-Go; Sat, 27 Mar 2021 20:29:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQFYX-005VRW-Sk; Sat, 27 Mar 2021 20:29:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 714E361934; Sat, 27 Mar 2021 20:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616876947; bh=t3YCJEd2YPJjPW/VVlG0IFWi7wn9Hjx67R3VG5hzcl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OVgsxOpRvQIxqPE+tVlAfHUdu4Ht9oWDHCLAsjOE+vmFKOWwLTVll1/pMalxxguzz 2ABiCxzQfFjMsFbKs2dU1YJOawTUQHpaZ4upIfCNQyEdjgxPdF4BJGNrBSRdLmzubC MrIO4ZKx6Zwh+dcpDQPtcptA5fgGib+YCGrJbfpR+O5i7Qivb1uDlQdJ5vV8dqLpbI p6Sc1hHEyjZFotDKbVpYjg+CT5IffrUtBP88CF1gWk6yteub0wDpelOOuv47JyeJo1 O0UK0jSAQSrvNT3blPK/jMLrwouakf5paB4o//qwQmiJrbGHv+QsiV3eRlqictBVn1 j1cI2jkt4CQKQ== Received: by pali.im (Postfix) id F180A95D; Sat, 27 Mar 2021 21:29:04 +0100 (CET) Date: Sat, 27 Mar 2021 21:29:04 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marc Zyngier Cc: Jianjun Wang , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Ryder Lee , Philipp Zabel , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com, chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com, sin_jieyang@mediatek.com, drinkcat@chromium.org, Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com, Krzysztof Wilczyski Subject: Re: [v9,5/7] PCI: mediatek-gen3: Add MSI support Message-ID: <20210327202904.nvn7tfodmc2xw23l@pali> References: <20210324030510.29177-1-jianjun.wang@mediatek.com> <20210324030510.29177-6-jianjun.wang@mediatek.com> <20210327192837.4rr46oeiuokritlc@pali> <87o8f4fkkh.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8f4fkkh.wl-maz@kernel.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210327_202914_296801_B3C9F424 X-CRM114-Status: GOOD ( 29.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gU2F0dXJkYXkgMjcgTWFyY2ggMjAyMSAxOTo0NDozMCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4g T24gU2F0LCAyNyBNYXIgMjAyMSAxOToyODozNyArMDAwMCwKPiBQYWxpIFJvaMOhciA8cGFsaUBr ZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gT24gV2VkbmVzZGF5IDI0IE1hcmNoIDIwMjEgMTE6 MDU6MDggSmlhbmp1biBXYW5nIHdyb3RlOgo+ID4gPiArc3RhdGljIHZvaWQgbXRrX3BjaWVfbXNp X2hhbmRsZXIoc3RydWN0IG10a19wY2llX3BvcnQgKnBvcnQsIGludCBzZXRfaWR4KQo+ID4gPiAr ewo+ID4gPiArCXN0cnVjdCBtdGtfbXNpX3NldCAqbXNpX3NldCA9ICZwb3J0LT5tc2lfc2V0c1tz ZXRfaWR4XTsKPiA+ID4gKwl1bnNpZ25lZCBsb25nIG1zaV9lbmFibGUsIG1zaV9zdGF0dXM7Cj4g PiA+ICsJdW5zaWduZWQgaW50IHZpcnE7Cj4gPiA+ICsJaXJxX2h3X251bWJlcl90IGJpdCwgaHdp cnE7Cj4gPiA+ICsKPiA+ID4gKwltc2lfZW5hYmxlID0gcmVhZGxfcmVsYXhlZChtc2lfc2V0LT5i YXNlICsgUENJRV9NU0lfU0VUX0VOQUJMRV9PRkZTRVQpOwo+ID4gPiArCj4gPiA+ICsJZG8gewo+ ID4gPiArCQltc2lfc3RhdHVzID0gcmVhZGxfcmVsYXhlZChtc2lfc2V0LT5iYXNlICsKPiA+ID4g KwkJCQkJICAgUENJRV9NU0lfU0VUX1NUQVRVU19PRkZTRVQpOwo+ID4gPiArCQltc2lfc3RhdHVz ICY9IG1zaV9lbmFibGU7Cj4gPiA+ICsJCWlmICghbXNpX3N0YXR1cykKPiA+ID4gKwkJCWJyZWFr Owo+ID4gPiArCj4gPiA+ICsJCWZvcl9lYWNoX3NldF9iaXQoYml0LCAmbXNpX3N0YXR1cywgUENJ RV9NU0lfSVJRU19QRVJfU0VUKSB7Cj4gPiA+ICsJCQlod2lycSA9IGJpdCArIHNldF9pZHggKiBQ Q0lFX01TSV9JUlFTX1BFUl9TRVQ7Cj4gPiA+ICsJCQl2aXJxID0gaXJxX2ZpbmRfbWFwcGluZyhw b3J0LT5tc2lfYm90dG9tX2RvbWFpbiwgaHdpcnEpOwo+ID4gPiArCQkJZ2VuZXJpY19oYW5kbGVf aXJxKHZpcnEpOwo+ID4gPiArCQl9Cj4gPiA+ICsJfSB3aGlsZSAodHJ1ZSk7Cj4gPiAKPiA+IEhl bGxvIQo+ID4gCj4gPiBKdXN0IGEgcXVlc3Rpb24sIGNhbm5vdCB0aGlzIHdoaWxlLWxvb3AgY2F1 c2UgYmxvY2sgb2YgcHJvY2Vzc2luZyBvdGhlcgo+ID4gaW50ZXJydXB0cz8KPiAKPiBUaGlzIGlz IGEgbGV2ZWwgaW50ZXJydXB0LiBZb3UgZG9uJ3QgaGF2ZSBtdWNoIGNob2ljZSBidXQgdG8gaGFu ZGxlIGl0Cj4gaW1tZWRpYXRlbHksIGFsdGhvdWdoIGFuIGFsdGVybmF0aXZlIHdvdWxkIGJlIHRv IG1hc2sgaXQgYW5kIGRlYWwgd2l0aAo+IGl0IGluIGEgdGhyZWFkLiBBbmQgc2luY2UgTGludXgg ZG9lc24ndCBkZWFsIHdpdGggaW50ZXJydXB0IHByaW9yaXR5LAo+IGEgc2NyZWFtaW5nIGludGVy cnVwdCBpcyBuZXZlciBhIGdvb2QgdGhpbmcuCgpJIHNlZS4gU29tZXRoaW5nIGxpa2UgImludGVy cnVwdCBwcmlvcml0eSIgKHdoaWNoIGRvZXMgbm90IGV4aXN0Pykgd291bGQKYmUgbmVlZGVkIHRv IGhhbmRsZSBpdC4KCj4gPiBJIGhhdmUgZG9uZSB0ZXN0cyB3aXRoIGRpZmZlcmVudCBIVyAoYWFy ZHZhcmspIGJ1dCB3aXRoIHNhbWUgd2hpbGUodHJ1ZSkKPiA+IGxvb3AgbG9naWMuIE9uZSBYSENJ IFBDSWUgY29udHJvbGxlciB3YXMgc2VuZGluZyBNU0kgaW50ZXJydXB0cyB0b28gZmFzdAo+ID4g YW5kIGludGVycnVwdCBoYW5kbGVyIHdpdGggdGhpcyB3aGlsZSh0cnVlKSBsb2dpYyB3YXMgaW4g aW5maW5pdGUgbG9vcC4KPiA+IER1cmluZyBvbmUgSVJRIGl0IHdhcyBjYWxsaW5nIGluZmluaXRl IG1hbnkgdGltZXMgZ2VuZXJpY19oYW5kbGVfaXJxKCkKPiA+IGFzIEhXIHdhcyBmZWVkaW5nIG5l dyBhbmQgbmV3IE1TSSBod2lycSBpbnRvIHN0YXR1cyByZWdpc3Rlci4KPiAKPiBEZWZpbmUgInRv byBmYXN0Ii4KCkZhc3QgLSBuZXh0IGludGVycnVwdCBjb21lcyBwcmlvciBjaGVja2luZyBpZiB3 aGlsZSh0cnVlKS1sb29wIHNob3VsZCBzdG9wLgoKPiBJZiBzb21ldGhpbmcgaW4gdGhlIHN5c3Rl bSBpcyBhYmxlIHRvIHByb2dyYW0gdGhlCj4gWEhDSSBkZXZpY2UgaW4gc3VjaCBhIHdheSB0aGF0 IGl0IGNhdXNlcyBhIHNjcmVhbWluZyBpbnRlcnJ1cHQsIHRoYXQncwo+IHRoZSBwbGFjZSB0byBs b29rIGZvciBwcm9ibGVtcywgYW5kIHByb2JhYmx5IG5vdCBpbiB0aGUgaW50ZXJydXB0Cj4gaGFu ZGxpbmcgaXRzZWxmLCB3aGljaCBkb2VzIHdoYXQgaXQgaXMgc3VwcG9zZWQgdG8gZG8uCj4gCj4g PiBCdXQgdGhpcyBpcyBkaWZmZXJlbnQgSFcsIHNvIGl0IGNhbiBoYXZlIGRpZmZlcmVudCBiZWhh dmlvciBhbmQgZG9lcyBub3QKPiA+IGhhdmUgdG8gY2F1c2UgYWJvdmUgaXNzdWUuCj4gPiAKPiA+ IEkgaGF2ZSBqdXN0IHNwb3R0ZWQgc2FtZSBjb2RlIHBhdHRlcm4gZm9yIHByb2Nlc3NpbmcgTVNJ IGludGVycnVwdHMuLi4KPiAKPiBUaGlzIGlzIGEgY29tbW9uIHBhdHRlcm4gdGhhdCB5b3Ugd2ls bCBmaW5kIGluIHByZXR0eSBtdWNoIGFueQo+IGludGVycnVwdCBoYW5kbGluZy9kZW11eGluZywg YW5kIGlzIGRvbmUgdGhpcyB3YXkgd2hlbiB0aGUgY29zdCBvZgo+IHRha2luZyB0aGUgZXhjZXB0 aW9uIGlzIGhpZ2ggY29tcGFyZWQgdG8gdGhhdCBvZiBoYW5kbGluZyBpdC4KCkFuZCB3b3VsZCBu b3QgaGVscCBpZiB3aGlsZSh0cnVlKS1sb29wIGlzIHJlcGxhY2VkIGJ5IGxvb3Agd2l0aCB1cHBl cgpsaW1pdCBvZiBpdGVyYXRpb25zPyBPciBqdXN0IGNhbGwgb25seSBvbmUgaXRlcmF0aW9uPwoK PiBXaGljaCBpcyBwcmV0dHkgbXVjaCBhbnkgb2YgdGhlIGJhZGx5IGRlc2lnbmVkLCBsZXZlbC1k cml2aW5nLAo+IERXLWluc3BpcmVkLCBzb3JyeSBleGN1c2UgZm9yIE1TSSBpbXBsZW1lbnRhdGlv bnMgdGhhdCBhcmUgcG9wdWxhciBvbgo+IGxvdy1lbmQgQVJNIFNvQ3MuCgpPay4gU28gdGhhbmsg eW91IGZvciBpbmZvcm1hdGlvbiEKCj4gVGhhbmtzLAo+IAo+IAlNLgo+IAo+IC0tIAo+IFdpdGhv dXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlh dGVrIG1haWxpbmcgbGlzdApMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D38AC433C1 for ; Sat, 27 Mar 2021 20:31:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D844561958 for ; Sat, 27 Mar 2021 20:31:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D844561958 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nC/wPzOOCuK7QyEuzHSsF2nraZHccYVvT9caG0QQf68=; b=cWjip3TfvGNvbofIim0fFmfwE 3325EVSMql6434GaoJfGczBF5pV/dDlKGBRhazx6QhVC9D/Kt1PcSCWrUqG3S2sEZnxaoK3veCnMm kFuyMy8RfCRFXtXBpDcmkv62fiKPnxi62lfDiJazKLRkssu+aIW3SHSvC9vT3stBvJ5y5JNK9KdJj nuNE3lFJ9SfezrUseN6cFJV2jAY5yQWqjGAsctMyLa+5Qil4teR5mxS+9CG5LaOvM+tD/qugWhqpE vzKoAPkoAXCkcYafoy/PPvvUAWJcLXy5IgHcCCPm+JjO4H8+rM3l51LFPGQ8kKQkOLuGOryEQGv5a GER0Wg1vg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQFYe-005VRw-Dn; Sat, 27 Mar 2021 20:29:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQFYX-005VRW-Sk; Sat, 27 Mar 2021 20:29:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 714E361934; Sat, 27 Mar 2021 20:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616876947; bh=t3YCJEd2YPJjPW/VVlG0IFWi7wn9Hjx67R3VG5hzcl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OVgsxOpRvQIxqPE+tVlAfHUdu4Ht9oWDHCLAsjOE+vmFKOWwLTVll1/pMalxxguzz 2ABiCxzQfFjMsFbKs2dU1YJOawTUQHpaZ4upIfCNQyEdjgxPdF4BJGNrBSRdLmzubC MrIO4ZKx6Zwh+dcpDQPtcptA5fgGib+YCGrJbfpR+O5i7Qivb1uDlQdJ5vV8dqLpbI p6Sc1hHEyjZFotDKbVpYjg+CT5IffrUtBP88CF1gWk6yteub0wDpelOOuv47JyeJo1 O0UK0jSAQSrvNT3blPK/jMLrwouakf5paB4o//qwQmiJrbGHv+QsiV3eRlqictBVn1 j1cI2jkt4CQKQ== Received: by pali.im (Postfix) id F180A95D; Sat, 27 Mar 2021 21:29:04 +0100 (CET) Date: Sat, 27 Mar 2021 21:29:04 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marc Zyngier Cc: Jianjun Wang , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Ryder Lee , Philipp Zabel , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com, chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com, sin_jieyang@mediatek.com, drinkcat@chromium.org, Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com, Krzysztof Wilczyski Subject: Re: [v9,5/7] PCI: mediatek-gen3: Add MSI support Message-ID: <20210327202904.nvn7tfodmc2xw23l@pali> References: <20210324030510.29177-1-jianjun.wang@mediatek.com> <20210324030510.29177-6-jianjun.wang@mediatek.com> <20210327192837.4rr46oeiuokritlc@pali> <87o8f4fkkh.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8f4fkkh.wl-maz@kernel.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210327_202914_296801_B3C9F424 X-CRM114-Status: GOOD ( 29.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0dXJkYXkgMjcgTWFyY2ggMjAyMSAxOTo0NDozMCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4g T24gU2F0LCAyNyBNYXIgMjAyMSAxOToyODozNyArMDAwMCwKPiBQYWxpIFJvaMOhciA8cGFsaUBr ZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gT24gV2VkbmVzZGF5IDI0IE1hcmNoIDIwMjEgMTE6 MDU6MDggSmlhbmp1biBXYW5nIHdyb3RlOgo+ID4gPiArc3RhdGljIHZvaWQgbXRrX3BjaWVfbXNp X2hhbmRsZXIoc3RydWN0IG10a19wY2llX3BvcnQgKnBvcnQsIGludCBzZXRfaWR4KQo+ID4gPiAr ewo+ID4gPiArCXN0cnVjdCBtdGtfbXNpX3NldCAqbXNpX3NldCA9ICZwb3J0LT5tc2lfc2V0c1tz ZXRfaWR4XTsKPiA+ID4gKwl1bnNpZ25lZCBsb25nIG1zaV9lbmFibGUsIG1zaV9zdGF0dXM7Cj4g PiA+ICsJdW5zaWduZWQgaW50IHZpcnE7Cj4gPiA+ICsJaXJxX2h3X251bWJlcl90IGJpdCwgaHdp cnE7Cj4gPiA+ICsKPiA+ID4gKwltc2lfZW5hYmxlID0gcmVhZGxfcmVsYXhlZChtc2lfc2V0LT5i YXNlICsgUENJRV9NU0lfU0VUX0VOQUJMRV9PRkZTRVQpOwo+ID4gPiArCj4gPiA+ICsJZG8gewo+ ID4gPiArCQltc2lfc3RhdHVzID0gcmVhZGxfcmVsYXhlZChtc2lfc2V0LT5iYXNlICsKPiA+ID4g KwkJCQkJICAgUENJRV9NU0lfU0VUX1NUQVRVU19PRkZTRVQpOwo+ID4gPiArCQltc2lfc3RhdHVz ICY9IG1zaV9lbmFibGU7Cj4gPiA+ICsJCWlmICghbXNpX3N0YXR1cykKPiA+ID4gKwkJCWJyZWFr Owo+ID4gPiArCj4gPiA+ICsJCWZvcl9lYWNoX3NldF9iaXQoYml0LCAmbXNpX3N0YXR1cywgUENJ RV9NU0lfSVJRU19QRVJfU0VUKSB7Cj4gPiA+ICsJCQlod2lycSA9IGJpdCArIHNldF9pZHggKiBQ Q0lFX01TSV9JUlFTX1BFUl9TRVQ7Cj4gPiA+ICsJCQl2aXJxID0gaXJxX2ZpbmRfbWFwcGluZyhw b3J0LT5tc2lfYm90dG9tX2RvbWFpbiwgaHdpcnEpOwo+ID4gPiArCQkJZ2VuZXJpY19oYW5kbGVf aXJxKHZpcnEpOwo+ID4gPiArCQl9Cj4gPiA+ICsJfSB3aGlsZSAodHJ1ZSk7Cj4gPiAKPiA+IEhl bGxvIQo+ID4gCj4gPiBKdXN0IGEgcXVlc3Rpb24sIGNhbm5vdCB0aGlzIHdoaWxlLWxvb3AgY2F1 c2UgYmxvY2sgb2YgcHJvY2Vzc2luZyBvdGhlcgo+ID4gaW50ZXJydXB0cz8KPiAKPiBUaGlzIGlz IGEgbGV2ZWwgaW50ZXJydXB0LiBZb3UgZG9uJ3QgaGF2ZSBtdWNoIGNob2ljZSBidXQgdG8gaGFu ZGxlIGl0Cj4gaW1tZWRpYXRlbHksIGFsdGhvdWdoIGFuIGFsdGVybmF0aXZlIHdvdWxkIGJlIHRv IG1hc2sgaXQgYW5kIGRlYWwgd2l0aAo+IGl0IGluIGEgdGhyZWFkLiBBbmQgc2luY2UgTGludXgg ZG9lc24ndCBkZWFsIHdpdGggaW50ZXJydXB0IHByaW9yaXR5LAo+IGEgc2NyZWFtaW5nIGludGVy cnVwdCBpcyBuZXZlciBhIGdvb2QgdGhpbmcuCgpJIHNlZS4gU29tZXRoaW5nIGxpa2UgImludGVy cnVwdCBwcmlvcml0eSIgKHdoaWNoIGRvZXMgbm90IGV4aXN0Pykgd291bGQKYmUgbmVlZGVkIHRv IGhhbmRsZSBpdC4KCj4gPiBJIGhhdmUgZG9uZSB0ZXN0cyB3aXRoIGRpZmZlcmVudCBIVyAoYWFy ZHZhcmspIGJ1dCB3aXRoIHNhbWUgd2hpbGUodHJ1ZSkKPiA+IGxvb3AgbG9naWMuIE9uZSBYSENJ IFBDSWUgY29udHJvbGxlciB3YXMgc2VuZGluZyBNU0kgaW50ZXJydXB0cyB0b28gZmFzdAo+ID4g YW5kIGludGVycnVwdCBoYW5kbGVyIHdpdGggdGhpcyB3aGlsZSh0cnVlKSBsb2dpYyB3YXMgaW4g aW5maW5pdGUgbG9vcC4KPiA+IER1cmluZyBvbmUgSVJRIGl0IHdhcyBjYWxsaW5nIGluZmluaXRl IG1hbnkgdGltZXMgZ2VuZXJpY19oYW5kbGVfaXJxKCkKPiA+IGFzIEhXIHdhcyBmZWVkaW5nIG5l dyBhbmQgbmV3IE1TSSBod2lycSBpbnRvIHN0YXR1cyByZWdpc3Rlci4KPiAKPiBEZWZpbmUgInRv byBmYXN0Ii4KCkZhc3QgLSBuZXh0IGludGVycnVwdCBjb21lcyBwcmlvciBjaGVja2luZyBpZiB3 aGlsZSh0cnVlKS1sb29wIHNob3VsZCBzdG9wLgoKPiBJZiBzb21ldGhpbmcgaW4gdGhlIHN5c3Rl bSBpcyBhYmxlIHRvIHByb2dyYW0gdGhlCj4gWEhDSSBkZXZpY2UgaW4gc3VjaCBhIHdheSB0aGF0 IGl0IGNhdXNlcyBhIHNjcmVhbWluZyBpbnRlcnJ1cHQsIHRoYXQncwo+IHRoZSBwbGFjZSB0byBs b29rIGZvciBwcm9ibGVtcywgYW5kIHByb2JhYmx5IG5vdCBpbiB0aGUgaW50ZXJydXB0Cj4gaGFu ZGxpbmcgaXRzZWxmLCB3aGljaCBkb2VzIHdoYXQgaXQgaXMgc3VwcG9zZWQgdG8gZG8uCj4gCj4g PiBCdXQgdGhpcyBpcyBkaWZmZXJlbnQgSFcsIHNvIGl0IGNhbiBoYXZlIGRpZmZlcmVudCBiZWhh dmlvciBhbmQgZG9lcyBub3QKPiA+IGhhdmUgdG8gY2F1c2UgYWJvdmUgaXNzdWUuCj4gPiAKPiA+ IEkgaGF2ZSBqdXN0IHNwb3R0ZWQgc2FtZSBjb2RlIHBhdHRlcm4gZm9yIHByb2Nlc3NpbmcgTVNJ IGludGVycnVwdHMuLi4KPiAKPiBUaGlzIGlzIGEgY29tbW9uIHBhdHRlcm4gdGhhdCB5b3Ugd2ls bCBmaW5kIGluIHByZXR0eSBtdWNoIGFueQo+IGludGVycnVwdCBoYW5kbGluZy9kZW11eGluZywg YW5kIGlzIGRvbmUgdGhpcyB3YXkgd2hlbiB0aGUgY29zdCBvZgo+IHRha2luZyB0aGUgZXhjZXB0 aW9uIGlzIGhpZ2ggY29tcGFyZWQgdG8gdGhhdCBvZiBoYW5kbGluZyBpdC4KCkFuZCB3b3VsZCBu b3QgaGVscCBpZiB3aGlsZSh0cnVlKS1sb29wIGlzIHJlcGxhY2VkIGJ5IGxvb3Agd2l0aCB1cHBl cgpsaW1pdCBvZiBpdGVyYXRpb25zPyBPciBqdXN0IGNhbGwgb25seSBvbmUgaXRlcmF0aW9uPwoK PiBXaGljaCBpcyBwcmV0dHkgbXVjaCBhbnkgb2YgdGhlIGJhZGx5IGRlc2lnbmVkLCBsZXZlbC1k cml2aW5nLAo+IERXLWluc3BpcmVkLCBzb3JyeSBleGN1c2UgZm9yIE1TSSBpbXBsZW1lbnRhdGlv bnMgdGhhdCBhcmUgcG9wdWxhciBvbgo+IGxvdy1lbmQgQVJNIFNvQ3MuCgpPay4gU28gdGhhbmsg eW91IGZvciBpbmZvcm1hdGlvbiEKCj4gVGhhbmtzLAo+IAo+IAlNLgo+IAo+IC0tIAo+IFdpdGhv dXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBwb3NzaWJsZS4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK