All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error
@ 2021-03-28 12:05 ` Atul Gopinathan
  0 siblings, 0 replies; 4+ messages in thread
From: Atul Gopinathan @ 2021-03-28 12:05 UTC (permalink / raw)
  To: davem
  Cc: yoshfuji, dsahern, kuba, ast, daniel, andrii, kafai,
	songliubraving, yhs, john.fastabend, kpsingh, netdev, bpf,
	linux-kernel, skhan, linux-kernel-mentees, Atul Gopinathan,
	syzbot+0b74d8ec3bf0cc4e4209

Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL
enabled is causing a compilation error:

"net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before
',' token"

Fix this by removing an unnecessary comma.

Reported-by: syzbot+0b74d8ec3bf0cc4e4209@syzkaller.appspotmail.com
Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc")
Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
---
 net/ipv4/bpf_tcp_ca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/bpf_tcp_ca.c b/net/ipv4/bpf_tcp_ca.c
index 40520b77a307..12777d444d0f 100644
--- a/net/ipv4/bpf_tcp_ca.c
+++ b/net/ipv4/bpf_tcp_ca.c
@@ -202,15 +202,15 @@ BTF_ID(func, dctcp_cwnd_undo)
 BTF_ID(func, dctcp_state)
 #endif
 #if IS_BUILTIN(CONFIG_TCP_CONG_BBR)
 BTF_ID(func, bbr_init)
 BTF_ID(func, bbr_main)
 BTF_ID(func, bbr_sndbuf_expand)
 BTF_ID(func, bbr_undo_cwnd)
-BTF_ID(func, bbr_cwnd_even),
+BTF_ID(func, bbr_cwnd_even)
 BTF_ID(func, bbr_ssthresh)
 BTF_ID(func, bbr_min_tso_segs)
 BTF_ID(func, bbr_set_state)
 #endif
 BTF_SET_END(bpf_tcp_ca_kfunc_ids)
 
 static bool bpf_tcp_ca_check_kfunc_call(u32 kfunc_btf_id)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error
@ 2021-03-28 12:05 ` Atul Gopinathan
  0 siblings, 0 replies; 4+ messages in thread
From: Atul Gopinathan @ 2021-03-28 12:05 UTC (permalink / raw)
  To: davem
  Cc: songliubraving, daniel, yoshfuji, netdev, dsahern,
	john.fastabend, ast, andrii, Atul Gopinathan,
	syzbot+0b74d8ec3bf0cc4e4209, yhs, kpsingh, kuba, bpf,
	linux-kernel-mentees, kafai, linux-kernel

Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL
enabled is causing a compilation error:

"net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before
',' token"

Fix this by removing an unnecessary comma.

Reported-by: syzbot+0b74d8ec3bf0cc4e4209@syzkaller.appspotmail.com
Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc")
Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
---
 net/ipv4/bpf_tcp_ca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/bpf_tcp_ca.c b/net/ipv4/bpf_tcp_ca.c
index 40520b77a307..12777d444d0f 100644
--- a/net/ipv4/bpf_tcp_ca.c
+++ b/net/ipv4/bpf_tcp_ca.c
@@ -202,15 +202,15 @@ BTF_ID(func, dctcp_cwnd_undo)
 BTF_ID(func, dctcp_state)
 #endif
 #if IS_BUILTIN(CONFIG_TCP_CONG_BBR)
 BTF_ID(func, bbr_init)
 BTF_ID(func, bbr_main)
 BTF_ID(func, bbr_sndbuf_expand)
 BTF_ID(func, bbr_undo_cwnd)
-BTF_ID(func, bbr_cwnd_even),
+BTF_ID(func, bbr_cwnd_even)
 BTF_ID(func, bbr_ssthresh)
 BTF_ID(func, bbr_min_tso_segs)
 BTF_ID(func, bbr_set_state)
 #endif
 BTF_SET_END(bpf_tcp_ca_kfunc_ids)
 
 static bool bpf_tcp_ca_check_kfunc_call(u32 kfunc_btf_id)
-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error
  2021-03-28 12:05 ` Atul Gopinathan
@ 2021-03-28 18:45   ` Alexei Starovoitov
  -1 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2021-03-28 18:45 UTC (permalink / raw)
  To: Atul Gopinathan
  Cc: David S. Miller, Hideaki YOSHIFUJI, David Ahern, Jakub Kicinski,
	Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Network Development, bpf, LKML, Shuah Khan,
	linux-kernel-mentees, syzbot+0b74d8ec3bf0cc4e4209

On Sun, Mar 28, 2021 at 5:05 AM Atul Gopinathan
<atulgopinathan@gmail.com> wrote:
>
> Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL
> enabled is causing a compilation error:
>
> "net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before
> ',' token"
>
> Fix this by removing an unnecessary comma.
>
> Reported-by: syzbot+0b74d8ec3bf0cc4e4209@syzkaller.appspotmail.com
> Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc")
> Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>

Thanks for the quick fix. Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error
@ 2021-03-28 18:45   ` Alexei Starovoitov
  0 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2021-03-28 18:45 UTC (permalink / raw)
  To: Atul Gopinathan
  Cc: Song Liu, Martin KaFai Lau, Daniel Borkmann, Hideaki YOSHIFUJI,
	Network Development, David Ahern, John Fastabend,
	Alexei Starovoitov, Andrii Nakryiko, syzbot+0b74d8ec3bf0cc4e4209,
	Yonghong Song, KP Singh, Jakub Kicinski, bpf,
	linux-kernel-mentees, David S. Miller, LKML

On Sun, Mar 28, 2021 at 5:05 AM Atul Gopinathan
<atulgopinathan@gmail.com> wrote:
>
> Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL
> enabled is causing a compilation error:
>
> "net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before
> ',' token"
>
> Fix this by removing an unnecessary comma.
>
> Reported-by: syzbot+0b74d8ec3bf0cc4e4209@syzkaller.appspotmail.com
> Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc")
> Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>

Thanks for the quick fix. Applied.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-28 18:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-28 12:05 [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error Atul Gopinathan
2021-03-28 12:05 ` Atul Gopinathan
2021-03-28 18:45 ` Alexei Starovoitov
2021-03-28 18:45   ` Alexei Starovoitov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.