All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Andrew Baumann <Andrew.Baumann@microsoft.com>
Subject: Re: [PATCH v2 1/3] hw/display/bcm2835_fb: Resize console on reset
Date: Mon, 29 Mar 2021 07:59:15 +0200	[thread overview]
Message-ID: <20210329055915.zvkxo5u6cvk7hycp@sirius.home.kraxel.org> (raw)
In-Reply-To: <2953bd3c-bdde-0a51-8938-eb3fa4808213@amsat.org>

  Hi,

> > and realize
> > already calls qemu_console_resize(), so how can adding a
> > call to resize here in reset cause the console surface to
> > be created any earlier than it already is ?
> > 
> > I also don't understand how the GUI timer can call us before
> > the device is realized, given that we only register ourselves
> > via graphics_console_init() in the device realize.

Yes, should not happen.  Also note that graphics_console_init()
creates a surface.

> > Is it possible to get the UI layer to
> > not start calling into graphics devices until after the
> > system has been reset for the first time, for instance?

Can that actually happen?  I don't think it could in the past,
but maybe now with the initialization changes.  We can add a
check to gui_update() ...

take care,
  Gerd



  reply	other threads:[~2021-03-29  6:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 16:14 [PATCH v2 0/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Philippe Mathieu-Daudé
2021-03-23 16:14 ` [PATCH v2 1/3] hw/display/bcm2835_fb: Resize console on reset Philippe Mathieu-Daudé
2021-03-26 14:27   ` Peter Maydell
2021-03-26 23:13     ` Philippe Mathieu-Daudé
2021-03-29  5:59       ` Gerd Hoffmann [this message]
2021-05-19 18:22         ` Philippe Mathieu-Daudé
2021-03-23 16:14 ` [PATCH v2 2/3] hw/display/bcm2835_fb: Use bcm2835_fb_reconfigure in bcm2835_fb_reset Philippe Mathieu-Daudé
2021-03-23 16:14 ` [PATCH v2 3/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210329055915.zvkxo5u6cvk7hycp@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.