All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition
Date: Mon, 29 Mar 2021 16:22:51 +0100	[thread overview]
Message-ID: <20210329162251.0b4a7fbf@jic23-huawei> (raw)
In-Reply-To: <20210329130007.GE2916463@dell>

On Mon, 29 Mar 2021 14:00:07 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> On Mon, 29 Mar 2021, Jonathan Cameron wrote:
> 
> > On Fri, 26 Mar 2021 14:34:56 +0000
> > Lee Jones <lee.jones@linaro.org> wrote:
> >   
> > > Fixes the following W=1 kernel build warning(s):
> > > 
> > >  drivers/hid/hid-sensor-hub.c:54: warning: Function parameter or member 'hsdev' not described in 'hid_sensor_hub_callbacks_list'
> > >   
> > 
> > Perhaps nice to mention that this was a result of
> > 
> > ca2ed12f163b ("HID: hid-sensor-hub: Processing for duplicate physical ids")  
> 
> I only tend to do that for Fixes: tags, but Greg has made it clear
> that these patches are not suitable for stable.

Ok, I was deliberately not including Fixes for that reason, but
I guess some other script might moan if we do that :)

> 
> > > Cc: Jiri Kosina <jikos@kernel.org>
> > > Cc: Jonathan Cameron <jic23@kernel.org>
> > > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > > Cc: linux-input@vger.kernel.org
> > > Cc: linux-iio@vger.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>  
> 
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>  
> 
> Thanks dude, much appreciated.
> 


  reply	other threads:[~2021-03-29 15:23 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34   ` Lee Jones
2021-03-26 14:34   ` Lee Jones
2021-03-26 14:34 ` [PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err' Lee Jones
2021-03-26 14:34 ` [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used Lee Jones
2021-03-26 14:34 ` [PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' Lee Jones
2021-03-26 14:34 ` [PATCH 04/25] HID: intel-ish: Supply some missing param descriptions Lee Jones
2021-03-26 14:34 ` [PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error Lee Jones
2021-03-26 14:34 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
2021-04-07 16:56   ` Benjamin Tissoires
2021-04-08  7:05     ` Lee Jones
2021-03-26 14:34 ` [PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot Lee Jones
2021-03-26 14:34 ` [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Lee Jones
2021-03-26 14:34 ` [PATCH 09/25] HID: hid-alps: Correct struct misnaming Lee Jones
2021-03-26 14:34 ` [PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error Lee Jones
2021-03-26 14:34 ` [PATCH 11/25] HID: hid-core: Fix incorrect function name in header Lee Jones
2021-03-26 14:34 ` [PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() " Lee Jones
2021-03-26 14:34 ` [PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() Lee Jones
2021-03-26 14:34 ` [PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable() Lee Jones
2021-03-26 14:34 ` [PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret' Lee Jones
2021-03-26 14:34 ` [PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses Lee Jones
2021-03-26 14:34 ` [PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs Lee Jones
2021-03-26 14:34 ` [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Lee Jones
2021-03-26 14:34   ` Lee Jones
2021-03-26 14:34 ` [PATCH 19/25] HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers Lee Jones
2021-03-26 14:34 ` [PATCH 20/25] HID: hid-sensor-custom: Remove unused variable 'ret' Lee Jones
2021-03-29 11:26   ` Jonathan Cameron
2021-03-26 14:34 ` [PATCH 21/25] HID: wacom_sys: Demote kernel-doc abuse Lee Jones
2021-03-26 14:34 ` [PATCH 22/25] HID: hid-sensor-hub: Remove unused struct member 'quirks' Lee Jones
2021-03-29 11:27   ` Jonathan Cameron
2021-03-26 14:34 ` [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition Lee Jones
2021-03-29 11:30   ` Jonathan Cameron
2021-03-29 13:00     ` Lee Jones
2021-03-29 15:22       ` Jonathan Cameron [this message]
2021-03-26 14:34 ` [PATCH 24/25] HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues Lee Jones
2021-03-26 14:34   ` Lee Jones
2021-03-26 14:34 ` [PATCH 25/25] HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning Lee Jones
2021-04-06  8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-04-06  8:56   ` Lee Jones
2021-04-06  8:56   ` Lee Jones
2021-04-07 16:09   ` Benjamin Tissoires
2021-04-07 16:09     ` Benjamin Tissoires
2021-04-07 16:09     ` Benjamin Tissoires
2021-04-08  7:06     ` Lee Jones
2021-04-08  7:06       ` Lee Jones
2021-04-08  7:06       ` Lee Jones
2021-04-08 11:43       ` Benjamin Tissoires
2021-04-08 11:43         ` Benjamin Tissoires
2021-04-08 11:43         ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210329162251.0b4a7fbf@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.