From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 6/6] usb: typec: Link all ports during connector registration
Date: Mon, 29 Mar 2021 20:19:01 +0800 [thread overview]
Message-ID: <202103292005.aoaYhA4D-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3788 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210329084426.78138-7-heikki.krogerus@linux.intel.com>
References: <20210329084426.78138-7-heikki.krogerus@linux.intel.com>
TO: Heikki Krogerus <heikki.krogerus@linux.intel.com>
TO: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Benson Leung <bleung@google.com>
CC: Prashant Malani <pmalani@chromium.org>
CC: Guenter Roeck <linux@roeck-us.net>
CC: linux-usb(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
Hi Heikki,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210326]
[also build test WARNING on v5.12-rc5]
[cannot apply to usb/usb-testing chrome-platform-linux/for-next linus/master v5.12-rc5 v5.12-rc4 v5.12-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-Linking-ports-to-their-Type-C-connectors/20210329-164859
base: 931294922e65a23e1aad6398b9ae02df74044679
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-m021-20210329 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/usb/typec/port-mapper.c:229 each_port() warn: passing a valid pointer to 'PTR_ERR'
Old smatch warnings:
drivers/usb/typec/port-mapper.c:164 typec_link_port() warn: passing a valid pointer to 'PTR_ERR'
drivers/usb/typec/port-mapper.c:168 typec_link_port() warn: missing error code 'ret'
vim +/PTR_ERR +229 drivers/usb/typec/port-mapper.c
10f66a35667732 Heikki Krogerus 2021-03-29 220
10f66a35667732 Heikki Krogerus 2021-03-29 221 #ifdef CONFIG_USB
10f66a35667732 Heikki Krogerus 2021-03-29 222 static int each_port(struct device *port, void *connector)
10f66a35667732 Heikki Krogerus 2021-03-29 223 {
10f66a35667732 Heikki Krogerus 2021-03-29 224 struct port_node *node;
10f66a35667732 Heikki Krogerus 2021-03-29 225 int ret;
10f66a35667732 Heikki Krogerus 2021-03-29 226
10f66a35667732 Heikki Krogerus 2021-03-29 227 node = create_port_node(port);
10f66a35667732 Heikki Krogerus 2021-03-29 228 if (IS_ERR(node))
10f66a35667732 Heikki Krogerus 2021-03-29 @229 return PTR_ERR(node);
10f66a35667732 Heikki Krogerus 2021-03-29 230
10f66a35667732 Heikki Krogerus 2021-03-29 231 if (!connector_match(connector, node)) {
10f66a35667732 Heikki Krogerus 2021-03-29 232 remove_port_node(node);
10f66a35667732 Heikki Krogerus 2021-03-29 233 return 0;
10f66a35667732 Heikki Krogerus 2021-03-29 234 }
10f66a35667732 Heikki Krogerus 2021-03-29 235
10f66a35667732 Heikki Krogerus 2021-03-29 236 ret = link_port(to_typec_port(connector), node);
10f66a35667732 Heikki Krogerus 2021-03-29 237 if (ret) {
10f66a35667732 Heikki Krogerus 2021-03-29 238 remove_port_node(node->pld);
10f66a35667732 Heikki Krogerus 2021-03-29 239 return ret;
10f66a35667732 Heikki Krogerus 2021-03-29 240 }
10f66a35667732 Heikki Krogerus 2021-03-29 241
10f66a35667732 Heikki Krogerus 2021-03-29 242 get_device(connector);
10f66a35667732 Heikki Krogerus 2021-03-29 243
10f66a35667732 Heikki Krogerus 2021-03-29 244 return 0;
10f66a35667732 Heikki Krogerus 2021-03-29 245 }
10f66a35667732 Heikki Krogerus 2021-03-29 246 #endif
10f66a35667732 Heikki Krogerus 2021-03-29 247
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28163 bytes --]
next reply other threads:[~2021-03-29 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 12:19 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-29 8:44 [PATCH v2 0/6] usb: Linking ports to their Type-C connectors Heikki Krogerus
2021-03-29 8:44 ` [PATCH v2 6/6] usb: typec: Link all ports during connector registration Heikki Krogerus
2021-03-29 8:48 ` Greg Kroah-Hartman
2021-03-29 9:17 ` Heikki Krogerus
2021-03-29 9:19 ` Heikki Krogerus
2021-03-29 9:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103292005.aoaYhA4D-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.