From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC68C433EA for ; Mon, 29 Mar 2021 22:22:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3CB7619C9 for ; Mon, 29 Mar 2021 22:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231905AbhC2WVr (ORCPT ); Mon, 29 Mar 2021 18:21:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231421AbhC2WVi (ORCPT ); Mon, 29 Mar 2021 18:21:38 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0414C061762; Mon, 29 Mar 2021 15:21:37 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id l4so21778003ejc.10; Mon, 29 Mar 2021 15:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dRhm46fv/CqnkUkyrWxeHSP37MaaFXnAoj+y1DNtN2Y=; b=eXnfqJl1qFLQeJZK7a51+ogFSQiWCPIvWWPdoOkG2H4KyQjJ5b3RzF8TOPw+YtSnyf UsXkN6LccYrhgqc0d6wiq0+zL2QjM+iiV2v17BkfyVOZ2YbcQUSANEDqVbaWMG+Cgs4C SDw9l/yxjyKqwK4v4Op07CkxWQ+jmsY/Kq3tDE7Ui61NkL0fv8aFFQEaYvKoQ+qZHPMs /LvGqbgcUvk9qCllf2ZZxkmcbKr37hnkdMZCAyUDP8lIniG41DCBAwFyDNkwf8OSvk96 OgQJqtPexDqSLLNY2+jZx2l2m+kQvAdK0Hd7BMN4ulH8sNtXkQNhgbsji6E/SBTtCDQ8 zOqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dRhm46fv/CqnkUkyrWxeHSP37MaaFXnAoj+y1DNtN2Y=; b=CbjvL8gp6tFKRVqw9MBcWDm71I8xtYcIklqPLJQ+VnzyPxZb40jh1uL6XUlQ+44Er6 tZLmvfYS9C4q64HO4uNmP1zG6GbxPwj54HYfVloQPeiNbBzfV/Zc/9rUvHV8/y3faGfa RrxmpHwVKb96/0fo/srZOWzEmAOxLSA32G258FiCbuBGXACS7PzLQ9ODQJP/usFvIQv+ w98PlxSjA0bUOsbLaV+Ydte0b+RpKRZGG1V9TVQDDdE+eHv2SMFftzUAc7yycLhTDAjF p88jnCOgt+VnEOsaTuCVpyY138jz9MTwaXhilyDaDEKOE7xflNEGv1tTcG/rULIT1I1u uGuQ== X-Gm-Message-State: AOAM530xYg5aYG1wr/nM+DTyhzD8Z0iI5hoACWaNBx74XrGCxscVlMsS KgU0yif8j9nQYGPfEUAExBIGFWsV9HI= X-Google-Smtp-Source: ABdhPJxPkXZkXl6gT+vge6Qqo83lznr5txu39g6Vu4BfeimfbFhfubouHJu8gD4kK/UKCPInRKLQRQ== X-Received: by 2002:a17:906:701:: with SMTP id y1mr5194908ejb.243.1617056496624; Mon, 29 Mar 2021 15:21:36 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id d15sm9797536edx.62.2021.03.29.15.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 15:21:36 -0700 (PDT) Date: Tue, 30 Mar 2021 01:21:33 +0300 From: Cristian Ciocaltea To: Rob Herring Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding Message-ID: <20210329222133.GA1792209@BV030612LT> References: <95105518f61408743d17783099ed9c373a3dfe18.1616178258.git.cristian.ciocaltea@gmail.com> <20210327163006.GA185779@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210327163006.GA185779@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 27, 2021 at 10:30:06AM -0600, Rob Herring wrote: > On Fri, Mar 19, 2021 at 08:27:59PM +0200, Cristian Ciocaltea wrote: > > Add devicetree binding for the Actions Semi Owl SoCs info module. > > > > Signed-off-by: Cristian Ciocaltea > > --- > > .../bindings/soc/actions/owl-socinfo.yaml | 71 +++++++++++++++++++ [...] > > + > > +patternProperties: > > + "^soc(@[0-9a-f]+)?$": > > Make this a $nodename property. > > > + type: object > > + properties: > > And move this up to top-level. > > You need a custom 'select' entry to exclude 'simple-bus'. Indeed, I missed it.. > > + compatible: > > + items: > > + - enum: > > + - actions,s500-soc > > + - actions,s700-soc > > + - actions,s900-soc > > + - const: simple-bus > > + > > + "#address-cells": > > + enum: [1, 2] > > + > > + "#size-cells": > > + enum: [1, 2] > > + > > + ranges: true > > + > > + actions,serial-number-addrs: > > + description: | > > + Contains the physical addresses in DDR memory where the two parts > > + of the serial number (low & high) can be read from. > > + This is currently supported only on the S500 SoC variant. > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 2 > > + maxItems: 2 > > Humm, it doesn't really seem you have an actual device or bus here, but > are abusing DT to create your socinfo device. > > As the only property is data in main memory, you should do a compatible > for that memory region and put it under reserved-memory. You need that > anyway to prevent the kernel from using the memory, right? Right, this region should be exposed as reserved-memory. Will handle it in the next revision. > Rob Thanks for the review, Cristi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED4CC433C1 for ; Tue, 30 Mar 2021 01:17:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C73861999 for ; Tue, 30 Mar 2021 01:17:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C73861999 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0ZMoZsN5T4bqkJigjBFdbq9jvaPIc/yPVzMNvVJTlwU=; b=pMyW9afob6QHLaiLaHcTj4Vab qcMMlFT9gG4jMCD2YfpCojNjnOyw5xsqXjcKNxXPhEpa4BI28eQmO2N+XWZ10l+fLk1j1Tls2rb8U XyuAb9cEmchwpFw4yt8RoozVwLrcfXvEINrOZXmInHMeM8GvGiJA0MX/LD04bDGsGi081A08Ixhys xYXoN6PYm18jWEwDiGdgryg37KI7tPwyh1Y44+a3lHTTWSzs93BuJxRk1WPkzLyhqKqCJBIajhs20 4P5HYXaDJhQBbRbxe6K0o6qVMueUu82JuuS1tv1BlQfZaZ4y+bSiTGQbdLr9PFCl5KAp/WmmL7ynk TF2w5SQow==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR2yX-002JwP-QA; Tue, 30 Mar 2021 01:15:22 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lR0GW-001ecf-C2; Mon, 29 Mar 2021 22:21:48 +0000 Received: by mail-ej1-x62b.google.com with SMTP id b7so21819549ejv.1; Mon, 29 Mar 2021 15:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dRhm46fv/CqnkUkyrWxeHSP37MaaFXnAoj+y1DNtN2Y=; b=eXnfqJl1qFLQeJZK7a51+ogFSQiWCPIvWWPdoOkG2H4KyQjJ5b3RzF8TOPw+YtSnyf UsXkN6LccYrhgqc0d6wiq0+zL2QjM+iiV2v17BkfyVOZ2YbcQUSANEDqVbaWMG+Cgs4C SDw9l/yxjyKqwK4v4Op07CkxWQ+jmsY/Kq3tDE7Ui61NkL0fv8aFFQEaYvKoQ+qZHPMs /LvGqbgcUvk9qCllf2ZZxkmcbKr37hnkdMZCAyUDP8lIniG41DCBAwFyDNkwf8OSvk96 OgQJqtPexDqSLLNY2+jZx2l2m+kQvAdK0Hd7BMN4ulH8sNtXkQNhgbsji6E/SBTtCDQ8 zOqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dRhm46fv/CqnkUkyrWxeHSP37MaaFXnAoj+y1DNtN2Y=; b=U9YsVQ8muVDyrQUHh/9sxW4OEHZlKAefja4nAeWQ+BtNbGYrLlZsZKpuHUsPRZhsmL by7IHae9nq5TpTZNVdjYIjXohvwbYsJ3n7YVJ+R/7o6jU+dPiDiYMST0evRi7BYQJ7QP b6jgEhEEYEFkUmlYPgy5mMiTDVWB4ENUEGGAEo/JAe58Iy7G/Q5tOjQqaqgKLcWoyLrY 3cWKiYXEqWSIBFNKiveK1nD8epfY309bIif+UmytvUIyDCpwObCljXuCEMGVY71QckV5 VcyXhPsE+GEe7xQr7mqSqWBvSbve15/XFLq8gqYXs/LgwFg/9vjjYjUfOoYGmOEnE8Rv 4PjA== X-Gm-Message-State: AOAM531TDrH7oZyIZjWqnn0M8m/WqcTmDQcOQgWPsn0q0lhocX0d5zJv OueYBvHggMBzraYixlc2RoM= X-Google-Smtp-Source: ABdhPJxPkXZkXl6gT+vge6Qqo83lznr5txu39g6Vu4BfeimfbFhfubouHJu8gD4kK/UKCPInRKLQRQ== X-Received: by 2002:a17:906:701:: with SMTP id y1mr5194908ejb.243.1617056496624; Mon, 29 Mar 2021 15:21:36 -0700 (PDT) Received: from BV030612LT ([188.24.140.160]) by smtp.gmail.com with ESMTPSA id d15sm9797536edx.62.2021.03.29.15.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 15:21:36 -0700 (PDT) Date: Tue, 30 Mar 2021 01:21:33 +0300 From: Cristian Ciocaltea To: Rob Herring Cc: Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: soc: actions: Add Actions Semi Owl socinfo binding Message-ID: <20210329222133.GA1792209@BV030612LT> References: <95105518f61408743d17783099ed9c373a3dfe18.1616178258.git.cristian.ciocaltea@gmail.com> <20210327163006.GA185779@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210327163006.GA185779@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_232146_155783_E1EC5FBF X-CRM114-Status: GOOD ( 20.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 27, 2021 at 10:30:06AM -0600, Rob Herring wrote: > On Fri, Mar 19, 2021 at 08:27:59PM +0200, Cristian Ciocaltea wrote: > > Add devicetree binding for the Actions Semi Owl SoCs info module. > > > > Signed-off-by: Cristian Ciocaltea > > --- > > .../bindings/soc/actions/owl-socinfo.yaml | 71 +++++++++++++++++++ [...] > > + > > +patternProperties: > > + "^soc(@[0-9a-f]+)?$": > > Make this a $nodename property. > > > + type: object > > + properties: > > And move this up to top-level. > > You need a custom 'select' entry to exclude 'simple-bus'. Indeed, I missed it.. > > + compatible: > > + items: > > + - enum: > > + - actions,s500-soc > > + - actions,s700-soc > > + - actions,s900-soc > > + - const: simple-bus > > + > > + "#address-cells": > > + enum: [1, 2] > > + > > + "#size-cells": > > + enum: [1, 2] > > + > > + ranges: true > > + > > + actions,serial-number-addrs: > > + description: | > > + Contains the physical addresses in DDR memory where the two parts > > + of the serial number (low & high) can be read from. > > + This is currently supported only on the S500 SoC variant. > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 2 > > + maxItems: 2 > > Humm, it doesn't really seem you have an actual device or bus here, but > are abusing DT to create your socinfo device. > > As the only property is data in main memory, you should do a compatible > for that memory region and put it under reserved-memory. You need that > anyway to prevent the kernel from using the memory, right? Right, this region should be exposed as reserved-memory. Will handle it in the next revision. > Rob Thanks for the review, Cristi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel