From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44905C433E3 for ; Tue, 30 Mar 2021 04:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10E6F619A9 for ; Tue, 30 Mar 2021 04:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230399AbhC3E6y (ORCPT ); Tue, 30 Mar 2021 00:58:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34772 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbhC3E63 (ORCPT ); Tue, 30 Mar 2021 00:58:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617080308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z8HXE+SRs1I1Gy1V62mRGhXG03GWa3sG5/VRWwRaeXI=; b=WxWftcqI3z2icKWpFZ4haweGfSaQy57jPQfnzzq+j6ix0YfYjLC9NHb+8SB06Ku0La3RzR ny7oAjlysPrtEu9/H/RwJr/Ic7SgW/ivYeMJvnruuRF3RC9dIywOS0uhAJDw0kYBQGVxLF ZsCAneggsyjzEPNJHzAaUF3zgL+/TBQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-scz5m0e-P8GsRK6xx4D05Q-1; Tue, 30 Mar 2021 00:58:23 -0400 X-MC-Unique: scz5m0e-P8GsRK6xx4D05Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB33481622; Tue, 30 Mar 2021 04:58:21 +0000 (UTC) Received: from treble (ovpn-112-70.rdu2.redhat.com [10.10.112.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9EE839A66; Tue, 30 Mar 2021 04:58:18 +0000 (UTC) Date: Mon, 29 Mar 2021 23:58:15 -0500 From: Josh Poimboeuf To: Steven Rostedt Cc: Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, tglx@linutronix.de, kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Masahiro Yamada Subject: Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline Message-ID: <20210330045815.boogfo65is5yywnn@treble> References: <161639518354.895304.15627519393073806809.stgit@devnote2> <161639530062.895304.16962383429668412873.stgit@devnote2> <20210323223007.GG4746@worktop.programming.kicks-ass.net> <20210324104058.7c06aaeb0408e24db6ba46f8@kernel.org> <20210326030503.7fa72da34e25ad35cf5ed3de@kernel.org> <20210326210349.22f6d34b229dd3a139a53686@kernel.org> <20210326102009.265f359c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210326102009.265f359c@gandalf.local.home> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 10:20:09AM -0400, Steven Rostedt wrote: > On Fri, 26 Mar 2021 21:03:49 +0900 > Masami Hiramatsu wrote: > > > I confirmed this is not related to this series, but occurs when I build kernels with different > > configs without cleanup. > > > > Once I build kernel with CONFIG_UNWIND_GUESS=y (for testing), and after that, > > I build kernel again with CONFIG_UNWIND_ORC=y (but without make clean), this > > happened. In this case, I guess ORC data might be corrupted? > > When I cleanup and rebuild, the stacktrace seems correct. > > Hmm, that should be fixed. Seems like we are missing a dependency somewhere. Thomas reported something similar: for example arch/x86/kernel/head_64.o doesn't get rebuilt when changing unwinders. https://lkml.kernel.org/r/87tuqublrb.fsf@nanos.tec.linutronix.de Masahiro, any idea how we can force a full tree rebuild when changing the unwinder? -- Josh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Poimboeuf Date: Tue, 30 Mar 2021 04:58:15 +0000 Subject: Re: [PATCH -tip v4 10/12] x86/kprobes: Push a fake return address at kretprobe_trampoline Message-Id: <20210330045815.boogfo65is5yywnn@treble> List-Id: References: <161639518354.895304.15627519393073806809.stgit@devnote2> <161639530062.895304.16962383429668412873.stgit@devnote2> <20210323223007.GG4746@worktop.programming.kicks-ass.net> <20210324104058.7c06aaeb0408e24db6ba46f8@kernel.org> <20210326030503.7fa72da34e25ad35cf5ed3de@kernel.org> <20210326210349.22f6d34b229dd3a139a53686@kernel.org> <20210326102009.265f359c@gandalf.local.home> In-Reply-To: <20210326102009.265f359c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt Cc: Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, tglx@linutronix.de, kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Masahiro Yamada On Fri, Mar 26, 2021 at 10:20:09AM -0400, Steven Rostedt wrote: > On Fri, 26 Mar 2021 21:03:49 +0900 > Masami Hiramatsu wrote: > > > I confirmed this is not related to this series, but occurs when I build kernels with different > > configs without cleanup. > > > > Once I build kernel with CONFIG_UNWIND_GUESS=y (for testing), and after that, > > I build kernel again with CONFIG_UNWIND_ORC=y (but without make clean), this > > happened. In this case, I guess ORC data might be corrupted? > > When I cleanup and rebuild, the stacktrace seems correct. > > Hmm, that should be fixed. Seems like we are missing a dependency somewhere. Thomas reported something similar: for example arch/x86/kernel/head_64.o doesn't get rebuilt when changing unwinders. https://lkml.kernel.org/r/87tuqublrb.fsf@nanos.tec.linutronix.de Masahiro, any idea how we can force a full tree rebuild when changing the unwinder? -- Josh