All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: x86@kernel.org, Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI: processor: Fix build when !CONFIG_HOTPLUG_CPU
Date: Tue, 30 Mar 2021 12:26:30 +0200	[thread overview]
Message-ID: <20210330102630.264398-1-vkuznets@redhat.com> (raw)

Kernel test robot reports build breakage with commit 5f5e49e999ac
("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()") when
!CONFIG_HOTPLUG_CPU/!CONFIG_SMP. wakeup_cpu0() is defined under
CONFIG_SMP and start_cpu0() under CONFIG_HOTPLUG_CPU which, in its turn,
depend on CONFIG_SMP. Add #ifdef CONFIG_HOTPLUG_CPU to the block, this
should be sufficient.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 5f5e49e999ac ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/acpi/processor_idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index f0c73f658880..0925b1477230 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -539,7 +539,7 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index)
 		} else
 			return -ENODEV;
 
-#ifdef CONFIG_X86
+#if defined(CONFIG_X86) && defined(CONFIG_HOTPLUG_CPU)
 		/* If NMI wants to wake up CPU0, start CPU0. */
 		if (wakeup_cpu0())
 			start_cpu0();
-- 
2.30.2


             reply	other threads:[~2021-03-30 10:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 10:26 Vitaly Kuznetsov [this message]
2021-03-30 19:50 ` [PATCH] ACPI: processor: Fix build when !CONFIG_HOTPLUG_CPU Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210330102630.264398-1-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.