All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI/VPD: Silence warning if optional VPD PROM is missing
Date: Tue, 30 Mar 2021 14:56:11 -0500	[thread overview]
Message-ID: <20210330195611.GA1305306@bjorn-Precision-5520> (raw)
In-Reply-To: <87b23db1-a177-190e-a792-eef621a78597@gmail.com>

On Sun, Mar 07, 2021 at 10:34:25PM +0100, Heiner Kallweit wrote:
> On 07.03.2021 19:27, Krzysztof Wilczyński wrote:
> > Hi Heiner,
> > 
> >> Realtek RTL8169/8168/8125 NIC families indicate VPD capability and an
> >> optional VPD EEPROM can be connected via I2C/SPI. However I haven't
> >> seen any card or system with such a VPD EEPROM yet. The missing EEPROM
> >> causes the following warning whenever e.g. lscpi -vv is executed.
> >>
> >> invalid short VPD tag 00 at offset 01
> >>
> >> The warning confuses users, I think we should handle the situation more
> >> gentle. Therefore, if first VPD byte is read as 0x00, assume a missing
> >> optional VPD PROM as and silently set the VPD length to 0.
> > [...]
> > 
> > True.  I saw people on different forum and IRC asking for clarification
> > assuming their NIC broke, or that something is wrong, so this would
> > indeed save them some worry, nice!
> > 
> > Having said that, I also saw this particular warning showing up for some
> > storage controllers (often some SAS cards), so a question here: would it
> > warrant adding a pci_dbg() with an appropriate message rather than just
> > returning 0?  I wonder if this might be useful for someone who is trying
> > to troubleshoot and/or debug some issues with their device.
> > 
> > What do you think?
> > 
> I don't have a strong opinion here, but yes, that's something we could do.

How about if we just downgrade the pci_warn() to a pci_info()?

  reply	other threads:[~2021-03-30 19:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 20:43 [PATCH] PCI/VPD: Silence warning if optional VPD PROM is missing Heiner Kallweit
2021-03-07 18:27 ` Krzysztof Wilczyński
2021-03-07 21:34   ` Heiner Kallweit
2021-03-30 19:56     ` Bjorn Helgaas [this message]
2021-03-31 11:14       ` Heiner Kallweit
2021-04-01 12:04         ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210330195611.GA1305306@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.