From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8488BC433E0 for ; Wed, 31 Mar 2021 07:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 413FC619B9 for ; Wed, 31 Mar 2021 07:43:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233982AbhCaHnG (ORCPT ); Wed, 31 Mar 2021 03:43:06 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:45750 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234282AbhCaHmg (ORCPT ); Wed, 31 Mar 2021 03:42:36 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id DD27B20571; Wed, 31 Mar 2021 09:42:34 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AejTVs5M9keI; Wed, 31 Mar 2021 09:42:31 +0200 (CEST) Received: from cas-essen-02.secunet.de (unknown [10.53.40.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 4728320561; Wed, 31 Mar 2021 09:42:31 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-02.secunet.de (10.53.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 31 Mar 2021 09:42:31 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 31 Mar 2021 09:42:30 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 9861E31804DE; Wed, 31 Mar 2021 09:42:30 +0200 (CEST) Date: Wed, 31 Mar 2021 09:42:30 +0200 From: Steffen Klassert To: Dmitry Safonov CC: , Dmitry Safonov <0x7f454c46@gmail.com>, , "David S. Miller" , Eric Dumazet , Herbert Xu , Jakub Kicinski , , Subject: Re: [PATCH] xfrm/compat: Cleanup WARN()s that can be user-triggered Message-ID: <20210331074230.GE62598@gauss3.secunet.de> References: <20210329232506.232142-1-dima@arista.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210329232506.232142-1-dima@arista.com> X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 12:25:06AM +0100, Dmitry Safonov wrote: > Replace WARN_ONCE() that can be triggered from userspace with > pr_warn_once(). Those still give user a hint what's the issue. > > I've left WARN()s that are not possible to trigger with current > code-base and that would mean that the code has issues: > - relying on current compat_msg_min[type] <= xfrm_msg_min[type] > - expected 4-byte padding size difference between > compat_msg_min[type] and xfrm_msg_min[type] > - compat_policy[type].len <= xfrma_policy[type].len > (for every type) > > Reported-by: syzbot+834ffd1afc7212eb8147@syzkaller.appspotmail.com > Fixes: 5f3eea6b7e8f ("xfrm/compat: Attach xfrm dumps to 64=>32 bit translator") > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Herbert Xu > Cc: Jakub Kicinski > Cc: Steffen Klassert > Cc: netdev@vger.kernel.org > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Safonov Applied, thanks Dmitry!