From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14177C433DB for ; Wed, 31 Mar 2021 09:37:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4AD061874 for ; Wed, 31 Mar 2021 09:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234539AbhCaJge (ORCPT ); Wed, 31 Mar 2021 05:36:34 -0400 Received: from foss.arm.com ([217.140.110.172]:36446 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234648AbhCaJgN (ORCPT ); Wed, 31 Mar 2021 05:36:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA7D4D6E; Wed, 31 Mar 2021 02:36:12 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 71AFC3F792; Wed, 31 Mar 2021 02:36:11 -0700 (PDT) Date: Wed, 31 Mar 2021 10:35:55 +0100 From: Lorenzo Pieralisi To: Bjorn Helgaas Cc: Dejin Zheng , toan@os.amperecomputing.com, robh@kernel.org, bhelgaas@google.com, gustavo.pimentel@synopsys.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dann.frazier@canonical.com Subject: Re: [PATCH] PCI: xgene: fix a mistake about cfg address Message-ID: <20210331093534.GA10056@lpieralisi> References: <20210328144118.305074-1-zhengdejin5@gmail.com> <20210330191926.GA1297928@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330191926.GA1297928@bjorn-Precision-5520> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 02:19:26PM -0500, Bjorn Helgaas wrote: > On Sun, Mar 28, 2021 at 10:41:18PM +0800, Dejin Zheng wrote: > > It has a wrong modification to the xgene driver by the commit > > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > > simplify codes and remove the res variable, But the following code > > needs to use this res variable, So after this commit, the port->cfg_addr > > will get a wrong address. Now, revert it. > > > > Fixes: e2dcd20b1645a ("PCI: controller: Convert to devm_platform_ioremap_resource_byname()") > > Reported-by: dann.frazier@canonical.com > > Signed-off-by: Dejin Zheng > > This looks right to me, but since e2dcd20b1645a appeared in v5.9-rc1, > I think it should have: > > Cc: stable@vger.kernel.org # v5.9+ Fixed and pushed out in my pci/xgene branch. Thanks, Lorenzo