From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA45C433ED for ; Wed, 31 Mar 2021 19:40:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E812361057 for ; Wed, 31 Mar 2021 19:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236029AbhCaTkO (ORCPT ); Wed, 31 Mar 2021 15:40:14 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35950 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235186AbhCaTjl (ORCPT ); Wed, 31 Mar 2021 15:39:41 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12VJdYhR009466; Wed, 31 Mar 2021 14:39:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617219574; bh=JMXn/JkBTuk+5TH5Q0BPZDISnz8/5kVGLPfZTOAxY3k=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=IXn2U2c8UwCGSDhUWbZ2zUPXXpkgVTIB3ddWx/RFxGQjNw1ZzQYBP9O/BMxsFBq9j yvajCrj8rG8hKbmMvyMFZ48aevdgm6OZE9BhMaT4kuyw9dhKI2pl3Z/DBExk8GoVUm qswl6FX+b+Trrqc5Zh2Sj+2Rr1RyabqP+DcN1GfE= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12VJdYcN119377 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Mar 2021 14:39:34 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 31 Mar 2021 14:39:34 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 31 Mar 2021 14:39:34 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12VJdXDL014920; Wed, 31 Mar 2021 14:39:33 -0500 Date: Thu, 1 Apr 2021 01:09:32 +0530 From: Pratyush Yadav To: Mark Brown CC: Rob Herring , Nishanth Menon , Tero Kristo , , , , , Vignesh Raghavendra Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Message-ID: <20210331193930.tzsvbjup3wpxmh26@ti.com> References: <20210326130034.15231-1-p.yadav@ti.com> <20210326130034.15231-5-p.yadav@ti.com> <20210331191135.GF4758@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210331191135.GF4758@sirena.org.uk> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/21 08:11PM, Mark Brown wrote: > On Fri, Mar 26, 2021 at 06:30:34PM +0530, Pratyush Yadav wrote: > > From: Ramuthevar Vadivel Murugan > > > > There is no way as of now to have a parent or bus defining properties > > for child nodes. For now, avoid it in the example to silence warnings on > > dt_schema_check. We can figure out how to deal with actual dts files > > later. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. I did take a look by running git log on Documentation/devicetree/bindings/spi/ and there is no single style being used. Using "dt-bindings: spi:" is a popular choice. Some other commits just use "spi:". And then some use "spi: dt-bindings:". The last commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix "dt-bindings: spi:". So on the prefix front I think the subject is good enough. Of course, if you have any other preference then it can be re-worded but let's first be clear on what the expectation is. And then let's make sure to apply it to all future patches uniformly. This way future contributors won't have to take a guess on what the expected prefix is. Apart from the prefix is there anything else to improve? IMHO the subject is good enough but I'm open to suggestions. -- Regards, Pratyush Yadav Texas Instruments Inc. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B0FC43460 for ; Wed, 31 Mar 2021 19:41:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E0D16108C for ; Wed, 31 Mar 2021 19:41:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E0D16108C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B+lfo3SX1Dk2ryETXrm+FIT/ionwoI8aVuha5SAqlAU=; b=HLUH/qTivY/PVbOZEye67BtiU 9ovmpBYM7ID9bXa6QX956vJLZs3q4hffD/6j16Lr8dSL9Vz0u2Ffw12MjIsDYSEHRKrBvjpxkgUxG 3Ip0d9hWdfIYiqW7RfZs2yGfUdjcssAVG8VWG9ehp4tFzEZ9IGIRNQE6fdqqiOUTQH/2ELRDrvYOX zIMcUFaubiWpBzsnxTWnqJNCGphvv6XfNi8r/B15qltMbsRImn2rlW/NjTxYfhsAobS+f7P7vEKYE Ljo4RiDKkJ6dSTYXiWeoLmQFu9uez4/SBHIsUIjhhnxd4BJMENzjtZLhB4MGRqt3xVdBEPbY8Al58 ulzPzEN7g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRggo-007OCS-HQ; Wed, 31 Mar 2021 19:39:42 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRggj-007OBh-70 for linux-arm-kernel@lists.infradead.org; Wed, 31 Mar 2021 19:39:40 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12VJdYhR009466; Wed, 31 Mar 2021 14:39:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617219574; bh=JMXn/JkBTuk+5TH5Q0BPZDISnz8/5kVGLPfZTOAxY3k=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=IXn2U2c8UwCGSDhUWbZ2zUPXXpkgVTIB3ddWx/RFxGQjNw1ZzQYBP9O/BMxsFBq9j yvajCrj8rG8hKbmMvyMFZ48aevdgm6OZE9BhMaT4kuyw9dhKI2pl3Z/DBExk8GoVUm qswl6FX+b+Trrqc5Zh2Sj+2Rr1RyabqP+DcN1GfE= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12VJdYcN119377 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Mar 2021 14:39:34 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 31 Mar 2021 14:39:34 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 31 Mar 2021 14:39:34 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12VJdXDL014920; Wed, 31 Mar 2021 14:39:33 -0500 Date: Thu, 1 Apr 2021 01:09:32 +0530 From: Pratyush Yadav To: Mark Brown CC: Rob Herring , Nishanth Menon , Tero Kristo , , , , , Vignesh Raghavendra Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Message-ID: <20210331193930.tzsvbjup3wpxmh26@ti.com> References: <20210326130034.15231-1-p.yadav@ti.com> <20210326130034.15231-5-p.yadav@ti.com> <20210331191135.GF4758@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210331191135.GF4758@sirena.org.uk> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_203937_644621_E23C1CDF X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/03/21 08:11PM, Mark Brown wrote: > On Fri, Mar 26, 2021 at 06:30:34PM +0530, Pratyush Yadav wrote: > > From: Ramuthevar Vadivel Murugan > > > > There is no way as of now to have a parent or bus defining properties > > for child nodes. For now, avoid it in the example to silence warnings on > > dt_schema_check. We can figure out how to deal with actual dts files > > later. > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. I did take a look by running git log on Documentation/devicetree/bindings/spi/ and there is no single style being used. Using "dt-bindings: spi:" is a popular choice. Some other commits just use "spi:". And then some use "spi: dt-bindings:". The last commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix "dt-bindings: spi:". So on the prefix front I think the subject is good enough. Of course, if you have any other preference then it can be re-worded but let's first be clear on what the expectation is. And then let's make sure to apply it to all future patches uniformly. This way future contributors won't have to take a guess on what the expected prefix is. Apart from the prefix is there anything else to improve? IMHO the subject is good enough but I'm open to suggestions. -- Regards, Pratyush Yadav Texas Instruments Inc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel