From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNICODE_OBFU_ASC,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081EAC433ED for ; Thu, 1 Apr 2021 09:05:47 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6092D61055 for ; Thu, 1 Apr 2021 09:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6092D61055 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6137240696; Thu, 1 Apr 2021 11:05:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 014C540142 for ; Thu, 1 Apr 2021 11:05:42 +0200 (CEST) IronPort-SDR: w2d6GVsK7QDKzC/WiFjlZqoTLpEbVkVnvVc85NAADnivoflJ6ds34OJqkFTDYtNzynwbQcptoP GHU4KcOyEgXg== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="212448895" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="212448895" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 02:05:18 -0700 IronPort-SDR: xkPZpZIHopdK2REsgyb2l3/tE54y4TzrRHizIP8M4AnS88XRH9oAlZt78/mh3zcGMiyAYsR7tj naleYD+TC7nA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="610838195" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.222.97]) by fmsmga005.fm.intel.com with ESMTP; 01 Apr 2021 02:05:17 -0700 From: Anatoly Burakov To: dev@dpdk.org Date: Thu, 1 Apr 2021 09:05:16 +0000 Message-Id: <20210401090516.209155-1-anatoly.burakov@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [RFC] devtools: improve DPDK review process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A common problem on the DPDK mailing list is lack of reviewers for patches. This script is intended to help with that problem, by picking a random commit author from our git history, and adding a Reviewed-by: tag. This can be added to e.g. commit-msg git hook, like so: # add reviewer to commit message $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1 Now all DPDK code will definitely be well reviewed! Signed-off-by: Anatoly Burakov Rеviеwеd-by: Thоmas Mоnjаlоn --- devtools/get-reviewer.sh | 4 ++++ 1 file changed, 4 insertions(+) create mode 100755 devtools/get-reviewer.sh diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh new file mode 100755 index 0000000000..f4b07c9862 --- /dev/null +++ b/devtools/get-reviewer.sh @@ -0,0 +1,4 @@ +#!/bin/sh + +# find a reviewer for the code +git log --format="Reviewed-by: %an <%ae>" | sort -u | shuf -n 1 -- 2.25.1