CC: kbuild-all(a)lists.01.org In-Reply-To: <20210401033156.7262-1-johunt@akamai.com> References: <20210401033156.7262-1-johunt@akamai.com> TO: Josh Hunt TO: Ingo Molnar TO: Peter Zijlstra TO: linux-kernel(a)vger.kernel.org CC: Josh Hunt Hi Josh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Josh-Hunt/psi-allow-unprivileged-users-with-CAP_SYS_RESOURCE-to-write-psi-files/20210401-122010 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 0a2b65c03e9b47493e1442bf9c84badc60d9bffb :::::: branch date: 9 hours ago :::::: commit date: 9 hours ago config: um-randconfig-m031-20210401 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: kernel/sched/psi.c:1359 psi_proc_init() warn: proc file '"pressure/io"' is world writable kernel/sched/psi.c:1360 psi_proc_init() warn: proc file '"pressure/memory"' is world writable kernel/sched/psi.c:1361 psi_proc_init() warn: proc file '"pressure/cpu"' is world writable vim +1359 kernel/sched/psi.c eb414681d5a07d Johannes Weiner 2018-10-26 1354 eb414681d5a07d Johannes Weiner 2018-10-26 1355 static int __init psi_proc_init(void) eb414681d5a07d Johannes Weiner 2018-10-26 1356 { 3d817689a62cf7 Wang Long 2019-12-18 1357 if (psi_enable) { eb414681d5a07d Johannes Weiner 2018-10-26 1358 proc_mkdir("pressure", NULL); ee6d71e2ff4d9f Josh Hunt 2021-03-31 @1359 proc_create("pressure/io", 0666, NULL, &psi_io_proc_ops); ee6d71e2ff4d9f Josh Hunt 2021-03-31 @1360 proc_create("pressure/memory", 0666, NULL, &psi_memory_proc_ops); ee6d71e2ff4d9f Josh Hunt 2021-03-31 @1361 proc_create("pressure/cpu", 0666, NULL, &psi_cpu_proc_ops); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org