All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND 1/5] ARM: dts: clps711x: Add SYSCON nodes where it is used
@ 2021-04-02  7:43 ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

This patch adds SYSCON descriptors to framebuffer, SPI, DAI
and modem control GPIO nodes to further rework these drivers
to remove the call to the syscon_regmap_lookup_by_compatible() function.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 365931f8b48d..dacbe0d8e67a 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -108,6 +108,7 @@ fb: fb@800002c0 {
 			compatible = "cirrus,ep7209-fb";
 			reg = <0x800002c0 0xd44>, <0x60000000 0xc000>;
 			clocks = <&clks CLPS711X_CLK_BUS>;
+			syscon = <&syscon1>;
 			status = "disabled";
 		};
 
@@ -147,6 +148,7 @@ spi: spi@80000500 {
 			reg = <0x80000500 0x4>;
 			interrupts = <15>;
 			clocks = <&clks CLPS711X_CLK_SPI>;
+			syscon = <&syscon3>;
 			status = "disabled";
 		};
 
@@ -170,6 +172,7 @@ dai: dai@80002000 {
 			clocks = <&clks CLPS711X_CLK_PLL>;
 			clock-names = "pll";
 			interrupts = <32>;
+			syscon = <&syscon3>;
 			status = "disabled";
 		};
 
@@ -181,6 +184,7 @@ syscon3: syscon@80002200 {
 
 	mctrl: mctrl {
 		compatible = "cirrus,ep7209-mctrl-gpio";
+		gpio,syscon-dev = <&syscon1 0 0>;
 		gpio-controller;
 		#gpio-cells = <2>;
 	};
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 1/5] ARM: dts: clps711x: Add SYSCON nodes where it is used
@ 2021-04-02  7:43 ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

This patch adds SYSCON descriptors to framebuffer, SPI, DAI
and modem control GPIO nodes to further rework these drivers
to remove the call to the syscon_regmap_lookup_by_compatible() function.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 365931f8b48d..dacbe0d8e67a 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -108,6 +108,7 @@ fb: fb@800002c0 {
 			compatible = "cirrus,ep7209-fb";
 			reg = <0x800002c0 0xd44>, <0x60000000 0xc000>;
 			clocks = <&clks CLPS711X_CLK_BUS>;
+			syscon = <&syscon1>;
 			status = "disabled";
 		};
 
@@ -147,6 +148,7 @@ spi: spi@80000500 {
 			reg = <0x80000500 0x4>;
 			interrupts = <15>;
 			clocks = <&clks CLPS711X_CLK_SPI>;
+			syscon = <&syscon3>;
 			status = "disabled";
 		};
 
@@ -170,6 +172,7 @@ dai: dai@80002000 {
 			clocks = <&clks CLPS711X_CLK_PLL>;
 			clock-names = "pll";
 			interrupts = <32>;
+			syscon = <&syscon3>;
 			status = "disabled";
 		};
 
@@ -181,6 +184,7 @@ syscon3: syscon@80002200 {
 
 	mctrl: mctrl {
 		compatible = "cirrus,ep7209-mctrl-gpio";
+		gpio,syscon-dev = <&syscon1 0 0>;
 		gpio-controller;
 		#gpio-cells = <2>;
 	};
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 2/5] ARM: dts: clps711x: Add keypad node
  2021-04-02  7:43 ` Alexander Shiyan
@ 2021-04-02  7:43   ` Alexander Shiyan
  -1 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

This adds missing keypad node to basic clps711x DT.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index dacbe0d8e67a..02606547bdc5 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -182,6 +182,13 @@ syscon3: syscon@80002200 {
 		};
 	};
 
+	keypad: keypad {
+		compatible = "cirrus,ep7209-keypad";
+		interrupts = <16>;
+		syscon = <&syscon1>;
+		status = "disabled";
+	};
+
 	mctrl: mctrl {
 		compatible = "cirrus,ep7209-mctrl-gpio";
 		gpio,syscon-dev = <&syscon1 0 0>;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 2/5] ARM: dts: clps711x: Add keypad node
@ 2021-04-02  7:43   ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

This adds missing keypad node to basic clps711x DT.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index dacbe0d8e67a..02606547bdc5 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -182,6 +182,13 @@ syscon3: syscon@80002200 {
 		};
 	};
 
+	keypad: keypad {
+		compatible = "cirrus,ep7209-keypad";
+		interrupts = <16>;
+		syscon = <&syscon1>;
+		status = "disabled";
+	};
+
 	mctrl: mctrl {
 		compatible = "cirrus,ep7209-mctrl-gpio";
 		gpio,syscon-dev = <&syscon1 0 0>;
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 3/5] ARM: dts: clps711x: Fix serial port names
  2021-04-02  7:43 ` Alexander Shiyan
@ 2021-04-02  7:43   ` Alexander Shiyan
  -1 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

Preferred node name for serial ports is "serial".

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 02606547bdc5..9350497c1805 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -133,7 +133,7 @@ pwm: pwm@80000400 {
 			#pwm-cells = <1>;
 		};
 
-		uart1: uart@80000480 {
+		uart1: serial@80000480 {
 			compatible = "cirrus,ep7209-uart";
 			reg = <0x80000480 0x80>;
 			interrupts = <12 13>;
@@ -157,7 +157,7 @@ syscon2: syscon@80001100 {
 			reg = <0x80001100 0x80>;
 		};
 
-		uart2: uart@80001480 {
+		uart2: serial@80001480 {
 			compatible = "cirrus,ep7209-uart";
 			reg = <0x80001480 0x80>;
 			interrupts = <28 29>;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 3/5] ARM: dts: clps711x: Fix serial port names
@ 2021-04-02  7:43   ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

Preferred node name for serial ports is "serial".

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 02606547bdc5..9350497c1805 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -133,7 +133,7 @@ pwm: pwm@80000400 {
 			#pwm-cells = <1>;
 		};
 
-		uart1: uart@80000480 {
+		uart1: serial@80000480 {
 			compatible = "cirrus,ep7209-uart";
 			reg = <0x80000480 0x80>;
 			interrupts = <12 13>;
@@ -157,7 +157,7 @@ syscon2: syscon@80001100 {
 			reg = <0x80001100 0x80>;
 		};
 
-		uart2: uart@80001480 {
+		uart2: serial@80001480 {
 			compatible = "cirrus,ep7209-uart";
 			reg = <0x80001480 0x80>;
 			interrupts = <28 29>;
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 4/5] ARM: dts: clps711x: edb7211: Add unit-address to memory node
  2021-04-02  7:43 ` Alexander Shiyan
@ 2021-04-02  7:43   ` Alexander Shiyan
  -1 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

The memory node requires a unit-address, add it.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7211-edb7211.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ep7211-edb7211.dts b/arch/arm/boot/dts/ep7211-edb7211.dts
index da076479c8e2..7fb532f227af 100644
--- a/arch/arm/boot/dts/ep7211-edb7211.dts
+++ b/arch/arm/boot/dts/ep7211-edb7211.dts
@@ -7,7 +7,7 @@ / {
 	model = "Cirrus Logic EP7211 Development Board";
 	compatible = "cirrus,edb7211", "cirrus,ep7211", "cirrus,ep7209";
 
-	memory {
+	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xc0000000 0x02000000>;
 	};
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 4/5] ARM: dts: clps711x: edb7211: Add unit-address to memory node
@ 2021-04-02  7:43   ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

The memory node requires a unit-address, add it.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7211-edb7211.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ep7211-edb7211.dts b/arch/arm/boot/dts/ep7211-edb7211.dts
index da076479c8e2..7fb532f227af 100644
--- a/arch/arm/boot/dts/ep7211-edb7211.dts
+++ b/arch/arm/boot/dts/ep7211-edb7211.dts
@@ -7,7 +7,7 @@ / {
 	model = "Cirrus Logic EP7211 Development Board";
 	compatible = "cirrus,edb7211", "cirrus,ep7211", "cirrus,ep7209";
 
-	memory {
+	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xc0000000 0x02000000>;
 	};
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 5/5] ARM: dts: clps711x: Add an empty chosen node to top level DTSI
  2021-04-02  7:43 ` Alexander Shiyan
@ 2021-04-02  7:43   ` Alexander Shiyan
  -1 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

Missing "chosen" node can cause issues when booting a kernel
with a boot-loader that doesn't create a chosen node if this
isn't present in the DTB since the decompressor relies on a
pre-existing chosen node to be available to insert the command
line and merge other ATAGS info.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 9350497c1805..40a277370fd0 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -10,6 +10,8 @@ / {
 	model = "Cirrus Logic EP7209";
 	compatible = "cirrus,ep7209";
 
+	chosen { };
+
 	aliases {
 		gpio0 = &porta;
 		gpio1 = &portb;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH RESEND 5/5] ARM: dts: clps711x: Add an empty chosen node to top level DTSI
@ 2021-04-02  7:43   ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-02  7:43 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Olof Johansson, Rob Herring,
	devicetree, Alexander Shiyan

Missing "chosen" node can cause issues when booting a kernel
with a boot-loader that doesn't create a chosen node if this
isn't present in the DTB since the decompressor relies on a
pre-existing chosen node to be available to insert the command
line and merge other ATAGS info.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 9350497c1805..40a277370fd0 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -10,6 +10,8 @@ / {
 	model = "Cirrus Logic EP7209";
 	compatible = "cirrus,ep7209";
 
+	chosen { };
+
 	aliases {
 		gpio0 = &porta;
 		gpio1 = &portb;
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/5] ARM: dts: clps711x: Add SYSCON nodes where it is used
  2021-04-02  7:43 ` Alexander Shiyan
@ 2021-04-03 11:00   ` Arnd Bergmann
  -1 siblings, 0 replies; 13+ messages in thread
From: Arnd Bergmann @ 2021-04-03 11:00 UTC (permalink / raw)
  To: Alexander Shiyan
  Cc: Linux ARM, Russell King, Olof Johansson, Rob Herring, DTML

On Fri, Apr 2, 2021 at 9:43 AM Alexander Shiyan <shc_work@mail.ru> wrote:
>
> This patch adds SYSCON descriptors to framebuffer, SPI, DAI
> and modem control GPIO nodes to further rework these drivers
> to remove the call to the syscon_regmap_lookup_by_compatible() function.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/boot/dts/ep7209.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)

The patches all look good. Can you resend them to soc@kernel.org
to make them end up in patchwork for me to pick them up into the soc tree?

Thanks,

        Arnd

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH RESEND 1/5] ARM: dts: clps711x: Add SYSCON nodes where it is used
@ 2021-04-03 11:00   ` Arnd Bergmann
  0 siblings, 0 replies; 13+ messages in thread
From: Arnd Bergmann @ 2021-04-03 11:00 UTC (permalink / raw)
  To: Alexander Shiyan
  Cc: Linux ARM, Russell King, Olof Johansson, Rob Herring, DTML

On Fri, Apr 2, 2021 at 9:43 AM Alexander Shiyan <shc_work@mail.ru> wrote:
>
> This patch adds SYSCON descriptors to framebuffer, SPI, DAI
> and modem control GPIO nodes to further rework these drivers
> to remove the call to the syscon_regmap_lookup_by_compatible() function.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  arch/arm/boot/dts/ep7209.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)

The patches all look good. Can you resend them to soc@kernel.org
to make them end up in patchwork for me to pick them up into the soc tree?

Thanks,

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH RESEND 5/5] ARM: dts: clps711x: Add an empty chosen node to top level DTSI
  2021-04-05  5:16 Alexander Shiyan
@ 2021-04-05  5:16 ` Alexander Shiyan
  0 siblings, 0 replies; 13+ messages in thread
From: Alexander Shiyan @ 2021-04-05  5:16 UTC (permalink / raw)
  To: soc; +Cc: Arnd Bergmann, Alexander Shiyan

Missing "chosen" node can cause issues when booting a kernel
with a boot-loader that doesn't create a chosen node if this
isn't present in the DTB since the decompressor relies on a
pre-existing chosen node to be available to insert the command
line and merge other ATAGS info.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boot/dts/ep7209.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/ep7209.dtsi b/arch/arm/boot/dts/ep7209.dtsi
index 9350497c1805..40a277370fd0 100644
--- a/arch/arm/boot/dts/ep7209.dtsi
+++ b/arch/arm/boot/dts/ep7209.dtsi
@@ -10,6 +10,8 @@ / {
 	model = "Cirrus Logic EP7209";
 	compatible = "cirrus,ep7209";
 
+	chosen { };
+
 	aliases {
 		gpio0 = &porta;
 		gpio1 = &portb;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2021-04-05  5:35 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02  7:43 [PATCH RESEND 1/5] ARM: dts: clps711x: Add SYSCON nodes where it is used Alexander Shiyan
2021-04-02  7:43 ` Alexander Shiyan
2021-04-02  7:43 ` [PATCH RESEND 2/5] ARM: dts: clps711x: Add keypad node Alexander Shiyan
2021-04-02  7:43   ` Alexander Shiyan
2021-04-02  7:43 ` [PATCH RESEND 3/5] ARM: dts: clps711x: Fix serial port names Alexander Shiyan
2021-04-02  7:43   ` Alexander Shiyan
2021-04-02  7:43 ` [PATCH RESEND 4/5] ARM: dts: clps711x: edb7211: Add unit-address to memory node Alexander Shiyan
2021-04-02  7:43   ` Alexander Shiyan
2021-04-02  7:43 ` [PATCH RESEND 5/5] ARM: dts: clps711x: Add an empty chosen node to top level DTSI Alexander Shiyan
2021-04-02  7:43   ` Alexander Shiyan
2021-04-03 11:00 ` [PATCH RESEND 1/5] ARM: dts: clps711x: Add SYSCON nodes where it is used Arnd Bergmann
2021-04-03 11:00   ` Arnd Bergmann
2021-04-05  5:16 Alexander Shiyan
2021-04-05  5:16 ` [PATCH RESEND 5/5] ARM: dts: clps711x: Add an empty chosen node to top level DTSI Alexander Shiyan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.