* [PATCH] staging: fbtft: change snprintf() to scnprintf()
@ 2021-04-02 9:05 ` Carlis
0 siblings, 0 replies; 6+ messages in thread
From: Carlis @ 2021-04-02 9:05 UTC (permalink / raw)
To: gregkh, zhangxuezhi1; +Cc: dri-devel, linux-fbdev, linux-kernel, devel
From: Xuezhi Zhang <zhangxuezhi1@yulong.com>
show() must not use snprintf() when formatting the value to
be returned to user space.
Signed-off-by: Xuezhi Zhang <zhangxuezhi1@yulong.com>
---
drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
index 26e52cc2de64..7df92db648d6 100644
--- a/drivers/staging/fbtft/fbtft-sysfs.c
+++ b/drivers/staging/fbtft/fbtft-sysfs.c
@@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device,
struct fb_info *fb_info = dev_get_drvdata(device);
struct fbtft_par *par = fb_info->par;
- return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
+ return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
}
static struct device_attribute debug_device_attr =
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: fbtft: change snprintf() to scnprintf()
@ 2021-04-02 9:05 ` Carlis
0 siblings, 0 replies; 6+ messages in thread
From: Carlis @ 2021-04-02 9:05 UTC (permalink / raw)
To: gregkh, zhangxuezhi1; +Cc: devel, linux-fbdev, linux-kernel, dri-devel
From: Xuezhi Zhang <zhangxuezhi1@yulong.com>
show() must not use snprintf() when formatting the value to
be returned to user space.
Signed-off-by: Xuezhi Zhang <zhangxuezhi1@yulong.com>
---
drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
index 26e52cc2de64..7df92db648d6 100644
--- a/drivers/staging/fbtft/fbtft-sysfs.c
+++ b/drivers/staging/fbtft/fbtft-sysfs.c
@@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device,
struct fb_info *fb_info = dev_get_drvdata(device);
struct fbtft_par *par = fb_info->par;
- return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
+ return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
}
static struct device_attribute debug_device_attr =
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: fbtft: change snprintf() to scnprintf()
@ 2021-04-02 9:05 ` Carlis
0 siblings, 0 replies; 6+ messages in thread
From: Carlis @ 2021-04-02 9:05 UTC (permalink / raw)
To: gregkh, zhangxuezhi1; +Cc: devel, linux-fbdev, linux-kernel, dri-devel
From: Xuezhi Zhang <zhangxuezhi1@yulong.com>
show() must not use snprintf() when formatting the value to
be returned to user space.
Signed-off-by: Xuezhi Zhang <zhangxuezhi1@yulong.com>
---
drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
index 26e52cc2de64..7df92db648d6 100644
--- a/drivers/staging/fbtft/fbtft-sysfs.c
+++ b/drivers/staging/fbtft/fbtft-sysfs.c
@@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device,
struct fb_info *fb_info = dev_get_drvdata(device);
struct fbtft_par *par = fb_info->par;
- return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
+ return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
}
static struct device_attribute debug_device_attr =
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: change snprintf() to scnprintf()
2021-04-02 9:05 ` Carlis
(?)
@ 2021-04-02 9:17 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-04-02 9:17 UTC (permalink / raw)
To: Carlis; +Cc: zhangxuezhi1, devel, linux-fbdev, linux-kernel, dri-devel
On Fri, Apr 02, 2021 at 09:05:01AM +0000, Carlis wrote:
> From: Xuezhi Zhang <zhangxuezhi1@yulong.com>
>
> show() must not use snprintf() when formatting the value to
> be returned to user space.
Why not? The code is just fine as-is.
>
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@yulong.com>
> ---
> drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
> index 26e52cc2de64..7df92db648d6 100644
> --- a/drivers/staging/fbtft/fbtft-sysfs.c
> +++ b/drivers/staging/fbtft/fbtft-sysfs.c
> @@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device,
> struct fb_info *fb_info = dev_get_drvdata(device);
> struct fbtft_par *par = fb_info->par;
>
> - return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
> + return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
If you really want to "fix" this, please just use sysfs_emit(). This
change as-is, does nothing.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: change snprintf() to scnprintf()
@ 2021-04-02 9:17 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-04-02 9:17 UTC (permalink / raw)
To: Carlis; +Cc: devel, zhangxuezhi1, linux-fbdev, dri-devel, linux-kernel
On Fri, Apr 02, 2021 at 09:05:01AM +0000, Carlis wrote:
> From: Xuezhi Zhang <zhangxuezhi1@yulong.com>
>
> show() must not use snprintf() when formatting the value to
> be returned to user space.
Why not? The code is just fine as-is.
>
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@yulong.com>
> ---
> drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
> index 26e52cc2de64..7df92db648d6 100644
> --- a/drivers/staging/fbtft/fbtft-sysfs.c
> +++ b/drivers/staging/fbtft/fbtft-sysfs.c
> @@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device,
> struct fb_info *fb_info = dev_get_drvdata(device);
> struct fbtft_par *par = fb_info->par;
>
> - return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
> + return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
If you really want to "fix" this, please just use sysfs_emit(). This
change as-is, does nothing.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: change snprintf() to scnprintf()
@ 2021-04-02 9:17 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-04-02 9:17 UTC (permalink / raw)
To: Carlis; +Cc: devel, zhangxuezhi1, linux-fbdev, dri-devel, linux-kernel
On Fri, Apr 02, 2021 at 09:05:01AM +0000, Carlis wrote:
> From: Xuezhi Zhang <zhangxuezhi1@yulong.com>
>
> show() must not use snprintf() when formatting the value to
> be returned to user space.
Why not? The code is just fine as-is.
>
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@yulong.com>
> ---
> drivers/staging/fbtft/fbtft-sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
> index 26e52cc2de64..7df92db648d6 100644
> --- a/drivers/staging/fbtft/fbtft-sysfs.c
> +++ b/drivers/staging/fbtft/fbtft-sysfs.c
> @@ -199,7 +199,7 @@ static ssize_t show_debug(struct device *device,
> struct fb_info *fb_info = dev_get_drvdata(device);
> struct fbtft_par *par = fb_info->par;
>
> - return snprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
> + return scnprintf(buf, PAGE_SIZE, "%lu\n", par->debug);
If you really want to "fix" this, please just use sysfs_emit(). This
change as-is, does nothing.
thanks,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-02 9:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 9:05 [PATCH] staging: fbtft: change snprintf() to scnprintf() Carlis
2021-04-02 9:05 ` Carlis
2021-04-02 9:05 ` Carlis
2021-04-02 9:17 ` Greg KH
2021-04-02 9:17 ` Greg KH
2021-04-02 9:17 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.