From: Simon Horman <horms@verge.net.au>
To: Julian Anastasov <ja@ssi.bg>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nf-next] netfilter: ipvs: do not printk on netns creation
Date: Fri, 2 Apr 2021 11:28:43 +0200 [thread overview]
Message-ID: <20210402092843.GB7320@vergenet.net> (raw)
In-Reply-To: <33419d34-c96-4eb5-b633-c73d5bcf4ee@ssi.bg>
On Fri, Apr 02, 2021 at 06:07:23AM +0300, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 30 Mar 2021, Florian Westphal wrote:
>
> > This causes dmesg spew during normal operation, so remove this.
> >
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> Looks good to me, thanks!
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
Reviewed-by: Simon Horman <horms@verge.net.au>
>
> > ---
> > net/netfilter/ipvs/ip_vs_ftp.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
> > index cf925906f59b..ef1f45e43b63 100644
> > --- a/net/netfilter/ipvs/ip_vs_ftp.c
> > +++ b/net/netfilter/ipvs/ip_vs_ftp.c
> > @@ -591,8 +591,6 @@ static int __net_init __ip_vs_ftp_init(struct net *net)
> > ret = register_ip_vs_app_inc(ipvs, app, app->protocol, ports[i]);
> > if (ret)
> > goto err_unreg;
> > - pr_info("%s: loaded support on port[%d] = %u\n",
> > - app->name, i, ports[i]);
> > }
> > return 0;
> >
> > --
> > 2.26.3
>
> Regards
>
> --
> Julian Anastasov <ja@ssi.bg>
>
next prev parent reply other threads:[~2021-04-02 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 6:42 [PATCH nf-next] netfilter: ipvs: do not printk on netns creation Florian Westphal
2021-03-30 6:42 ` Florian Westphal
2021-04-02 3:07 ` Julian Anastasov
2021-04-02 9:28 ` Simon Horman [this message]
2021-04-03 18:17 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402092843.GB7320@vergenet.net \
--to=horms@verge.net.au \
--cc=fw@strlen.de \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.