All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Claudiu.Beznea@microchip.com
Cc: thierry.reding@gmail.com, lee.jones@linaro.org,
	linux-pwm@vger.kernel.org, alexandre.belloni@bootlin.com,
	Ludovic.Desroches@microchip.com, Nicolas.Ferre@microchip.com,
	kernel@pengutronix.de
Subject: Re: [PATCH] pwm: atmel: Free resources only after pwmchip_remove()
Date: Fri, 2 Apr 2021 22:27:43 +0200	[thread overview]
Message-ID: <20210402202743.hvx7dz3iraesfcbs@pengutronix.de> (raw)
In-Reply-To: <34080c7a-71d3-334c-498e-cb65dad9f817@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

On Fri, Apr 02, 2021 at 10:55:14AM +0000, Claudiu.Beznea@microchip.com wrote:
> Hi Uwe,
> 
> On 24.03.2021 21:56, Uwe Kleine-König wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > Before pwmchip_remove() returns the PWM is expected to be functional. So
> > remove the pwmchip before disabling the clock.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>> ---
> 
> Does this need a fixes tag?

Hmm, that would be:

Fixes: 32b16d46e415 ("pwm: atmel-pwm: Add Atmel PWM controller driver")

which is the commit that introduced the driver in 2013.

> Other than this:
> Ack-by: Claudiu Beznea <claudiu.beznea@microchip.com>

You might want to make this "Acked-by:" so that patchwork automatically
picks this up.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-04-02 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24 19:56 [PATCH] pwm: atmel: Free resources only after pwmchip_remove() Uwe Kleine-König
2021-04-02 10:55 ` Claudiu.Beznea
2021-04-02 20:27   ` Uwe Kleine-König [this message]
2021-04-05  7:46     ` Claudiu.Beznea
2021-04-09 12:28 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210402202743.hvx7dz3iraesfcbs@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.