From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0349470 for ; Sat, 3 Apr 2021 07:48:10 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id i18so2953106wrm.5 for ; Sat, 03 Apr 2021 00:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4lpY5m1izQotM0ewusQVcTKKtwLD9dtbUV/NQkwNeL4=; b=YmYRAcqnkO5URm9rIbRF+SV1xi0/eoxRjqqneyoNVgV7Gmqr/2qwfPTnbP4l4S/nu+ rV4qh+xZZM9YH8PVD7Nnt9sVvN4/d1ZT8mG8dIx/y542opZkLvgQCyAWiG7Usoet5KXc GJrgk/oLlSBijwiBse1Ppn7i0Y3rAbFcXrA0XgJd48fe3u2+2vPCtSCbdz+9GtRsIdKI 64BAjzZTVTt/5SEZK/EsfxdKfA+kSMYDdoIKde4qwTeGAf6Ovi/7GVT++8Jn2jO96j4g BnzL8Ny0PRGQC1thiEMfSOwjyG1CC947Tu5YaUzu+jfVjm5rwhuPCiQOPY8S7TGFqgRC 3pGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4lpY5m1izQotM0ewusQVcTKKtwLD9dtbUV/NQkwNeL4=; b=Pg9jMsJkqeGiQpwiT5Weko5AkCBcotDNB9hjp+LAN1wCurLz1aA1eZdozUqmYylI/U aPmrfGu45QifyKE1DcTTSKd3lWOmnP3Dj51z8P98R6ArW/62jB9ZmGLgYFybHkw4uh4u A1JkXi+FxoLoJun7uUursmT3J88FwsmYVPp4wohUpVi7ffTofulIIdYxQAeiy5DbxmcA Fh988KSwdm8ZZJ9ulTnzQ789N1fbeVLUW4l5ZVnhC5BOcuRcqkPJhUI42UZfnkHSvrI9 M4GPCwGVDDT+dJIWm6MeZy3MIgV0ONLbVAn39jSa2ytZaTklYD9sWLx4g/zFy5ViwoDJ IQiA== X-Gm-Message-State: AOAM530R4y9rZOKt4NIf0cmT9rrb7vavWfcFJ88GJaEmZ9q0AnrYgq1X 7KotcT8KJBCkK/PTAdjcknQ= X-Google-Smtp-Source: ABdhPJwiAwsa7XwNFRUPdxjlgRcmq0VvwRYZuAb7wTIB0ElsuLkkNLyDzJOBbhc04/bVhe4jYL6WMA== X-Received: by 2002:adf:e4c7:: with SMTP id v7mr19128293wrm.245.1617436089480; Sat, 03 Apr 2021 00:48:09 -0700 (PDT) Received: from agape.jhs ([5.171.72.64]) by smtp.gmail.com with ESMTPSA id e23sm1042092wmk.15.2021.04.03.00.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 00:48:09 -0700 (PDT) Date: Sat, 3 Apr 2021 09:48:06 +0200 From: Fabio Aiuto To: Greg KH Cc: dan.carpenter@oracle.com, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/30] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c Message-ID: <20210403074805.GB1563@agape.jhs> References: <34b6f0b80cd3913722b258e9554dbc77268fb2bf.1617384172.git.fabioaiuto83@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Sat, Apr 03, 2021 at 09:40:08AM +0200, Greg KH wrote: > On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > > remove all RT_TRACE logs > > > > I don't mean to be a pain, but this changelog text needs some work. > > This says _what_ it does, but not _why_ you are doing this. The kernel > documentation has a section on how to write a good changelog text, you > might want to look at that. you are right, I spent time writing the cover, but not the changelog which will remain in kernel history > > For this type of series, this could be as simple as: > Remove all of the RT_TRACE_LOGs in the rtx_xmit.c file as they > currently do nothing as they require the code to be modified by > hand in order to be turned on. This obviously has not happened > since the code was merged, so just remove them as they are > unused. > > > Or something like that. > > Most of the time, writing the changelog can take more work than the > actual code change itself, but it's important as we need to know what is > happening both for the reviewers, as well as people in the future who > might have to look back and try to understand the reason for specific > changes. > > Can you fix up this series based on this and resend? > > thanks, > > greg k-h Thank you Greg, I will do and resend it. fabio