From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294C6C433ED for ; Sat, 3 Apr 2021 13:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 006F461003 for ; Sat, 3 Apr 2021 13:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236737AbhDCND0 (ORCPT ); Sat, 3 Apr 2021 09:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbhDCNDY (ORCPT ); Sat, 3 Apr 2021 09:03:24 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 122DBC0613E6; Sat, 3 Apr 2021 06:03:22 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id r12so10722880ejr.5; Sat, 03 Apr 2021 06:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=veRpL9tBr0pNWw7yRlNqrHJnx67HGYjm6FOr/5mrA9Q=; b=ldkBwfZohSu2YLTPvfeMp4b2V4WFRBfhaBuYVITZzzsiQee+bo4nvWZFpyctuCUg+b rL1H2+DLMtSG2nXxGRMY6j95UkINMaTI3stsNqortErMlK+Ht1x6u4Bd92XNC5K1RkWG Hlot0wR7Lf3o87bg8E/TIXYFDq9kOgzYTsJeLf9bBmYmebCNLrcRigh5CWu+wrZPVG+k ZZdOtBl/JRN13AcFytZQPL/hV9ZCBbHyEVf3rS3OHxhgsGMjJqnffmR0TEWnLX+ea4r5 9CxqpjfvZII5g3t+XExhSHyjCcOVKVWKSSfNYFVyShlpaQiZqChV7GclQor3QdW7jm0V rN+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=veRpL9tBr0pNWw7yRlNqrHJnx67HGYjm6FOr/5mrA9Q=; b=KpJPD0fPJGEz1u7xy1FEYCqCZWtjQjVk/WnF6Em8GUynyI63toHym3hW0q1JrTYqX4 h+MVOaYKRdmAc9feRJJ2ov4F5h/1bVxhCaiwSpQNc7ezYZAruYVdpvPsCvpcAzkDRhST EmVq2uzJ27BsIPJkH/lhpq2vvS9/eKJIey4OhUDHjPZOIOAyAe5pDcrKpWxi6Q+8DXjH /6UrB5McwaBT+TIrbCHqH/NVLQZQoCl7U1pmXYWRktjnfSxyTRa2zCfyQuZT0/0MF6e/ kPYeC3ihSsNvoCctW5TU2ple4jwxetbjOG5zYIVmV75alRMAcgMsMksgrwPegD8hxpBF zLHA== X-Gm-Message-State: AOAM533Njj64OKhYREK4RDtij10jCi6/v/5LwGeRE0QDCgbWx2YDU/cJ drjEqQyj3M5GwQWI9V7nThA= X-Google-Smtp-Source: ABdhPJwRTg/uNesR+yk1lrDveX1KcjTfNamVbpJvpSD7aa0tlnOgIBu2ews+mS2XUvfuqUJwjbHU2A== X-Received: by 2002:a17:906:4e91:: with SMTP id v17mr18749152eju.331.1617455000535; Sat, 03 Apr 2021 06:03:20 -0700 (PDT) Received: from skbuf (5-12-16-165.residential.rdsnet.ro. [5.12.16.165]) by smtp.gmail.com with ESMTPSA id q25sm7097778edt.51.2021.04.03.06.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 06:03:20 -0700 (PDT) Date: Sat, 3 Apr 2021 16:03:18 +0300 From: Vladimir Oltean To: Oleksij Rempel Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Russell King , Pengutronix Kernel Team , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH net-next v1 2/9] net: dsa: tag_ar9331: detect IGMP and MLD packets Message-ID: <20210403130318.lqkd6id7gehg3bin@skbuf> References: <20210403114848.30528-1-o.rempel@pengutronix.de> <20210403114848.30528-3-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210403114848.30528-3-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oleksij, On Sat, Apr 03, 2021 at 01:48:41PM +0200, Oleksij Rempel wrote: > The ar9331 switch is not forwarding IGMP and MLD packets if IGMP > snooping is enabled. This patch is trying to mimic the HW heuristic to take > same decisions as this switch would do to be able to tell the linux > bridge if some packet was prabably forwarded or not. > > Signed-off-by: Oleksij Rempel > --- I am not familiar with IGMP/MLD, therefore I don't really understand what problem you are trying to solve. Your switch has packet traps for IGMP and MLD, ok. So it doesn't forward them. Must the IGMP/MLD packets be forwarded by an IGMP/MLD snooping bridge? Which ones and under what circumstances?