From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1381C43461 for ; Mon, 5 Apr 2021 08:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB6B46113E for ; Mon, 5 Apr 2021 08:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232525AbhDEIed (ORCPT ); Mon, 5 Apr 2021 04:34:33 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:51756 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232236AbhDEIec (ORCPT ); Mon, 5 Apr 2021 04:34:32 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1358YIgH001353; Mon, 5 Apr 2021 03:34:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617611658; bh=vjydxmGku5rf0yRyw4g2LgzWuCMb6BltUJU8Anl8Yps=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=sRjWJoZV6zqsAUMUpu9bxu30imuYFpf/WQ4x1BbHoCCkGAEvbOgbBHgOSD1f6gP68 wQ4yc9eP+zHaxCOIX4PqzhbcBXOOnZM1jcHexmYJ/b63ktO5bU8DDuJPlXeLqnaLnH w20rVGg1pEOPfGDWtzCxB+IYN9SE+Xhk3OIf1RU4= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1358YIO5059945 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Apr 2021 03:34:18 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 5 Apr 2021 03:34:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 5 Apr 2021 03:34:18 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1358YHjH007138; Mon, 5 Apr 2021 03:34:18 -0500 Date: Mon, 5 Apr 2021 14:04:17 +0530 From: Pratyush Yadav To: Mark Brown CC: Rob Herring , Nishanth Menon , Tero Kristo , , , , , Vignesh Raghavendra Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Message-ID: <20210405083415.x6azwdzanvsbiljn@ti.com> References: <20210331193930.tzsvbjup3wpxmh26@ti.com> <20210401141328.GH4758@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210401141328.GH4758@sirena.org.uk> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/21 03:13PM, Mark Brown wrote: > On Thu, Apr 01, 2021 at 01:09:32AM +0530, Pratyush Yadav wrote: > > > I did take a look by running git log on > > Documentation/devicetree/bindings/spi/ and there is no single style > > being used. Using "dt-bindings: spi:" is a popular choice. Some other > > commits just use "spi:". And then some use "spi: dt-bindings:". The last > > commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix > > "dt-bindings: spi:". > > Yes, lots of people pick unfortunate subject lines for DT patches - that > doesn't mean it's good. I'm looking to see spi: same as for all other > SPI patches. All right. "spi: dt-bindings:" it is from now on. > > > So on the prefix front I think the subject is good enough. Of course, if > > you have any other preference then it can be re-worded but let's first > > be clear on what the expectation is. And then let's make sure to apply > > it to all future patches uniformly. This way future contributors won't > > have to take a guess on what the expected prefix is. > > I do edit some percentage of patches, but some do slip through for > various reasons. There's also some things that just get completely > missed, especially if there isn't also a code patch nearby. > > > Apart from the prefix is there anything else to improve? IMHO the > > subject is good enough but I'm open to suggestions. > > There was the thing with constraints. Will send a follow up patch to add the constraints that Vignesh suggested. -- Regards, Pratyush Yadav Texas Instruments Inc. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0316AC433ED for ; Mon, 5 Apr 2021 08:36:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 854456138A for ; Mon, 5 Apr 2021 08:36:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 854456138A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uVwrV1cp+2UcZu0hKeSoBAONgYfGQPUd3gB4RPw4YSw=; b=o+f7+sw0pwK5LsX88rOjZBK87 3GDUajzQBJO8c3cAuxO6HP55NqCQj8vatG5fh39T55s11jyUA9XLlQmeXKcVSo2cPsRdiSkxXk5zH UJfQ/xg/TTbSFoKYhwqUqdO7HqEH5RAopERo0uHGL4Hp7SHKB+MkwKgLQeNuUiKjCeeLdkGZlDq8W cOEUg95p4vLrkYVd8DOKAN2K8G8meMOCcLZkrIhiXz+aBZXp1wnOXQQG4HQ5BQPMenjDKaMmQB04x 0iOzWQJL/s1zFPJtdBJC1x52ddnYKQJkFvskHf7xv0W50zGxa/0GEv8A9uFfUm2V4Jn9uhv104Poc SmgVE5GfA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTKgm-00GxrH-T0; Mon, 05 Apr 2021 08:34:29 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTKgi-00GxmN-3Y for linux-arm-kernel@lists.infradead.org; Mon, 05 Apr 2021 08:34:26 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1358YIgH001353; Mon, 5 Apr 2021 03:34:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617611658; bh=vjydxmGku5rf0yRyw4g2LgzWuCMb6BltUJU8Anl8Yps=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=sRjWJoZV6zqsAUMUpu9bxu30imuYFpf/WQ4x1BbHoCCkGAEvbOgbBHgOSD1f6gP68 wQ4yc9eP+zHaxCOIX4PqzhbcBXOOnZM1jcHexmYJ/b63ktO5bU8DDuJPlXeLqnaLnH w20rVGg1pEOPfGDWtzCxB+IYN9SE+Xhk3OIf1RU4= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1358YIO5059945 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Apr 2021 03:34:18 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 5 Apr 2021 03:34:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 5 Apr 2021 03:34:18 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1358YHjH007138; Mon, 5 Apr 2021 03:34:18 -0500 Date: Mon, 5 Apr 2021 14:04:17 +0530 From: Pratyush Yadav To: Mark Brown CC: Rob Herring , Nishanth Menon , Tero Kristo , , , , , Vignesh Raghavendra Subject: Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml Message-ID: <20210405083415.x6azwdzanvsbiljn@ti.com> References: <20210331193930.tzsvbjup3wpxmh26@ti.com> <20210401141328.GH4758@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210401141328.GH4758@sirena.org.uk> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210405_093424_480740_0ABEF024 X-CRM114-Status: GOOD ( 24.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/21 03:13PM, Mark Brown wrote: > On Thu, Apr 01, 2021 at 01:09:32AM +0530, Pratyush Yadav wrote: > > > I did take a look by running git log on > > Documentation/devicetree/bindings/spi/ and there is no single style > > being used. Using "dt-bindings: spi:" is a popular choice. Some other > > commits just use "spi:". And then some use "spi: dt-bindings:". The last > > commit to touch cadence-quadspi.txt (fcebca39938f) used the prefix > > "dt-bindings: spi:". > > Yes, lots of people pick unfortunate subject lines for DT patches - that > doesn't mean it's good. I'm looking to see spi: same as for all other > SPI patches. All right. "spi: dt-bindings:" it is from now on. > > > So on the prefix front I think the subject is good enough. Of course, if > > you have any other preference then it can be re-worded but let's first > > be clear on what the expectation is. And then let's make sure to apply > > it to all future patches uniformly. This way future contributors won't > > have to take a guess on what the expected prefix is. > > I do edit some percentage of patches, but some do slip through for > various reasons. There's also some things that just get completely > missed, especially if there isn't also a code patch nearby. > > > Apart from the prefix is there anything else to improve? IMHO the > > subject is good enough but I'm open to suggestions. > > There was the thing with constraints. Will send a follow up patch to add the constraints that Vignesh suggested. -- Regards, Pratyush Yadav Texas Instruments Inc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel