From: Christian Brauner <christian.brauner@ubuntu.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org,
Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
Subject: Re: [PATCH] net: Allow to specify ifindex when device is moved to another namespace
Date: Mon, 5 Apr 2021 14:15:10 +0200 [thread overview]
Message-ID: <20210405121510.zvfqkuxk56oncaxk@wittgenstein> (raw)
In-Reply-To: <20210405071223.138101-1-avagin@gmail.com>
On Mon, Apr 05, 2021 at 12:12:23AM -0700, Andrei Vagin wrote:
> Currently, we can specify ifindex on link creation. This change allows
> to specify ifindex when a device is moved to another network namespace.
>
> Even now, a device ifindex can be changed if there is another device
> with the same ifindex in the target namespace. So this change doesn't
> introduce completely new behavior, it adds more control to the process.
>
> CRIU users want to restore containers with pre-created network devices.
> A user will provide network devices and instructions where they have to
> be restored, then CRIU will restore network namespaces and move devices
> into them. The problem is that devices have to be restored with the same
> indexes that they have before C/R.
>
> Cc: Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
> Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
> Signed-off-by: Andrei Vagin <avagin@gmail.com>
> ---
LGTM.
Thank for doing this!
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2021-04-05 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 7:36 [PATCH net-next] net: Allow to specify ifindex when device is moved to another namespace Andrei Vagin
2021-04-02 8:17 ` Andrei Vagin
2021-04-02 8:20 ` Christian Brauner
2021-04-02 16:57 ` Andrei Vagin
2021-04-02 8:29 ` [PATCH net-next v2] " Andrei Vagin
2021-04-05 7:12 ` [PATCH] " Andrei Vagin
2021-04-05 12:15 ` Christian Brauner [this message]
2021-04-05 22:10 ` patchwork-bot+netdevbpf
2021-04-05 22:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405121510.zvfqkuxk56oncaxk@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=alexander.mikhalitsyn@virtuozzo.com \
--cc=avagin@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.