From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D5FC433ED for ; Mon, 5 Apr 2021 14:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 206966128D for ; Mon, 5 Apr 2021 14:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241362AbhDEO3m (ORCPT ); Mon, 5 Apr 2021 10:29:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:59348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235915AbhDEO3l (ORCPT ); Mon, 5 Apr 2021 10:29:41 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD75261284; Mon, 5 Apr 2021 14:29:33 +0000 (UTC) Date: Mon, 5 Apr 2021 15:29:49 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: linux-iio@vger.kernel.org, Barry Song , Jonathan Cameron Subject: Re: [PATCH 2/7] iio:adc:exynos-adc: Use new IRQF_NO_AUTOEN flag rather than separate irq_disable() Message-ID: <20210405152949.163a9c20@jic23-huawei> In-Reply-To: References: <20210402184544.488862-1-jic23@kernel.org> <20210402184544.488862-3-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 4 Apr 2021 21:20:21 +0200 Krzysztof Kozlowski wrote: > On 02/04/2021 20:45, Jonathan Cameron wrote: > > From: Jonathan Cameron > > > > Disabling an irq before the driver has actually atempted to request it > > may work, but is definitely not as clean as just requesting it as > > normal but with the auto enable disabled. > > > > Signed-off-by: Jonathan Cameron > > Cc: Krzysztof Kozlowski > > > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof Applied to the togreg branch of iio.git and pushed out as testing to let the autobuilders poke at it. Thanks, Jonathan