Re: [dpdk-dev] [PATCH V2] ethdev: add queue state when retrieve queue information

From: Stephen Hemminger <stephen@networkplumber.org>
To: oulijun <oulijun@huawei.com>
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH V2] ethdev: add queue state when retrieve queue information
Date: Mon, 5 Apr 2021 18:55:10 -0700	[thread overview]
Message-ID: <20210405185510.02ee53fb@hermes.local> (raw)
In-Reply-To: <3dfa2e6b-91b2-da43-a20a-84b8de362fad@huawei.com>

On Tue, 6 Apr 2021 08:49:04 +0800
oulijun <oulijun@huawei.com> wrote:

> >   /**
> > + * RX/TX queue states
> > + */
> > +#define RTE_ETH_QUEUE_STATE_STOPPED 0
> > +#define RTE_ETH_QUEUE_STATE_STARTED 1
> > +#define RTE_ETH_QUEUE_STATE_HAIRPIN 2

These could be an enum?

> > +/**
> >    * Ethernet device RX queue information structure.
> >    * Used to retrieve information about configured queue.
> >    */
> > @@ -1591,6 +1598,8 @@ struct rte_eth_rxq_info {
> >   	uint8_t scattered_rx;       /**< scattered packets RX supported. */

There is a one byte hole here waiting to be used.
Why not use that?

> >   	uint16_t nb_desc;           /**< configured number of RXDs. */
> >   	uint16_t rx_buf_size;       /**< hardware receive buffer size. */
> > +	/**< Queues state: STARTED(1) / STOPPED(0). */
> > +	uint8_t queue_state;
> >   } __rte_cache_min_aligned;