drivers/gpu/drm/nouveau/nouveau_bo.c:1323 nouveau_bo_move_ntfy() warn: should 'new_reg->start << (12)' be a 64 bit type?

drivers/gpu/drm/nouveau/nouveau_bo.c:1323 nouveau_bo_move_ntfy() warn: should 'new_reg->start << (12)' be a 64 bit type?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3994 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Dave Airlie <airlied@redhat.com>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e49d033bddf5b565044e2abe4241353959bc9120
commit: 60e9eabf41fa916d2ef68c5bf929197975917578 Backmerge remote-tracking branch 'drm/drm-next' into drm-misc-next
date:   9 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 9 months ago
config: riscv-randconfig-m031-20210405 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/nouveau/nouveau_bo.c:1323 nouveau_bo_move_ntfy() warn: should 'new_reg->start << (12)' be a 64 bit type?

Old smatch warnings:
drivers/gpu/drm/nouveau/nouveau_bo.c:947 nv50_bo_move_m2mf() warn: should 'new_reg->num_pages << (12)' be a 64 bit type?
drivers/gpu/drm/nouveau/nouveau_bo.c:1337 nouveau_bo_vm_bind() warn: should 'new_reg->start << (12)' be a 64 bit type?

vim +1323 drivers/gpu/drm/nouveau/nouveau_bo.c

6ee738610f41b5 Ben Skeggs     2009-12-11  1296  
a4154bbffdc9f6 Ben Skeggs     2011-02-10  1297  static void
66257db7a5276d Nicolai Hähnle 2016-12-15  1298  nouveau_bo_move_ntfy(struct ttm_buffer_object *bo, bool evict,
605f9ccd7d0ad6 Ben Skeggs     2016-05-17  1299  		     struct ttm_mem_reg *new_reg)
a4154bbffdc9f6 Ben Skeggs     2011-02-10  1300  {
9ce523cc3bf2ac Ben Skeggs     2017-11-01  1301  	struct nouveau_mem *mem = new_reg ? nouveau_mem(new_reg) : NULL;
a4154bbffdc9f6 Ben Skeggs     2011-02-10  1302  	struct nouveau_bo *nvbo = nouveau_bo(bo);
24e8375b1bfdf7 Ben Skeggs     2017-11-01  1303  	struct nouveau_vma *vma;
a4154bbffdc9f6 Ben Skeggs     2011-02-10  1304  
9f1feed2e16652 Ben Skeggs     2012-01-25  1305  	/* ttm can now (stupidly) pass the driver bos it didn't create... */
9f1feed2e16652 Ben Skeggs     2012-01-25  1306  	if (bo->destroy != nouveau_bo_del_ttm)
9f1feed2e16652 Ben Skeggs     2012-01-25  1307  		return;
9f1feed2e16652 Ben Skeggs     2012-01-25  1308  
425b34f7df63a2 Ben Skeggs     2017-11-01  1309  	if (mem && new_reg->mem_type != TTM_PL_SYSTEM &&
9ce523cc3bf2ac Ben Skeggs     2017-11-01  1310  	    mem->mem.page == nvbo->page) {
a48296ab9dbe8b Ben Skeggs     2017-11-01  1311  		list_for_each_entry(vma, &nvbo->vma_list, head) {
24e8375b1bfdf7 Ben Skeggs     2017-11-01  1312  			nouveau_vma_map(vma, mem);
a48296ab9dbe8b Ben Skeggs     2017-11-01  1313  		}
d2f96666c56a50 Ben Skeggs     2011-06-06  1314  	} else {
a48296ab9dbe8b Ben Skeggs     2017-11-01  1315  		list_for_each_entry(vma, &nvbo->vma_list, head) {
10dcab3e7f477b Ben Skeggs     2016-12-12  1316  			WARN_ON(ttm_bo_wait(bo, false, false));
24e8375b1bfdf7 Ben Skeggs     2017-11-01  1317  			nouveau_vma_unmap(vma);
fd2871af3d2dad Ben Skeggs     2011-06-06  1318  		}
a4154bbffdc9f6 Ben Skeggs     2011-02-10  1319  	}
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1320  
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1321  	if (new_reg) {
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1322  		if (new_reg->mm_node)
0dc9b286b8d2c2 Nirmoy Das     2020-06-24 @1323  			nvbo->offset = (new_reg->start << PAGE_SHIFT);
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1324  		else
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1325  			nvbo->offset = 0;
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1326  	}
0dc9b286b8d2c2 Nirmoy Das     2020-06-24  1327  

:::::: The code at line 1323 was first introduced by commit
:::::: 0dc9b286b8d2c219a55f6ad05d144aa4da495e97 drm/nouveau: don't use ttm bo->offset v3

:::::: TO: Nirmoy Das <nirmoy.aiemd@gmail.com>
:::::: CC: Christian König <christian.koenig@amd.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34547 bytes --]