Re: [PATCH] trace-cmd: Add CODING_STYLE and CONTRIBUTE documents

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 7 Apr 2021 06:28:35 +0530
sameeruddin shaik <sameeruddin.shaik8@gmail.com> wrote:

> > +Finally, you can use the git "send-email" functionality:
> > +
> > +  git --send-email --from='<your-email> --to='linux-trace-devel@vger.kernel.org' HEAD~1..HEAD  
> I think, we should add a line about "checking the patch using the 
> checkpatch script, before sending the email", what you say?

I'll add that, although I will say to think of checkpatch as more of a
guide and not a requirement. I find there's a lot of checkpatch fixes
that cause the code to be less readable. But I agree that it is useful for
someone just entering the project.

> 
> Another suggestion is,
> 
> we should document about, how to apply the mailing list patches, which 
> are not yet mainlined. people can search in the internet, but different 
> forums will give different approaches.

And I can give different approaches ;-)  The approach I gave to you with
patchwork may not be the best either. If I do add something here, it will
to use a new tool called "b4".

For example, you can apply this patch with:

 $ b4 am 20210405151959.1d6901b2@gandalf.local.home

Where I used the Message-ID of my email. It also works with series.

Anyway, thanks for the input. This was the reason I included you on this
patch.

-- Steve