From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3980EC433ED for ; Tue, 6 Apr 2021 16:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E54D4613D0 for ; Tue, 6 Apr 2021 16:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346459AbhDFQfH (ORCPT ); Tue, 6 Apr 2021 12:35:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:46232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232063AbhDFQfF (ORCPT ); Tue, 6 Apr 2021 12:35:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 483E0613D0; Tue, 6 Apr 2021 16:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617726896; bh=XdkKx3ghLIT0Ejhdj9Cvusnxkw7C1EMzq4enDuOyDew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g99Ud9NNlNe4tWGftQKH/G14uTrjkg6jlClnqz5hV7Pco+8erWyuxpynms47A7MQb pUTIjQxDsMD4svON52rw9HN0DvKkKduLVZg3ftHmsQlid4m1hBjk0EyKSqu/lR1bh4 cHaFCZ5eecekXeAz2clprhUUypgFOpIu6rGSRMnDjgz1RBA7jX1PY+Cjg8YPGeXAaf IhzBbuYJo54I78mKI0NVk4qFb0BaSGKKoUPJTM+ECW1IFjmgBr6Z8rnp5JG16hxQhl u4K919VPJG8hgQoHxh6TM8B5G3vkwIqwqJ2ZtNFHIr3u6j0j5IGi8wLxogx/mRONes 8R6La/tTfSsWw== Date: Tue, 6 Apr 2021 17:34:39 +0100 From: Mark Brown To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 3/6] PCI: brcmstb: Add control of slot0 device voltage regulators Message-ID: <20210406163439.GL6443@sirena.org.uk> References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-4-jim2101024@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p7S+EREVcBHk3zUG" Content-Disposition: inline In-Reply-To: <20210401212148.47033-4-jim2101024@gmail.com> X-Cookie: BARBARA STANWYCK makes me nervous!! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --p7S+EREVcBHk3zUG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 01, 2021 at 05:21:43PM -0400, Jim Quinlan wrote: > + /* Look for specific pcie regulators in the RC DT node. */ > + for_each_property_of_node(np, pp) { > + for (i = 0; i < ns; i++) > + if (strcmp(supplies[i], pp->name) == 0) This is broken, the driver knows which supplies are expected, the device can't function without these supplies so the driver should just unconditionally request them like any other supply. --p7S+EREVcBHk3zUG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBsjZ4ACgkQJNaLcl1U h9Aq4wf/RJ4KoV5Bjz46S5UVDEaAemzgqsSPUMZKuWSEbCnsPFzhpvHj9aqX2CkG ELR9Fyj9O1r4TKtG3L/RsqiCIJrB6cMBN1n2Ad1Ji5isiZxvzjRJ2trQo/2g3jB5 plVpVy8Ee3qRyfoU6mGu7RrC6vn25wRu0TgMwaf0lge4Wuo9Xi8TGsqmjaIpu5yl SGpp5RmMScIdmc9WiOsjtFmP89K5j9TMmYc2oRRVTVMaav1x7ghnxtsEIX/ecBuk QzSIC5GmwS3BhlAns98kRUYr8s9NhuMsVtCuRT3tuNbLGpQxLOxx/9tymh4Qwxeg PnuEs/O1mzPHMtECWiG8WKiUNlteOA== =fgu8 -----END PGP SIGNATURE----- --p7S+EREVcBHk3zUG-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175E3C433B4 for ; Tue, 6 Apr 2021 16:37:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB714613C0 for ; Tue, 6 Apr 2021 16:36:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB714613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wfp4LeM9CweKKWollrNsv0lp3+O7ypaVEURrpdeg8fQ=; b=F0N4Fam6ODOyrxoGRc/64nV9G e5m/bf2m9PGtJa7N0ZnRAfFWdpX/fubaD2PfrmfbB7+UmNCWDoltJiO9xcXeE/9/8DsfI5Gg0ez9v LcurqtT8MotMYRwZXSt8qnk7PmtuEq0mcLJ6X3R36KruWBeMzw8ro/ChrWXnzL33OdIbG2vALjY8m r1x6C7zsH8CYWyuxSyBlXOkMQjIisgDg5j4+sJK4+k6ufZfv5KSCOW1Yx4MRu4Ma/2eL7KXDqZeqY h25azETpuZwl9SqWUPUPUK8gr16mw5Uq7SnoW/E4sdM9fiLOT/qX8rTxlRil11lhfw6fDRuJ2R4zu KELnmOq7g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lTofP-0030u4-8W; Tue, 06 Apr 2021 16:35:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lTofK-0030tK-CB; Tue, 06 Apr 2021 16:35:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 483E0613D0; Tue, 6 Apr 2021 16:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617726896; bh=XdkKx3ghLIT0Ejhdj9Cvusnxkw7C1EMzq4enDuOyDew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g99Ud9NNlNe4tWGftQKH/G14uTrjkg6jlClnqz5hV7Pco+8erWyuxpynms47A7MQb pUTIjQxDsMD4svON52rw9HN0DvKkKduLVZg3ftHmsQlid4m1hBjk0EyKSqu/lR1bh4 cHaFCZ5eecekXeAz2clprhUUypgFOpIu6rGSRMnDjgz1RBA7jX1PY+Cjg8YPGeXAaf IhzBbuYJo54I78mKI0NVk4qFb0BaSGKKoUPJTM+ECW1IFjmgBr6Z8rnp5JG16hxQhl u4K919VPJG8hgQoHxh6TM8B5G3vkwIqwqJ2ZtNFHIr3u6j0j5IGi8wLxogx/mRONes 8R6La/tTfSsWw== Date: Tue, 6 Apr 2021 17:34:39 +0100 From: Mark Brown To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , Bjorn Helgaas , Florian Fainelli , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v4 3/6] PCI: brcmstb: Add control of slot0 device voltage regulators Message-ID: <20210406163439.GL6443@sirena.org.uk> References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-4-jim2101024@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210401212148.47033-4-jim2101024@gmail.com> X-Cookie: BARBARA STANWYCK makes me nervous!! User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210406_173458_710744_F5F17DE1 X-CRM114-Status: GOOD ( 11.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5256477495627431898==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5256477495627431898== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p7S+EREVcBHk3zUG" Content-Disposition: inline --p7S+EREVcBHk3zUG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 01, 2021 at 05:21:43PM -0400, Jim Quinlan wrote: > + /* Look for specific pcie regulators in the RC DT node. */ > + for_each_property_of_node(np, pp) { > + for (i = 0; i < ns; i++) > + if (strcmp(supplies[i], pp->name) == 0) This is broken, the driver knows which supplies are expected, the device can't function without these supplies so the driver should just unconditionally request them like any other supply. --p7S+EREVcBHk3zUG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBsjZ4ACgkQJNaLcl1U h9Aq4wf/RJ4KoV5Bjz46S5UVDEaAemzgqsSPUMZKuWSEbCnsPFzhpvHj9aqX2CkG ELR9Fyj9O1r4TKtG3L/RsqiCIJrB6cMBN1n2Ad1Ji5isiZxvzjRJ2trQo/2g3jB5 plVpVy8Ee3qRyfoU6mGu7RrC6vn25wRu0TgMwaf0lge4Wuo9Xi8TGsqmjaIpu5yl SGpp5RmMScIdmc9WiOsjtFmP89K5j9TMmYc2oRRVTVMaav1x7ghnxtsEIX/ecBuk QzSIC5GmwS3BhlAns98kRUYr8s9NhuMsVtCuRT3tuNbLGpQxLOxx/9tymh4Qwxeg PnuEs/O1mzPHMtECWiG8WKiUNlteOA== =fgu8 -----END PGP SIGNATURE----- --p7S+EREVcBHk3zUG-- --===============5256477495627431898== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5256477495627431898==--