From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D120C433ED for ; Tue, 6 Apr 2021 16:56:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63B8C613C0 for ; Tue, 6 Apr 2021 16:56:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63B8C613C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.106123.202928 (Exim 4.92) (envelope-from ) id 1lTp03-0005iI-E3; Tue, 06 Apr 2021 16:56:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 106123.202928; Tue, 06 Apr 2021 16:56:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTp03-0005iB-9x; Tue, 06 Apr 2021 16:56:23 +0000 Received: by outflank-mailman (input) for mailman id 106123; Tue, 06 Apr 2021 16:56:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTp01-0005i3-Gz for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 16:56:21 +0000 Received: from mail-wr1-f53.google.com (unknown [209.85.221.53]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3457f296-f13f-4b20-bd38-3e77af45237a; Tue, 06 Apr 2021 16:56:20 +0000 (UTC) Received: by mail-wr1-f53.google.com with SMTP id q26so9288598wrz.9 for ; Tue, 06 Apr 2021 09:56:20 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id f24sm3482764wmb.32.2021.04.06.09.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 09:56:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3457f296-f13f-4b20-bd38-3e77af45237a X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FEAVCo+u2HWRS+XIBEsCGESdrilEgAfIg2k7wEPb9O4=; b=Bw7GH+J7jPqzTJb0fV0mpUoZ0YTUkvCSWQHDyjc7PoUptRg6vVq0JJJwYfPwVvknMa lXppohQm6AZu/zeOmgylm8KcrmnPrnZMdG24VYOENFKNvPGWdehNNL0R9vNV6z/Smvb1 1CQaIabTDoJsnWfeSmSfJScW4+mksuEAcRi8SrcRFOFLYAL0FCjnM4cScH5+lpyK/svE zj57TFjZ1sMqbM8/ftL/wht4jDTV+8uF9sVkekbSwlamy6a/Y5KozXGZp/dMysNXOCSl Ja8HMykgiavrXXxnLA4coeQswWmmYn470s/6JIPelA2vZxi9kjjsk28mTDrb9TxGip61 AABQ== X-Gm-Message-State: AOAM531VWVb0/2gI4WQL6+iaRHz1L9D8XE7aY3rszPU77mNmkwtl5J6z A+F1FSBysWf+9Qxbbt0+StA= X-Google-Smtp-Source: ABdhPJwKe5Uj/kPNaz0TDQkuyj26awWLTLYjxg44GY3l4xzikyi9LrV1wUm/FIojKCjKSsPC0eEoNg== X-Received: by 2002:adf:f143:: with SMTP id y3mr37965915wro.198.1617728180173; Tue, 06 Apr 2021 09:56:20 -0700 (PDT) Date: Tue, 6 Apr 2021 16:56:18 +0000 From: Wei Liu To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 1/3] x86: don't build unused entry code when !PV32 Message-ID: <20210406165618.6vfo4tkqfyyv76sr@liuwe-devbox-debian-v2> References: <213007e3-bb4c-a564-ca1d-860283646be4@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <213007e3-bb4c-a564-ca1d-860283646be4@suse.com> On Tue, Apr 06, 2021 at 04:01:22PM +0200, Jan Beulich wrote: > Except for the initial part of cstar_enter compat/entry.S is all dead > code in this case. Further, along the lines of the PV conditionals we > already have in entry.S, make code PV32-conditional there too (to a > fair part because this code actually references compat/entry.S). > > This has the side effect of moving the tail part (now at compat_syscall) > of the code out of .text.entry (in line with e.g. compat_sysenter). > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu