Hi Zhiqiang,

I love your patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on shawnguo/for-next linux/master linus/master v5.12-rc6 next-20210406]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhiqiang-Hou/PCI-layerscape-Add-power-management-support/20210406-170036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f02bb121acd23cbd941a77d7fb7305c08d6a77b8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhiqiang-Hou/PCI-layerscape-Add-power-management-support/20210406-170036
        git checkout f02bb121acd23cbd941a77d7fb7305c08d6a77b8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/pci/controller/dwc/pci-layerscape.c: In function 'ls_pcie_resume_noirq':
>> drivers/pci/controller/dwc/pci-layerscape.c:504:19: error: 'pp' undeclared (first use in this function); did you mean 'up'?
     504 |  dw_pcie_setup_rc(pp);
         |                   ^~
         |                   up
   drivers/pci/controller/dwc/pci-layerscape.c:504:19: note: each undeclared identifier is reported only once for each function it appears in


vim +504 drivers/pci/controller/dwc/pci-layerscape.c

   490	
   491	static int ls_pcie_resume_noirq(struct device *dev)
   492	{
   493		struct ls_pcie *pcie = dev_get_drvdata(dev);
   494		struct dw_pcie *pci = pcie->pci;
   495		int ret;
   496	
   497		if (!ls_pcie_pm_check(pcie))
   498			return 0;
   499	
   500		ls_pcie_set_dstate(pcie, 0x0);
   501	
   502		pcie->drvdata->pm_ops->exit_from_l2(pcie);
   503	
 > 504		dw_pcie_setup_rc(pp);
   505	
   506		/* delay 10 ms to access EP */
   507		mdelay(10);
   508	
   509		ret = ls_pcie_host_init(&pci->pp);
   510		if (ret) {
   511			dev_err(dev, "ls_pcie_host_init failed! ret = 0x%x\n", ret);
   512			return ret;
   513		}
   514	
   515		ret = dw_pcie_wait_for_link(pci);
   516		if (ret) {
   517			dev_err(dev, "wait link up timeout! ret = 0x%x\n", ret);
   518			return ret;
   519		}
   520	
   521		return 0;
   522	}
   523	#endif /* CONFIG_PM_SLEEP */
   524	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org