From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 2/2] bus: mhi: pm: reduce PM state change verbosity
Date: Wed, 7 Apr 2021 12:20:22 +0530 [thread overview]
Message-ID: <20210407065022.GJ8675@work> (raw)
In-Reply-To: <1617700315-12492-2-git-send-email-loic.poulain@linaro.org>
On Tue, Apr 06, 2021 at 11:11:55AM +0200, Loic Poulain wrote:
> Since M3 can be entered/exited quite a lot when used for runtime PM,
> keep the mhi suspend/resume transitions quiet.
>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: Coding style, adjust alignment of dev_dbg params
>
> drivers/bus/mhi/core/pm.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index edd7794..6cbac21 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -858,7 +858,7 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
> return -EBUSY;
> }
>
> - dev_info(dev, "Allowing M3 transition\n");
> + dev_dbg(dev, "Allowing M3 transition\n");
> new_state = mhi_tryset_pm_state(mhi_cntrl, MHI_PM_M3_ENTER);
> if (new_state != MHI_PM_M3_ENTER) {
> write_unlock_irq(&mhi_cntrl->pm_lock);
> @@ -872,7 +872,7 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
> /* Set MHI to M3 and wait for completion */
> mhi_set_mhi_state(mhi_cntrl, MHI_STATE_M3);
> write_unlock_irq(&mhi_cntrl->pm_lock);
> - dev_info(dev, "Wait for M3 completion\n");
> + dev_dbg(dev, "Wait for M3 completion\n");
>
> ret = wait_event_timeout(mhi_cntrl->state_event,
> mhi_cntrl->dev_state == MHI_STATE_M3 ||
> @@ -906,9 +906,9 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
> enum mhi_pm_state cur_state;
> int ret;
>
> - dev_info(dev, "Entered with PM state: %s, MHI state: %s\n",
> - to_mhi_pm_state_str(mhi_cntrl->pm_state),
> - TO_MHI_STATE_STR(mhi_cntrl->dev_state));
> + dev_dbg(dev, "Entered with PM state: %s, MHI state: %s\n",
> + to_mhi_pm_state_str(mhi_cntrl->pm_state),
> + TO_MHI_STATE_STR(mhi_cntrl->dev_state));
>
> if (mhi_cntrl->pm_state == MHI_PM_DISABLE)
> return 0;
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-04-07 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:11 [PATCH v2 1/2] bus: mhi: core: Fix MHI runtime_pm behavior Loic Poulain
2021-04-06 9:11 ` [PATCH v2 2/2] bus: mhi: pm: reduce PM state change verbosity Loic Poulain
2021-04-07 5:01 ` Manivannan Sadhasivam
2021-04-07 6:50 ` Manivannan Sadhasivam [this message]
2021-04-07 5:05 ` [PATCH v2 1/2] bus: mhi: core: Fix MHI runtime_pm behavior Manivannan Sadhasivam
2021-04-07 6:50 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407065022.GJ8675@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.