All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: linux-kernel@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [igb] netconsole triggers warning in netpoll_poll_dev
Date: Wed, 7 Apr 2021 08:37:48 -0700	[thread overview]
Message-ID: <20210407083748.56b9c261@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210407060053.wyo75mqwcva6w6ci@spock.localdomain>

On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote:
> Thanks for the effort, but reportedly [1] it made no difference,
> unfortunately.
> 
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=212573#c8

The only other option I see is that somehow the NAPI has no rings.

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index a45cd2b416c8..24568adc2fb1 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7980,7 +7980,7 @@ static int igb_poll(struct napi_struct *napi, int budget)
        struct igb_q_vector *q_vector = container_of(napi,
                                                     struct igb_q_vector,
                                                     napi);
-       bool clean_complete = true;
+       bool clean_complete = q_vector->tx.ring || q_vector->rx.ring;
        int work_done = 0;
 
 #ifdef CONFIG_IGB_DCA

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [igb] netconsole triggers warning in netpoll_poll_dev
Date: Wed, 7 Apr 2021 08:37:48 -0700	[thread overview]
Message-ID: <20210407083748.56b9c261@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210407060053.wyo75mqwcva6w6ci@spock.localdomain>

On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote:
> Thanks for the effort, but reportedly [1] it made no difference,
> unfortunately.
> 
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=212573#c8

The only other option I see is that somehow the NAPI has no rings.

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index a45cd2b416c8..24568adc2fb1 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7980,7 +7980,7 @@ static int igb_poll(struct napi_struct *napi, int budget)
        struct igb_q_vector *q_vector = container_of(napi,
                                                     struct igb_q_vector,
                                                     napi);
-       bool clean_complete = true;
+       bool clean_complete = q_vector->tx.ring || q_vector->rx.ring;
        int work_done = 0;
 
 #ifdef CONFIG_IGB_DCA

  reply	other threads:[~2021-04-07 15:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 12:36 [igb] netconsole triggers warning in netpoll_poll_dev Oleksandr Natalenko
2021-04-06 12:36 ` [Intel-wired-lan] " Oleksandr Natalenko
2021-04-06 18:48 ` Jakub Kicinski
2021-04-06 18:48   ` [Intel-wired-lan] " Jakub Kicinski
2021-04-07  6:00   ` Oleksandr Natalenko
2021-04-07  6:00     ` [Intel-wired-lan] " Oleksandr Natalenko
2021-04-07 15:37     ` Jakub Kicinski [this message]
2021-04-07 15:37       ` Jakub Kicinski
2021-04-07 16:25       ` Alexander Duyck
2021-04-07 16:25         ` [Intel-wired-lan] " Alexander Duyck
2021-04-07 18:07         ` Jakub Kicinski
2021-04-07 18:07           ` [Intel-wired-lan] " Jakub Kicinski
2021-04-07 23:06           ` Alexander Duyck
2021-04-07 23:06             ` [Intel-wired-lan] " Alexander Duyck
2021-04-23  8:19             ` Oleksandr Natalenko
2021-04-23  8:19               ` [Intel-wired-lan] " Oleksandr Natalenko
2021-04-23 22:58               ` Jakub Kicinski
2021-04-23 22:58                 ` [Intel-wired-lan] " Jakub Kicinski
2021-04-26  6:47                 ` Oleksandr Natalenko
2021-04-26  6:47                   ` [Intel-wired-lan] " Oleksandr Natalenko
2021-04-26 15:28                   ` Alexander Duyck
2021-04-26 15:28                     ` [Intel-wired-lan] " Alexander Duyck
2021-05-06 23:32                     ` Jesse Brandeburg
2021-05-06 23:32                       ` [Intel-wired-lan] " Jesse Brandeburg
2021-05-07  0:38                       ` Alexander Duyck
2021-05-07  0:38                         ` [Intel-wired-lan] " Alexander Duyck
2021-11-18 15:30 Danielle Ratson
2021-11-18 16:14 ` Alexander Duyck
2021-11-21 11:44   ` Danielle Ratson
2021-11-21 21:16     ` Alexander Duyck
2021-11-23 20:36       ` Jesse Brandeburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210407083748.56b9c261@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=alexander.duyck@gmail.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.