CC: kbuild-all(a)lists.01.org In-Reply-To: <20210407005330.2890430-2-liambeguin@gmail.com> References: <20210407005330.2890430-2-liambeguin@gmail.com> TO: Liam Beguin TO: liambeguin(a)gmail.com TO: mturquette(a)baylibre.com TO: sboyd(a)kernel.org CC: linux-clk(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org CC: devicetree(a)vger.kernel.org CC: robh+dt(a)kernel.org From: kernel test robot drivers/clk/clk-lmk04832.c:1155:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1162. Semantic patch information: False positives can be due to function calls within the for_each loop that may encapsulate an of_node_put. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Liam Beguin Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408 base: f40ddce88593482919761f74910f42f4b84c004b :::::: branch date: 9 hours ago :::::: commit date: 9 hours ago Please take the patch only if it's a positive warning. Thanks! clk-lmk04832.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/clk/clk-lmk04832.c +++ b/drivers/clk/clk-lmk04832.c @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev if (ret) { dev_err(lmk->dev, "missing reg property in child: %s\n", child->full_name); + of_node_put(child); goto err_disable_oscin; }