* [PATCH RESEND -next] drm: kirin: Remove redundant dev_err call in ade_hw_ctx_alloc()
@ 2021-04-07 10:06 ` Wei Li
0 siblings, 0 replies; 2+ messages in thread
From: Wei Li @ 2021-04-07 10:06 UTC (permalink / raw)
To: huawei.libin, Xinliang Liu, Tian Tao, David Airlie,
Daniel Vetter, Philipp Zabel, Thomas Zimmermann, Maxime Ripard,
Laurent Pinchart, Emil Velikov, Sakari Ailus, John Stultz
Cc: dri-devel, linux-kernel, kernel-janitors, Hulk Robot, Wei Li
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Li <liwei391@huawei.com>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 6dcf9ec05eec..78a792048c42 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -857,10 +857,8 @@ static void *ade_hw_ctx_alloc(struct platform_device *pdev,
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ctx->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(ctx->base)) {
- DRM_ERROR("failed to remap ade io base\n");
+ if (IS_ERR(ctx->base))
return ERR_PTR(-EIO);
- }
ctx->reset = devm_reset_control_get(dev, NULL);
if (IS_ERR(ctx->reset))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RESEND -next] drm: kirin: Remove redundant dev_err call in ade_hw_ctx_alloc()
@ 2021-04-07 10:06 ` Wei Li
0 siblings, 0 replies; 2+ messages in thread
From: Wei Li @ 2021-04-07 10:06 UTC (permalink / raw)
To: huawei.libin, Xinliang Liu, Tian Tao, David Airlie,
Daniel Vetter, Philipp Zabel, Thomas Zimmermann, Maxime Ripard,
Laurent Pinchart, Emil Velikov, Sakari Ailus, John Stultz
Cc: Hulk Robot, kernel-janitors, linux-kernel, dri-devel, Wei Li
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Li <liwei391@huawei.com>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
index 6dcf9ec05eec..78a792048c42 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
@@ -857,10 +857,8 @@ static void *ade_hw_ctx_alloc(struct platform_device *pdev,
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ctx->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(ctx->base)) {
- DRM_ERROR("failed to remap ade io base\n");
+ if (IS_ERR(ctx->base))
return ERR_PTR(-EIO);
- }
ctx->reset = devm_reset_control_get(dev, NULL);
if (IS_ERR(ctx->reset))
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-07 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 10:06 [PATCH RESEND -next] drm: kirin: Remove redundant dev_err call in ade_hw_ctx_alloc() Wei Li
2021-04-07 10:06 ` Wei Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.