From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96A5C433ED for ; Wed, 7 Apr 2021 12:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 998F16135D for ; Wed, 7 Apr 2021 12:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352349AbhDGMp4 (ORCPT ); Wed, 7 Apr 2021 08:45:56 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:16061 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235035AbhDGMpy (ORCPT ); Wed, 7 Apr 2021 08:45:54 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FFkb90Pl3z16J2P; Wed, 7 Apr 2021 20:43:33 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 20:45:35 +0800 From: Yu Kuai To: , , CC: , , , , , Subject: [PATCH] stm class: initialize static variable in declaration Date: Wed, 7 Apr 2021 20:53:58 +0800 Message-ID: <20210407125358.4135345-1-yukuai3@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). list head can be initialized automatically with LIST_HEAD() rather than explicitly calling INIT_LIST_HEAD(). srcu_struct can be initialized automatically with DEFINE_STATIC_SRCU() rather than explicitly calling init_srcu_struct(). Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/hwtracing/stm/core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index 2712e699ba08..1e13993e7969 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -31,7 +31,7 @@ static unsigned int stm_core_up; * stm_source_write() caller, which may want to have as little overhead as * possible. */ -static struct srcu_struct stm_source_srcu; +DEFINE_STATIC_SRCU(stm_source_srcu); static ssize_t masters_show(struct device *dev, struct device_attribute *attr, @@ -366,8 +366,8 @@ static int major_match(struct device *dev, const void *data) * Modules can implement STM protocol drivers and (un-)register them * with the STM class framework. */ -static struct list_head stm_pdrv_head; -static struct mutex stm_pdrv_mutex; +static LIST_HEAD(stm_pdrv_head); +static DEFINE_MUTEX(stm_pdrv_mutex); struct stm_pdrv_entry { struct list_head entry; @@ -1324,10 +1324,6 @@ static int __init stm_core_init(void) if (err) goto err_src; - init_srcu_struct(&stm_source_srcu); - INIT_LIST_HEAD(&stm_pdrv_head); - mutex_init(&stm_pdrv_mutex); - /* * So as to not confuse existing users with a requirement * to load yet another module, do it here. -- 2.25.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7438C433B4 for ; Wed, 7 Apr 2021 12:47:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6244D6135D for ; Wed, 7 Apr 2021 12:47:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6244D6135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=AdIi2zMEukPkMdEF3nkcWbGpjA+bEcc+6wXns0vePA8=; b=VgJPV/raimdzVwAwWaDrOKVeZu yAhWAmeZvlh1vH6nel/AJbw+kIJyiclu8hGnpT35ODQZx68Xv2r6rvxIu8VV/nBWsPlkFu8g6M4K0 jg78WqxRLcBcXUraWPxpuaJ5U3h3ylT7IFPRS6fEIA1Y+yEmoUxZGged/m04AJyy3RBxwr28BGuMd wHwm0SssT+bVN3vJS8gByhXPXq6cTys2OnXLk/dmzKJX9eo0z2/Terz3F8fSQmqAvqIXZG2E2NJGb kNvAzmkV62aNiYVLnQ4Fw1NfdngheoA8k7qcwfG4xSOINs6NVdUwQk4CNjna9IRE0Wok0rVf35PBa loKH9OCA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU7ZG-004yw8-Ik; Wed, 07 Apr 2021 12:45:58 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lU7Z9-004yuY-02 for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 12:45:53 +0000 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FFkb90Pl3z16J2P; Wed, 7 Apr 2021 20:43:33 +0800 (CST) Received: from huawei.com (10.175.127.227) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 20:45:35 +0800 From: Yu Kuai To: , , CC: , , , , , Subject: [PATCH] stm class: initialize static variable in declaration Date: Wed, 7 Apr 2021 20:53:58 +0800 Message-ID: <20210407125358.4135345-1-yukuai3@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Originating-IP: [10.175.127.227] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_134551_471353_9AAEA30A X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). list head can be initialized automatically with LIST_HEAD() rather than explicitly calling INIT_LIST_HEAD(). srcu_struct can be initialized automatically with DEFINE_STATIC_SRCU() rather than explicitly calling init_srcu_struct(). Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- drivers/hwtracing/stm/core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index 2712e699ba08..1e13993e7969 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -31,7 +31,7 @@ static unsigned int stm_core_up; * stm_source_write() caller, which may want to have as little overhead as * possible. */ -static struct srcu_struct stm_source_srcu; +DEFINE_STATIC_SRCU(stm_source_srcu); static ssize_t masters_show(struct device *dev, struct device_attribute *attr, @@ -366,8 +366,8 @@ static int major_match(struct device *dev, const void *data) * Modules can implement STM protocol drivers and (un-)register them * with the STM class framework. */ -static struct list_head stm_pdrv_head; -static struct mutex stm_pdrv_mutex; +static LIST_HEAD(stm_pdrv_head); +static DEFINE_MUTEX(stm_pdrv_mutex); struct stm_pdrv_entry { struct list_head entry; @@ -1324,10 +1324,6 @@ static int __init stm_core_init(void) if (err) goto err_src; - init_srcu_struct(&stm_source_srcu); - INIT_LIST_HEAD(&stm_pdrv_head); - mutex_init(&stm_pdrv_mutex); - /* * So as to not confuse existing users with a requirement * to load yet another module, do it here. -- 2.25.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel