From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E175BC43460 for ; Wed, 7 Apr 2021 15:30:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C09DD61382 for ; Wed, 7 Apr 2021 15:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353621AbhDGPbA (ORCPT ); Wed, 7 Apr 2021 11:31:00 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:55370 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353613AbhDGPa5 (ORCPT ); Wed, 7 Apr 2021 11:30:57 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 137FUdNp061591; Wed, 7 Apr 2021 10:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617809439; bh=/lIZwVy1ZVnvPRHkhJ8M6h02XBSL9Vglt6RbLS8Ad1Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jYFdLhL3/hsMuAuxwjTL+ktUwlW56WhbQAxr3pdamvsadO9iPDiLmMeokW9gAfX4g JFwv4/yshBReE0l8owLT4hfCK2L2Ioe0rWhjlDmyqOCoTozeLLSU6WSOasG/bwSyim G132xu9MleWcmB1xmG3whvDk9s3bGdp9QXwVyPcY= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 137FUcfC000528 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Apr 2021 10:30:38 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 7 Apr 2021 10:30:38 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 7 Apr 2021 10:30:38 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 137FUcau113588; Wed, 7 Apr 2021 10:30:38 -0500 Date: Wed, 7 Apr 2021 10:30:38 -0500 From: Nishanth Menon To: Jan Kiszka CC: Aswath Govindraju , Vignesh Raghavendra , Lokesh Vutla , Kishon Vijay Abraham I , Tero Kristo , Rob Herring , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Add support for UHS-I modes in MMCSD1 subsystem Message-ID: <20210407153038.fkwoctn4qvlplxfs@probation> References: <20210407104303.25950-1-a-govindraju@ti.com> <20210407145937.prvue66guhdls2fw@immovably> <7d089f1c-6f9e-82fe-fc8a-42c691d4ec40@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7d089f1c-6f9e-82fe-fc8a-42c691d4ec40@siemens.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17:13-20210407, Jan Kiszka wrote: > On 07.04.21 16:59, Nishanth Menon wrote: > > On 16:13-20210407, Aswath Govindraju wrote: > >> UHS-I speed modes are supported in AM65 S.R. 2.0 SoC[1]. > >> > >> Add support by removing the no-1-8-v tag and including the voltage > >> regulator device tree nodes for power cycling. > >> > >> [1] - https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf, section 12.3.6.1.1 > >> > >> Signed-off-by: Aswath Govindraju > > > >> --- > >> > >> test logs: > >> https://pastebin.ubuntu.com/p/vpYbY9QWh8/ > >> > > Thanks, but I dont plan on queuing this for 5.13-rc1 (my PR is already > > out). but it does trigger an interesting discussion.. > > > >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 - > >> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 33 +++++++++++++++++++ > >> 2 files changed, 33 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > >> index cb340d1b401f..632f32fce4a1 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > >> @@ -301,7 +301,6 @@ > >> ti,otap-del-sel = <0x2>; > >> ti,trm-icp = <0x8>; > >> dma-coherent; > >> - no-1-8-v; > >> }; > >> > > > > Jan - this will break your IOT SR1.0 boards, no? with all the SR1.0, > > 2.0, 2.1 coming along, the plan for TI was to support older revs via > > overlays hoping that older boards will eventually get replaced or die > > out of lack of use.. but you do have production on 1.0 -> so would you > > rather handle this in overlay OR IOT boards dts introduce no-1-8-v > > property? > > I'm fine with pulling anything needed into our board-specific DTs. Those > pending are for SR1.0 boards only. SR2 will come later and have their > own DTs. OK - I think the safe option will be for Ashwath to add no-1-8-v into IOT board.dts as part of this patch to maintain bisectability. > Didn't follow the thread: Where is this patch located wrt my IOT2050 > series? Does it come first first, and we would have to rebase? Or would > this change rather have to move the flag to k3-am65-iot2050-common.dtsi? 5.13 PR is sent https://lore.kernel.org/linux-arm-kernel/20210405155336.smohb7uzkperqwuz@reflex/ IoT is part of that.. I am guessing Arnd / Olof will pick it up later this week or weekend once it goes through their checklist. we are starting to see 5.14 material now, so nothing you need to do from rebase perspective - testing will be appreciated to make sure that the new patches have'nt broken your board. > Thanks a lot for having an eye on these subtle dependencies! Sure.. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EE81C433B4 for ; Wed, 7 Apr 2021 15:32:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E044261394 for ; Wed, 7 Apr 2021 15:32:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E044261394 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ien/dXioYkKmUAQEh9U6G0/qfUalVJXLWqdzNZjPU+I=; b=rWDpO3UeWIZkYk5HTGKx7yja0 pgnpGU0bR8e52mBeDUn4QG6MdY2VDaW0a0pR3oCSntG2+xa8TamxjoAny9jL4rmi4XHpwzzyaf09k oUrnGx0Dk1pzVzIDTIXu1VLsf7jcD+MD4++ZruWcDdXqDQ1U2LYlq/WNUPhIzUHLQzOosiXHHunL5 nhj1Ct8yx/OYwcsqZfuuqhzVRIH+NszbMRbGXuNsNCVyDub7l3pjwhuCDucmy1BLB4M5Y9zQIdkbV eQr2gHMP8dT48Vzx8FeqFbaU/Cp30KFp14oZkAQoqFTGDFLwIWqoov4/VKGxzL7V1iW2coCsA3Df1 YbmMCEnOQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUA8k-005HHs-7C; Wed, 07 Apr 2021 15:30:46 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUA8f-005HH9-Mi for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 15:30:44 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 137FUdNp061591; Wed, 7 Apr 2021 10:30:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617809439; bh=/lIZwVy1ZVnvPRHkhJ8M6h02XBSL9Vglt6RbLS8Ad1Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jYFdLhL3/hsMuAuxwjTL+ktUwlW56WhbQAxr3pdamvsadO9iPDiLmMeokW9gAfX4g JFwv4/yshBReE0l8owLT4hfCK2L2Ioe0rWhjlDmyqOCoTozeLLSU6WSOasG/bwSyim G132xu9MleWcmB1xmG3whvDk9s3bGdp9QXwVyPcY= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 137FUcfC000528 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Apr 2021 10:30:38 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 7 Apr 2021 10:30:38 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 7 Apr 2021 10:30:38 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 137FUcau113588; Wed, 7 Apr 2021 10:30:38 -0500 Date: Wed, 7 Apr 2021 10:30:38 -0500 From: Nishanth Menon To: Jan Kiszka CC: Aswath Govindraju , Vignesh Raghavendra , Lokesh Vutla , Kishon Vijay Abraham I , Tero Kristo , Rob Herring , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Add support for UHS-I modes in MMCSD1 subsystem Message-ID: <20210407153038.fkwoctn4qvlplxfs@probation> References: <20210407104303.25950-1-a-govindraju@ti.com> <20210407145937.prvue66guhdls2fw@immovably> <7d089f1c-6f9e-82fe-fc8a-42c691d4ec40@siemens.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7d089f1c-6f9e-82fe-fc8a-42c691d4ec40@siemens.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_163042_271018_F2C2C3EB X-CRM114-Status: GOOD ( 28.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:13-20210407, Jan Kiszka wrote: > On 07.04.21 16:59, Nishanth Menon wrote: > > On 16:13-20210407, Aswath Govindraju wrote: > >> UHS-I speed modes are supported in AM65 S.R. 2.0 SoC[1]. > >> > >> Add support by removing the no-1-8-v tag and including the voltage > >> regulator device tree nodes for power cycling. > >> > >> [1] - https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf, section 12.3.6.1.1 > >> > >> Signed-off-by: Aswath Govindraju > > > >> --- > >> > >> test logs: > >> https://pastebin.ubuntu.com/p/vpYbY9QWh8/ > >> > > Thanks, but I dont plan on queuing this for 5.13-rc1 (my PR is already > > out). but it does trigger an interesting discussion.. > > > >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 - > >> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 33 +++++++++++++++++++ > >> 2 files changed, 33 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > >> index cb340d1b401f..632f32fce4a1 100644 > >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > >> @@ -301,7 +301,6 @@ > >> ti,otap-del-sel = <0x2>; > >> ti,trm-icp = <0x8>; > >> dma-coherent; > >> - no-1-8-v; > >> }; > >> > > > > Jan - this will break your IOT SR1.0 boards, no? with all the SR1.0, > > 2.0, 2.1 coming along, the plan for TI was to support older revs via > > overlays hoping that older boards will eventually get replaced or die > > out of lack of use.. but you do have production on 1.0 -> so would you > > rather handle this in overlay OR IOT boards dts introduce no-1-8-v > > property? > > I'm fine with pulling anything needed into our board-specific DTs. Those > pending are for SR1.0 boards only. SR2 will come later and have their > own DTs. OK - I think the safe option will be for Ashwath to add no-1-8-v into IOT board.dts as part of this patch to maintain bisectability. > Didn't follow the thread: Where is this patch located wrt my IOT2050 > series? Does it come first first, and we would have to rebase? Or would > this change rather have to move the flag to k3-am65-iot2050-common.dtsi? 5.13 PR is sent https://lore.kernel.org/linux-arm-kernel/20210405155336.smohb7uzkperqwuz@reflex/ IoT is part of that.. I am guessing Arnd / Olof will pick it up later this week or weekend once it goes through their checklist. we are starting to see 5.14 material now, so nothing you need to do from rebase perspective - testing will be appreciated to make sure that the new patches have'nt broken your board. > Thanks a lot for having an eye on these subtle dependencies! Sure.. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel