From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4402728530681472775==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] PCI: dwc: Visoconti: fix platform_get_irq.cocci warnings Date: Thu, 08 Apr 2021 03:34:07 +0800 Message-ID: <20210407193407.GA69596@c450391d744c> In-Reply-To: <202104080208.eHGwItLy-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4402728530681472775== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org In-Reply-To: <20210407031839.386088-3-nobuhiro1.iwamatsu@toshiba.co.jp> References: <20210407031839.386088-3-nobuhiro1.iwamatsu@toshiba.co.jp> TO: Nobuhiro Iwamatsu TO: Bjorn Helgaas TO: Rob Herring TO: Lorenzo Pieralisi CC: linux-pci(a)vger.kernel.org CC: punit1.agrawal(a)toshiba.co.jp CC: yuji2.ishikawa(a)toshiba.co.jp CC: linux-arm-kernel(a)lists.infradead.org CC: linux-kernel(a)vger.kernel.org CC: Nobuhiro Iwamatsu From: kernel test robot drivers/pci/controller/dwc/pcie-visconti.c:274:2-9: line 274 is redundant b= ecause platform_get_irq() already prints an error drivers/pci/controller/dwc/pcie-visconti.c:281:3-10: line 281 is redundant = because platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq*() failures Generated by: scripts/coccinelle/api/platform_get_irq.cocci CC: Nobuhiro Iwamatsu Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Nobuhiro-Iwamatsu/PCI-dwc-= Visoconti-PCIe-RC-controller-driver/20210407-112059 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next :::::: branch date: 16 hours ago :::::: commit date: 16 hours ago Please take the patch only if it's a positive warning. Thanks! pcie-visconti.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/pci/controller/dwc/pcie-visconti.c +++ b/drivers/pci/controller/dwc/pcie-visconti.c @@ -271,14 +271,12 @@ static int visconti_add_pcie_port(struct = pp->irq =3D platform_get_irq_byname(pdev, "intr"); if (pp->irq < 0) { - dev_err(dev, "interrupt intr is missing"); return pp->irq; } = if (IS_ENABLED(CONFIG_PCI_MSI)) { pp->msi_irq =3D platform_get_irq_byname(pdev, "msi"); if (pp->msi_irq < 0) { - dev_err(dev, "interrupt msi is missing"); return pp->msi_irq; } } --===============4402728530681472775==--