From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A63C433ED for ; Wed, 7 Apr 2021 21:34:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0638610D0 for ; Wed, 7 Apr 2021 21:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0638610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUFoj-0007b9-Sj for qemu-devel@archiver.kernel.org; Wed, 07 Apr 2021 17:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUFo2-0007Ao-JS; Wed, 07 Apr 2021 17:33:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:34156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUFo0-0005eV-OA; Wed, 07 Apr 2021 17:33:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0AC62611C9; Wed, 7 Apr 2021 21:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617831221; bh=H3BNz9VL4I6WB9CZkTHtz/z+G5hsGf/gzNTWDNy23Ew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nngyr1mppFnrZT6rxcKuoKepRvQzhNapYJ3XXMnWI4cyxaHeHUuCHq7gIA3powyiC wEAusgs7Untg5K56TqGuqQTGBIgMqbbbSFhTTF7xz2uSRZMokowNy0DvVYkrhue+YS pQVX8iM9yBxsKNycjo4pWn8nu0616T7FMquy2B/Djpwf0qjjj+k3XD/lKyU4ad2jW3 EGEFNeu3LynTzXEL/wMyvItHbxy8MFslosFVG7/FfkXdeo4m8TFVm0VKNSyNMDAYuS dAS0Mttkt5F0HYFsm0ZxObvj0xSXvzlCIVpCZ4gXt3j+NZx7OdAE5d+A3K7WFGZlU5 62ylsVv3vcybg== Date: Wed, 7 Apr 2021 14:33:37 -0700 From: Nathan Chancellor To: Richard Henderson Subject: Re: [PATCH v4 12/12] exec: Fix overlap of PAGE_ANON and PAGE_TARGET_1 Message-ID: <20210407213337.5zzpfs5epzdp75sj@archlinux-ax161> References: <20210406174031.64299-1-richard.henderson@linaro.org> <20210406174031.64299-13-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406174031.64299-13-richard.henderson@linaro.org> Received-SPF: pass client-ip=198.145.29.99; envelope-from=nathan@kernel.org; helo=mail.kernel.org X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Apr 06, 2021 at 10:40:31AM -0700, Richard Henderson wrote: > Unfortuately, the elements of PAGE_* were not in numerical > order and so PAGE_ANON was added to an "unused" bit. > As an arbitrary choice, move PAGE_TARGET_{1,2} together. > > Cc: Laurent Vivier > Fixes: 26bab757d41b ("linux-user: Introduce PAGE_ANON") > Buglink: https://bugs.launchpad.net/bugs/1922617 > Signed-off-by: Richard Henderson Tested-by: Nathan Chancellor > --- > include/exec/cpu-all.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h > index d76b0b9e02..32cfb634c6 100644 > --- a/include/exec/cpu-all.h > +++ b/include/exec/cpu-all.h > @@ -268,8 +268,8 @@ extern intptr_t qemu_host_page_mask; > #define PAGE_RESERVED 0x0100 > #endif > /* Target-specific bits that will be used via page_get_flags(). */ > -#define PAGE_TARGET_1 0x0080 > -#define PAGE_TARGET_2 0x0200 > +#define PAGE_TARGET_1 0x0200 > +#define PAGE_TARGET_2 0x0400 > > #if defined(CONFIG_USER_ONLY) > void page_dump(FILE *f); > -- > 2.25.1 > >