All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 06/19] staging: rtl8723bs: remove all if-else empty blocks left by DBG_871X removal
Date: Thu, 08 Apr 2021 00:55:05 +0800	[thread overview]
Message-ID: <202104080035.ExGBzUdc-lkp@intel.com> (raw)
In-Reply-To: <56055b20bc064d7ac1e8f14bd1ed42aba6b02c36.1617802415.git.fabioaiuto83@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 14651 bytes --]

Hi Fabio,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Fabio-Aiuto/staging-rtl8723bs-remove-DBG_871X-trace-macro/20210407-215248
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 52f8b696b7cdaeba932977ded59816113866e2ab
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f3195b939e7a3415c0a73cedde5a12a7a34f3433
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Fabio-Aiuto/staging-rtl8723bs-remove-DBG_871X-trace-macro/20210407-215248
        git checkout f3195b939e7a3415c0a73cedde5a12a7a34f3433
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8723bs/core/rtw_cmd.c: In function 'rtw_cmd_thread':
>> drivers/staging/rtl8723bs/core/rtw_cmd.c:390:16: warning: variable 'cmd_start_time' set but not used [-Wunused-but-set-variable]
     390 |  unsigned long cmd_start_time;
         |                ^~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/core/rtw_cmd.c:9:
   At top level:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^
--
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_wx_set_mlme':
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1136:6: warning: variable 'reason' set but not used [-Wunused-but-set-variable]
    1136 |  u16 reason;
         |      ^~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: In function 'rtw_dbg_port':
>> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2575:33: warning: variable 'preorder_ctrl' set but not used [-Wunused-but-set-variable]
    2575 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2601:33: warning: variable 'preorder_ctrl' set but not used [-Wunused-but-set-variable]
    2601 |       struct recv_reorder_ctrl *preorder_ctrl;
         |                                 ^~~~~~~~~~~~~
   At top level:
   drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:36:27: warning: 'iw_operation_mode' defined but not used [-Wunused-const-variable=]
      36 | static const char * const iw_operation_mode[] = {
         |                           ^~~~~~~~~~~~~~~~~
   In file included from drivers/staging/rtl8723bs/include/drv_types.h:33,
                    from drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:10:
   drivers/staging/rtl8723bs/include/rtw_security.h:336:28: warning: 'K' defined but not used [-Wunused-const-variable=]
     336 | static const unsigned long K[64] = {
         |                            ^


vim +/cmd_start_time +390 drivers/staging/rtl8723bs/core/rtw_cmd.c

554c0a3abf216c Hans de Goede     2017-03-29  384  
554c0a3abf216c Hans de Goede     2017-03-29  385  int rtw_cmd_thread(void *context)
554c0a3abf216c Hans de Goede     2017-03-29  386  {
554c0a3abf216c Hans de Goede     2017-03-29  387  	u8 ret;
554c0a3abf216c Hans de Goede     2017-03-29  388  	struct cmd_obj *pcmd;
d698b0a0965681 YueHaibing        2019-07-31  389  	u8 *pcmdbuf;
554c0a3abf216c Hans de Goede     2017-03-29 @390  	unsigned long cmd_start_time;
554c0a3abf216c Hans de Goede     2017-03-29  391  	u8 (*cmd_hdl)(struct adapter *padapter, u8 *pbuf);
554c0a3abf216c Hans de Goede     2017-03-29  392  	void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd);
529d87b44da777 Himanshu Jha      2017-08-28  393  	struct adapter *padapter = context;
554c0a3abf216c Hans de Goede     2017-03-29  394  	struct cmd_priv *pcmdpriv = &(padapter->cmdpriv);
554c0a3abf216c Hans de Goede     2017-03-29  395  	struct drvextra_cmd_parm *extra_parm = NULL;
554c0a3abf216c Hans de Goede     2017-03-29  396  
554c0a3abf216c Hans de Goede     2017-03-29  397  	thread_enter("RTW_CMD_THREAD");
554c0a3abf216c Hans de Goede     2017-03-29  398  
554c0a3abf216c Hans de Goede     2017-03-29  399  	pcmdbuf = pcmdpriv->cmd_buf;
554c0a3abf216c Hans de Goede     2017-03-29  400  
554c0a3abf216c Hans de Goede     2017-03-29  401  	pcmdpriv->stop_req = 0;
554c0a3abf216c Hans de Goede     2017-03-29  402  	atomic_set(&(pcmdpriv->cmdthd_running), true);
09a8ea34cf431b Arnd Bergmann     2018-12-10  403  	complete(&pcmdpriv->terminate_cmdthread_comp);
554c0a3abf216c Hans de Goede     2017-03-29  404  
554c0a3abf216c Hans de Goede     2017-03-29  405  	while (1) {
09a8ea34cf431b Arnd Bergmann     2018-12-10  406  		if (wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp)) {
09a8ea34cf431b Arnd Bergmann     2018-12-10  407  			DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT" wait_for_completion_interruptible(&pcmdpriv->cmd_queue_comp) return != 0, break\n", FUNC_ADPT_ARG(padapter));
554c0a3abf216c Hans de Goede     2017-03-29  408  			break;
554c0a3abf216c Hans de Goede     2017-03-29  409  		}
554c0a3abf216c Hans de Goede     2017-03-29  410  
554c0a3abf216c Hans de Goede     2017-03-29  411  		if ((padapter->bDriverStopped == true) || (padapter->bSurpriseRemoved == true)) {
554c0a3abf216c Hans de Goede     2017-03-29  412  			DBG_871X_LEVEL(_drv_always_, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n",
554c0a3abf216c Hans de Goede     2017-03-29  413  				__func__, padapter->bDriverStopped, padapter->bSurpriseRemoved, __LINE__);
554c0a3abf216c Hans de Goede     2017-03-29  414  			break;
554c0a3abf216c Hans de Goede     2017-03-29  415  		}
554c0a3abf216c Hans de Goede     2017-03-29  416  
554c0a3abf216c Hans de Goede     2017-03-29  417  		if (pcmdpriv->stop_req) {
554c0a3abf216c Hans de Goede     2017-03-29  418  			DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT" stop_req:%u, break\n", FUNC_ADPT_ARG(padapter), pcmdpriv->stop_req);
554c0a3abf216c Hans de Goede     2017-03-29  419  			break;
554c0a3abf216c Hans de Goede     2017-03-29  420  		}
554c0a3abf216c Hans de Goede     2017-03-29  421  
554c0a3abf216c Hans de Goede     2017-03-29  422  		if (list_empty(&(pcmdpriv->cmd_queue.queue))) {
554c0a3abf216c Hans de Goede     2017-03-29  423  			continue;
554c0a3abf216c Hans de Goede     2017-03-29  424  		}
554c0a3abf216c Hans de Goede     2017-03-29  425  
13aefa65bc6a63 Fabio Aiuto       2021-04-04  426  		if (rtw_register_cmd_alive(padapter) != _SUCCESS)
554c0a3abf216c Hans de Goede     2017-03-29  427  			continue;
554c0a3abf216c Hans de Goede     2017-03-29  428  
554c0a3abf216c Hans de Goede     2017-03-29  429  _next:
554c0a3abf216c Hans de Goede     2017-03-29  430  		if ((padapter->bDriverStopped == true) || (padapter->bSurpriseRemoved == true)) {
554c0a3abf216c Hans de Goede     2017-03-29  431  			DBG_871X_LEVEL(_drv_always_, "%s: DriverStopped(%d) SurpriseRemoved(%d) break at line %d\n",
554c0a3abf216c Hans de Goede     2017-03-29  432  				__func__, padapter->bDriverStopped, padapter->bSurpriseRemoved, __LINE__);
554c0a3abf216c Hans de Goede     2017-03-29  433  			break;
554c0a3abf216c Hans de Goede     2017-03-29  434  		}
554c0a3abf216c Hans de Goede     2017-03-29  435  
554c0a3abf216c Hans de Goede     2017-03-29  436  		pcmd = rtw_dequeue_cmd(pcmdpriv);
554c0a3abf216c Hans de Goede     2017-03-29  437  		if (!pcmd) {
554c0a3abf216c Hans de Goede     2017-03-29  438  			rtw_unregister_cmd_alive(padapter);
554c0a3abf216c Hans de Goede     2017-03-29  439  			continue;
554c0a3abf216c Hans de Goede     2017-03-29  440  		}
554c0a3abf216c Hans de Goede     2017-03-29  441  
554c0a3abf216c Hans de Goede     2017-03-29  442  		cmd_start_time = jiffies;
554c0a3abf216c Hans de Goede     2017-03-29  443  
92576c84c8c608 Manuel Palenzuela 2020-10-29  444  		if (rtw_cmd_filter(pcmdpriv, pcmd) == _FAIL) {
554c0a3abf216c Hans de Goede     2017-03-29  445  			pcmd->res = H2C_DROPPED;
554c0a3abf216c Hans de Goede     2017-03-29  446  			goto post_process;
554c0a3abf216c Hans de Goede     2017-03-29  447  		}
554c0a3abf216c Hans de Goede     2017-03-29  448  
554c0a3abf216c Hans de Goede     2017-03-29  449  		pcmdpriv->cmd_issued_cnt++;
554c0a3abf216c Hans de Goede     2017-03-29  450  
046bd5c9c2833f Ross Schmidt      2020-10-03  451  		pcmd->cmdsz = round_up((pcmd->cmdsz), 4);
554c0a3abf216c Hans de Goede     2017-03-29  452  
554c0a3abf216c Hans de Goede     2017-03-29  453  		memcpy(pcmdbuf, pcmd->parmbuf, pcmd->cmdsz);
554c0a3abf216c Hans de Goede     2017-03-29  454  
554c0a3abf216c Hans de Goede     2017-03-29  455  		if (pcmd->cmdcode < ARRAY_SIZE(wlancmds)) {
554c0a3abf216c Hans de Goede     2017-03-29  456  			cmd_hdl = wlancmds[pcmd->cmdcode].h2cfuns;
554c0a3abf216c Hans de Goede     2017-03-29  457  
554c0a3abf216c Hans de Goede     2017-03-29  458  			if (cmd_hdl) {
554c0a3abf216c Hans de Goede     2017-03-29  459  				ret = cmd_hdl(pcmd->padapter, pcmdbuf);
554c0a3abf216c Hans de Goede     2017-03-29  460  				pcmd->res = ret;
554c0a3abf216c Hans de Goede     2017-03-29  461  			}
554c0a3abf216c Hans de Goede     2017-03-29  462  
554c0a3abf216c Hans de Goede     2017-03-29  463  			pcmdpriv->cmd_seq++;
554c0a3abf216c Hans de Goede     2017-03-29  464  		} else {
554c0a3abf216c Hans de Goede     2017-03-29  465  			pcmd->res = H2C_PARAMETERS_ERROR;
554c0a3abf216c Hans de Goede     2017-03-29  466  		}
554c0a3abf216c Hans de Goede     2017-03-29  467  
554c0a3abf216c Hans de Goede     2017-03-29  468  		cmd_hdl = NULL;
554c0a3abf216c Hans de Goede     2017-03-29  469  
554c0a3abf216c Hans de Goede     2017-03-29  470  post_process:
554c0a3abf216c Hans de Goede     2017-03-29  471  
554c0a3abf216c Hans de Goede     2017-03-29  472  		if (mutex_lock_interruptible(&(pcmd->padapter->cmdpriv.sctx_mutex)) == 0) {
554c0a3abf216c Hans de Goede     2017-03-29  473  			if (pcmd->sctx) {
554c0a3abf216c Hans de Goede     2017-03-29  474  				DBG_871X_LEVEL(_drv_always_, FUNC_ADPT_FMT" pcmd->sctx\n",
554c0a3abf216c Hans de Goede     2017-03-29  475  					       FUNC_ADPT_ARG(pcmd->padapter));
554c0a3abf216c Hans de Goede     2017-03-29  476  
554c0a3abf216c Hans de Goede     2017-03-29  477  				if (pcmd->res == H2C_SUCCESS)
554c0a3abf216c Hans de Goede     2017-03-29  478  					rtw_sctx_done(&pcmd->sctx);
554c0a3abf216c Hans de Goede     2017-03-29  479  				else
554c0a3abf216c Hans de Goede     2017-03-29  480  					rtw_sctx_done_err(&pcmd->sctx, RTW_SCTX_DONE_CMD_ERROR);
554c0a3abf216c Hans de Goede     2017-03-29  481  			}
554c0a3abf216c Hans de Goede     2017-03-29  482  			mutex_unlock(&(pcmd->padapter->cmdpriv.sctx_mutex));
554c0a3abf216c Hans de Goede     2017-03-29  483  		}
554c0a3abf216c Hans de Goede     2017-03-29  484  
554c0a3abf216c Hans de Goede     2017-03-29  485  		/* call callback function for post-processed */
554c0a3abf216c Hans de Goede     2017-03-29  486  		if (pcmd->cmdcode < ARRAY_SIZE(rtw_cmd_callback)) {
554c0a3abf216c Hans de Goede     2017-03-29  487  			pcmd_callback = rtw_cmd_callback[pcmd->cmdcode].callback;
554c0a3abf216c Hans de Goede     2017-03-29  488  			if (pcmd_callback == NULL) {
554c0a3abf216c Hans de Goede     2017-03-29  489  				rtw_free_cmd_obj(pcmd);
554c0a3abf216c Hans de Goede     2017-03-29  490  			} else {
554c0a3abf216c Hans de Goede     2017-03-29  491  				/* todo: !!! fill rsp_buf to pcmd->rsp if (pcmd->rsp!= NULL) */
858ea450ae5d18 R Veera Kumar     2020-03-26  492  				pcmd_callback(pcmd->padapter, pcmd);/* need consider that free cmd_obj in rtw_cmd_callback */
554c0a3abf216c Hans de Goede     2017-03-29  493  			}
554c0a3abf216c Hans de Goede     2017-03-29  494  		} else {
554c0a3abf216c Hans de Goede     2017-03-29  495  			rtw_free_cmd_obj(pcmd);
554c0a3abf216c Hans de Goede     2017-03-29  496  		}
554c0a3abf216c Hans de Goede     2017-03-29  497  
554c0a3abf216c Hans de Goede     2017-03-29  498  		flush_signals_thread();
554c0a3abf216c Hans de Goede     2017-03-29  499  
554c0a3abf216c Hans de Goede     2017-03-29  500  		goto _next;
554c0a3abf216c Hans de Goede     2017-03-29  501  
554c0a3abf216c Hans de Goede     2017-03-29  502  	}
554c0a3abf216c Hans de Goede     2017-03-29  503  
554c0a3abf216c Hans de Goede     2017-03-29  504  	/*  free all cmd_obj resources */
554c0a3abf216c Hans de Goede     2017-03-29  505  	do {
554c0a3abf216c Hans de Goede     2017-03-29  506  		pcmd = rtw_dequeue_cmd(pcmdpriv);
554c0a3abf216c Hans de Goede     2017-03-29  507  		if (pcmd == NULL) {
554c0a3abf216c Hans de Goede     2017-03-29  508  			rtw_unregister_cmd_alive(padapter);
554c0a3abf216c Hans de Goede     2017-03-29  509  			break;
554c0a3abf216c Hans de Goede     2017-03-29  510  		}
554c0a3abf216c Hans de Goede     2017-03-29  511  
554c0a3abf216c Hans de Goede     2017-03-29  512  		if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
554c0a3abf216c Hans de Goede     2017-03-29  513  			extra_parm = (struct drvextra_cmd_parm *)pcmd->parmbuf;
8f870aab80b041 Manuel Palenzuela 2020-10-28  514  			if (extra_parm->pbuf && extra_parm->size > 0)
554c0a3abf216c Hans de Goede     2017-03-29  515  				kfree(extra_parm->pbuf);
554c0a3abf216c Hans de Goede     2017-03-29  516  		}
554c0a3abf216c Hans de Goede     2017-03-29  517  
554c0a3abf216c Hans de Goede     2017-03-29  518  		rtw_free_cmd_obj(pcmd);
554c0a3abf216c Hans de Goede     2017-03-29  519  	} while (1);
554c0a3abf216c Hans de Goede     2017-03-29  520  
09a8ea34cf431b Arnd Bergmann     2018-12-10  521  	complete(&pcmdpriv->terminate_cmdthread_comp);
554c0a3abf216c Hans de Goede     2017-03-29  522  	atomic_set(&(pcmdpriv->cmdthd_running), false);
554c0a3abf216c Hans de Goede     2017-03-29  523  
554c0a3abf216c Hans de Goede     2017-03-29  524  	thread_exit();
554c0a3abf216c Hans de Goede     2017-03-29  525  }
554c0a3abf216c Hans de Goede     2017-03-29  526  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 67517 bytes --]

  reply	other threads:[~2021-04-07 16:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 13:49 [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Fabio Aiuto
2021-04-07 13:49 ` [PATCH 01/19] staging: rtl8723bs: remove DBG_871X log argument Fabio Aiuto
2021-04-07 13:49 ` [PATCH 02/19] staging: rtl8723bs: remove all DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 03/19] staging: rtl8723bs: remove DBG_871CX log unmatched by cocci Fabio Aiuto
2021-04-07 13:49 ` [PATCH 04/19] staging: rtl8723bs: remove commented out DBG_871X logs Fabio Aiuto
2021-04-07 13:49 ` [PATCH 05/19] staging: rtl8723bs: remove DBG_871X macro definitions Fabio Aiuto
2021-04-07 13:49 ` [PATCH 06/19] staging: rtl8723bs: remove all if-else empty blocks left by DBG_871X removal Fabio Aiuto
2021-04-07 16:55   ` kernel test robot [this message]
2021-04-07 13:49 ` [PATCH 07/19] drivers: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 15:14   ` Greg KH
2021-04-07 15:25     ` Fabio Aiuto
2021-04-07 15:30       ` Greg KH
2021-04-07 15:38         ` Fabio Aiuto
2021-04-07 13:49 ` [PATCH 08/19] staging: rtl8723bs: put constant on the right side in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 09/19] staging: rtl8723bs: remove empty for cycles left by DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 10/19] staging: rtl8723bs: remove empty tracing function dump_rx_packet Fabio Aiuto
2021-04-07 13:49 ` [PATCH 11/19] staging: rtl8723bs: remove empty #ifdef blocks after DBG_871X removal Fabio Aiuto
2021-04-07 13:49 ` [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on DBG_871X removal sites Fabio Aiuto
2021-04-13 14:52   ` Dan Carpenter
2021-04-14  8:32     ` Joe Perches
2021-04-14  8:32       ` Joe Perches
2021-04-07 13:49 ` [PATCH 13/19] staging: rtl8723bs: remove unnecessary parentheses in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 14/19] staging: rtl8723bs: add spaces around operators Fabio Aiuto
2021-04-07 13:49 ` [PATCH 15/19] staging: rtl8723bs: rewrite comparison to null Fabio Aiuto
2021-04-07 13:49 ` [PATCH 16/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 13:49 ` [PATCH 17/19] staging: rtl8723bs: fix comparison in if condition Fabio Aiuto
2021-04-07 13:49 ` [PATCH 18/19] staging: rtl8723bs: split long lines Fabio Aiuto
2021-04-13 14:57   ` Dan Carpenter
2021-04-14  8:17     ` [PATCH] staging: rtl8723bs: fix indentation issue introduced by long line split Fabio Aiuto
2021-04-07 13:49 ` [PATCH 19/19] staging: rtl8723bs: remove unnecessary parentheses Fabio Aiuto
2021-04-07 15:14 ` [PATCH 00/19] staging: rtl8723bs: remove DBG_871X trace macro Greg KH
2021-04-07 16:49   ` Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104080035.ExGBzUdc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.